{"thread":{"id":"1278","subject":"[PATCH 0/9] applymbox updates and assorted trivial patches.","startedAt":"2005-07-20T23:30:29Z","lastAt":"2005-07-21T06:58:42Z","messageCount":3,"participants":["Junio C Hamano","Ryan Anderson"],"isPatch":true,"patchVersion":1,"patchTotal":9},"messages":[{"id":"6282","messageId":"7vy881dpii.fsf@assigned-by-dhcp.cox.net","threadId":"1278","inReplyTo":null,"subject":"[PATCH 0/9] applymbox updates and assorted trivial patches.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-07-20T23:30:29Z","receivedAt":"2005-07-20T23:30:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I was experimenting with applypatch and applymbox to see how it\nfeels like being Linus ;-) and also I saw some trivially correct\npatches on the list floating unmerged during KS/OLS.\n\nSince I rebase my repostitory to fix up the history often, I\nneeded a reliable way to preserve authorship information when I\nexport the patches via format-patch and slurp them via applymbox.\n\nI am sending the following changes to applymbox and format-patch\nfirst:\n\n [PATCH] tools/applymbox: allow manual fixing and continuing after a failure.\n [PATCH] git-format-patch-script and mailinfo updates.\n [PATCH] format-patch: --mbox and --check.\n\nI wrote the first one to recover from a situation where an\nearlier patch failed to apply but I still had many other e-mails\nin the mailbox.\n\nThe second one allows format-patch to give ability to optionally\nadd From: and Date: lines as the first two lines after the patch\ntitle line. The mailinfo program has been enhanced to grok\nDate: in the top part of the message body just like From: in the\nmessage body can override the sender of the e-mail.\n\nThe third one is an extra. It lets me export patches in a\nformat resembling UNIX mbox, so I can concatenate the output\ntogether and reprocess them through applymbox.\n\nAfter they are accepted, I will forward these trivially correct\npatches I saw on the list, using the enhanced format-patch; they\nare expected to be processed with the new applymbox as a\npractice; by doing this I am also ACKing these patches:\n\n [PATCH] debian/ fixes\n [PATCH] Fix a typo in git-unpack-objects documentation.\n [PATCH] Cleanup: git-verify-tag-script\n [PATCH] Install git-verify-tag-script\n [PATCH] Support more http features: https no cert, .netrc -> auth\n [PATCH] Document \"curl\" requirements.\n"},{"id":"6288","messageId":"20050721061906.GN20369@mythryan2.michonline.com","threadId":"1278","inReplyTo":"7vy881dpii.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 0/9] applymbox updates and assorted trivial patches.","fromName":"Ryan Anderson","fromEmail":"ryan@michonline.com","sentAt":"2005-07-21T06:19:06Z","receivedAt":"2005-07-21T06:19:06Z","isPatch":true,"sender":{"key":"ryan@michonline.com","avatar":null},"body":"On Wed, Jul 20, 2005 at 04:30:29PM -0700, Junio C Hamano wrote:\n> Since I rebase my repostitory to fix up the history often, I\n> needed a reliable way to preserve authorship information when I\n> export the patches via format-patch and slurp them via applymbox.\n\nIs it just me, or does format-patch lose the commit comments during\nexport? I haven't experimented with your new patches yet - and since\nI'm at OLS and playing with Git during my free time, my brain is pretty\nmuch shut down now - so if you have happen to have fixed that, thanks!\n\n[...]\n\n> After they are accepted, I will forward these trivially correct\n> patches I saw on the list, using the enhanced format-patch; they\n> are expected to be processed with the new applymbox as a\n> practice; by doing this I am also ACKing these patches:\n> \n> [PATCH] debian/ fixes\n\nI have more debian/ fixes - I cc:ed you on them since I see you are\ncollecting things this week.\n\n-- \n\nRyan Anderson\n sometimes Pug Majere\n"},{"id":"6290","messageId":"7vsly8bq71.fsf@assigned-by-dhcp.cox.net","threadId":"1278","inReplyTo":"20050721061906.GN20369@mythryan2.michonline.com","subject":"Re: [PATCH 0/9] applymbox updates and assorted trivial patches.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-07-21T06:58:42Z","receivedAt":"2005-07-21T06:58:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ryan Anderson writes:\n\n> Is it just me, or does format-patch lose the commit comments during\n> export? I haven't experimented with your new patches yet - and since\n> I'm at OLS and playing with Git during my free time, my brain is pretty\n> much shut down now - so if you have happen to have fixed that, thanks!\n\nOh, I envy you guys! Have fun at OLS.\n\nAs far as I know, the commit comments are not lost since the\noriginal version of format-patch. What I added as extras with\ntoday's patch are the original author name, email and author\ntimestamp. There wasn't a provision to record these in the\noutput from format-patch.\n\nThe applymbox/applypatch pair Linus did allowed you to have an\nextra \"From:\" line as the first line of the e-mail patch\nsubmission when you are forwarding a patch somebody else has\nwritten. When such e-mail is applied to his repository using\napplymbox (back then it was called \"dotest\"), however, the\noriginal author timestamp is lost, and instead the commit gets\ntimestamp from the message forwarding the patch. That is what I\nmeant by the loss of information.\n\nOnce I acked a patch to Linus with \"Author-Date:\" line as the\nsecond line of the e-mail message (the first being the \"From:\"),\nand he told me to refrain from doing it \"for now\", but that \"for\nnow\" has never been lifted, so I decided to lift it myself ;-).\n\nThe changed format-patch can be told to produce \"Date:\" (instead\nof \"Author-Date:\"), and \"From:\". There is a corresponding\nchange to the receiving end (the mailinfo program that is used\nby applymbox/applypatch pair) to read this extra \"Date:\" line\nand use that instead of the timestamp obtained from the e-mail\nsubmission.\n"}]}