{"thread":{"id":"12777","subject":"[PATCH 1/2] t/t7003-filter-branch.sh: use test_must_fail rather than '!'","startedAt":"2008-03-20T16:54:30Z","lastAt":"2008-03-20T16:54:30Z","messageCount":1,"participants":["Brandon Casey"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"72527","messageId":"47E296C6.5080605@nrlssc.navy.mil","threadId":"12777","inReplyTo":null,"subject":"[PATCH 1/2] t/t7003-filter-branch.sh: use test_must_fail rather than '!'","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2008-03-20T16:54:30Z","receivedAt":"2008-03-20T16:54:30Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n---\n t/t7003-filter-branch.sh |   12 ++++++------\n 1 files changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh\nindex 553131f..6827249 100755\n--- a/t/t7003-filter-branch.sh\n+++ b/t/t7003-filter-branch.sh\n@@ -78,7 +78,7 @@ test_expect_success 'filter subdirectory only' '\n test_expect_success 'subdirectory filter result looks okay' '\n \ttest 2 = $(git rev-list sub | wc -l) &&\n \tgit show sub:new &&\n-\t! git show sub:subdir\n+\ttest_must_fail git show sub:subdir\n '\n \n test_expect_success 'setup and filter history that requires --full-history' '\n@@ -100,7 +100,7 @@ test_expect_success 'subdirectory filter result looks okay' '\n \ttest 3 = $(git rev-list -1 --parents sub-master | wc -w) &&\n \tgit show sub-master^:new &&\n \tgit show sub-master^2:new &&\n-\t! git show sub:subdir\n+\ttest_must_fail git show sub:subdir\n '\n \n test_expect_success 'use index-filter to move into a subdirectory' '\n@@ -114,7 +114,7 @@ test_expect_success 'use index-filter to move into a subdirectory' '\n \n test_expect_success 'stops when msg filter fails' '\n \told=$(git rev-parse HEAD) &&\n-\t! git-filter-branch -f --msg-filter false HEAD &&\n+\ttest_must_fail git-filter-branch -f --msg-filter false HEAD &&\n \ttest $old = $(git rev-parse HEAD) &&\n \trm -rf .git-rewrite\n '\n@@ -151,8 +151,8 @@ test_expect_success \"remove a certain author's commits\" '\n '\n \n test_expect_success 'barf on invalid name' '\n-\t! git filter-branch -f master xy-problem &&\n-\t! git filter-branch -f HEAD^\n+\ttest_must_fail git filter-branch -f master xy-problem &&\n+\ttest_must_fail git filter-branch -f HEAD^\n '\n \n test_expect_success '\"map\" works in commit filter' '\n@@ -174,7 +174,7 @@ test_expect_success 'Name needing quotes' '\n \tgit add foo &&\n \tgit commit -m \"Adding a file\" &&\n \tgit filter-branch --tree-filter \"rm -fr foo\" &&\n-\t! git ls-files --error-unmatch \"foo/$name\" &&\n+\ttest_must_fail git ls-files --error-unmatch \"foo/$name\" &&\n \ttest $(git rev-parse --verify rerere) != $(git rev-parse --verify A)\n \n '\n-- \n1.5.4.4.481.g5075\n"}]}