{"thread":{"id":"12756","subject":"[PATCH] builtin-remote: Fix missing newline at end of listing of pushed branches","startedAt":"2008-03-18T20:52:00Z","lastAt":"2008-03-19T20:43:04Z","messageCount":2,"participants":["Johannes Sixt","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"72388","messageId":"200803182152.00187.johannes.sixt@telecom.at","threadId":"12756","inReplyTo":null,"subject":"[PATCH] builtin-remote: Fix missing newline at end of listing of pushed branches","fromName":"Johannes Sixt","fromEmail":"johannes.sixt@telecom.at","sentAt":"2008-03-18T20:52:00Z","receivedAt":"2008-03-18T20:52:00Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Without this the output of 'git remote show' does not end with a new-line:\n\nbash> git remote show repo\n* remote repo\n  URL: repo.or.cz:/srv/git/kdbg.git\n  Tracked remote branches\n    maint master mob\n  Local branch pushed with 'git push'\n    +master:masterbash>\n\nSigned-off-by: Johannes Sixt <johannes.sixt@telecom.at>\n---\n builtin-remote.c  |    1 +\n t/t5505-remote.sh |    6 ++++++\n 2 files changed, 7 insertions(+), 0 deletions(-)\n\ndiff --git a/builtin-remote.c b/builtin-remote.c\nindex 24e6929..d62130d 100644\n--- a/builtin-remote.c\n+++ b/builtin-remote.c\n@@ -469,6 +469,7 @@ static int show_or_prune(int argc, const char **argv, int prune)\n \t\t\t\t\tspec->dst ? \":\" : \"\",\n \t\t\t\t\tskip_prefix(spec->dst, \"refs/heads/\"));\n \t\t\t}\n+\t\t\tprintf(\"\\n\");\n \t\t}\n cleanup_states:\n \t\t/* NEEDSWORK: free remote */\ndiff --git a/t/t5505-remote.sh b/t/t5505-remote.sh\nindex ecfc999..8a88140 100755\n--- a/t/t5505-remote.sh\n+++ b/t/t5505-remote.sh\n@@ -106,6 +106,8 @@ cat > test/expect << EOF\n     master\n   Tracked remote branches\n     side master\n+  Local branches pushed with 'git push'\n+    master:upstream +refs/tags/lastbackup\n EOF\n \n test_expect_success 'show' '\n@@ -118,6 +120,10 @@ test_expect_success 'show' '\n \t  echo 1 > file &&\n \t  test_tick &&\n \t  git commit -m update file) &&\n+\t git config remote.origin.push \\\n+\t\trefs/heads/master:refs/heads/upstream &&\n+\t git config --add remote.origin.push \\\n+\t\t+refs/tags/lastbackup &&\n \t git remote show origin > output &&\n \t git diff expect output)\n '\n-- \n1.5.5.rc0.11.g12588.dirty\n"},{"id":"72395","messageId":"alpine.LSU.1.00.0803192142440.3983@racer.site","threadId":"12756","inReplyTo":"200803182152.00187.johannes.sixt@telecom.at","subject":"Re: [PATCH] builtin-remote: Fix missing newline at end of listing of pushed branches","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-03-19T20:43:04Z","receivedAt":"2008-03-19T20:43:04Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 18 Mar 2008, Johannes Sixt wrote:\n\n> Without this the output of 'git remote show' does not end with a new-line:\n> \n> bash> git remote show repo\n> * remote repo\n>   URL: repo.or.cz:/srv/git/kdbg.git\n>   Tracked remote branches\n>     maint master mob\n>   Local branch pushed with 'git push'\n>     +master:masterbash>\n\nObviously Acked-by: me.\n\nSorry & Thanks,\nDscho\n"}]}