{"thread":{"id":"12731","subject":"[PATCH] Shorten and simplify sendemail.alias* configuration variables.","startedAt":"2008-03-17T22:53:04Z","lastAt":"2008-03-19T01:00:03Z","messageCount":3,"participants":["Xavier Maillard","Frank Lichtenheld"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"72325","messageId":"1205794384-14513-1-git-send-email-xma@gnu.org","threadId":"12731","inReplyTo":null,"subject":"[PATCH] Shorten and simplify sendemail.alias* configuration variables.","fromName":"Xavier Maillard","fromEmail":"xma@gnu.org","sentAt":"2008-03-17T22:53:04Z","receivedAt":"2008-03-17T22:53:04Z","isPatch":true,"sender":{"key":"xma@gnu.org","avatar":null},"body":"I find it more consistent and less error prone to have aliasfile\ninstead of aliasesfile and aliastype instead of aliasfiletype.\n\nDocumentation is also updated to reflect the changes.\n\nSigned-off-by: Xavier Maillard <xma@gnu.org>\n---\n Documentation/git-send-email.txt |    8 ++++----\n git-send-email.perl              |    4 ++--\n 2 files changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 336d797..33fd589 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -192,12 +192,12 @@ sendemail.identity::\n \tidentities and to hoist sensitive authentication information\n \tout of the repository and into the global configuration file.\n \n-sendemail.aliasesfile::\n+sendemail.aliasfile::\n \tTo avoid typing long email addresses, point this to one or more\n-\temail aliases files.  You must also supply 'sendemail.aliasfiletype'.\n+\temail aliases files.  You must also supply 'sendemail.aliastype'.\n \n-sendemail.aliasfiletype::\n-\tFormat of the file(s) specified in sendemail.aliasesfile. Must be\n+sendemail.aliastype::\n+\tFormat of the file(s) specified in sendemail.aliasfile. Must be\n \tone of 'mutt', 'mailrc', 'pine', or 'gnus'.\n \n sendemail.to::\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex be4a20d..1d8bb8e 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -203,9 +203,9 @@ my %config_settings = (\n     \"smtppass\" => \\$smtp_authpass,\n     \"to\" => \\@to,\n     \"cccmd\" => \\$cc_cmd,\n-    \"aliasfiletype\" => \\$aliasfiletype,\n+    \"aliastype\" => \\$aliasfiletype,\n     \"bcc\" => \\@bcclist,\n-    \"aliasesfile\" => \\@alias_files,\n+    \"aliasfile\" => \\@alias_files,\n     \"suppresscc\" => \\@suppress_cc,\n );\n \n-- \n1.5.4.4.685.g64f14.dirty\n"},{"id":"72348","messageId":"20080318081305.GG18624@mail-vs.djpig.de","threadId":"12731","inReplyTo":"1205794384-14513-1-git-send-email-xma@gnu.org","subject":"Re: [PATCH] Shorten and simplify sendemail.alias* configuration variables.","fromName":"Frank Lichtenheld","fromEmail":"frank@lichtenheld.de","sentAt":"2008-03-18T08:13:05Z","receivedAt":"2008-03-18T08:13:05Z","isPatch":true,"sender":{"key":"frank@lichtenheld.de","avatar":"https://gravatar.com/avatar/b9f1d4b120e138f157c9e480d0818197c474628923786adb98f30017cdb99c3c?d=mp&s=160"},"body":"On Mon, Mar 17, 2008 at 11:53:04PM +0100, Xavier Maillard wrote:\n> I find it more consistent and less error prone to have aliasfile\n> instead of aliasesfile and aliastype instead of aliasfiletype.\n\nI don't think that justifies breaking existing configs (which I assume\nit does).\n\nGruesse,\n-- \nFrank Lichtenheld <frank@lichtenheld.de>\nwww: http://www.djpig.de/\n"},{"id":"72369","messageId":"200803190100.m2J103PU032019@localhost.localdomain","threadId":"12731","inReplyTo":"20080318081305.GG18624@mail-vs.djpig.de","subject":"Re: [PATCH] Shorten and simplify sendemail.alias* configuration variables.","fromName":"Xavier Maillard","fromEmail":"xma@gnu.org","sentAt":"2008-03-19T01:00:03Z","receivedAt":"2008-03-19T01:00:03Z","isPatch":true,"sender":{"key":"xma@gnu.org","avatar":null},"body":"\n   On Mon, Mar 17, 2008 at 11:53:04PM +0100, Xavier Maillard wrote:\n   > I find it more consistent and less error prone to have aliasfile\n   > instead of aliasesfile and aliastype instead of aliasfiletype.\n\n   I don't think that justifies breaking existing configs (which I assume\n   it does).\n\nYes it is likely to break configs after this patch has been\napplied. The m;ore confusing part in the current config variables\nis the *aliases* (plural) of the _aliasesfile_ variable.\nActually, I am pretty sure, many people did not notice this\nplural form at first, so did I :)\n\nAnyway, this is just a proposition of changes. Feel free not to\napply it at all.\n\nRegards\n\n\tXavier\n-- \nhttp://www.gnu.org\nhttp://www.april.org\nhttp://www.lolica.org\n"}]}