{"thread":{"id":"1270","subject":"[PATCH 1/6 RESEND] cogito: remove use of xargs -r, a non-portable GNU extension","startedAt":"2005-07-18T03:15:24Z","lastAt":"2005-07-18T03:15:24Z","messageCount":1,"participants":["Bryan Larsen"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"6234","messageId":"20050718031519.20230.85196.sendpatchset@bryan-larsens-ibook-g4.local","threadId":"1270","inReplyTo":null,"subject":"[PATCH 1/6 RESEND] cogito: remove use of xargs -r, a non-portable GNU extension","fromName":"Bryan Larsen","fromEmail":"bryanlarsen@yahoo.com","sentAt":"2005-07-18T03:15:24Z","receivedAt":"2005-07-18T03:15:24Z","isPatch":true,"sender":{"key":"bryan@larsen.st","avatar":"https://avatars.githubusercontent.com/u/32073?v=4"},"body":"Remove usage of xargs -r, a non-portable gnu extension.  \n\nResent with nasty bug fixed.\n\nSigned-off-by: Bryan Larsen <bryan.larsen@gmail.com>\n---\n\n cg-add  |    6 +++---\n cg-init |    2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/cg-add b/cg-add\n--- a/cg-add\n+++ b/cg-add\n@@ -25,8 +25,6 @@ USAGE=\"cg-add [-N] FILE...\"\n \n . ${COGITO_LIB}cg-Xlib\n \n-[ \"$1\" ] || usage\n-\n infoonly=\n while optparse; do\n \tif optparse -N; then\n@@ -36,6 +34,8 @@ while optparse; do\n \tfi\n done\n \n+[ \"$ARGS\" ] || usage\n+\n TMPFILE=$(mktemp -t gitadd.XXXXXX) || exit 1\n find \"${ARGS[@]}\" -type f -print0 > $TMPFILE || {\n \tdie \"not all files exist, nothing added\"\n@@ -43,6 +43,6 @@ find \"${ARGS[@]}\" -type f -print0 > $TMP\n }\n \n cat $TMPFILE | tr '\\0' '\\n' | sed 's/^/Adding file /'\n-cat $TMPFILE | xargs -0r git-update-cache --add ${infoonly} --\n+cat $TMPFILE | xargs -0 git-update-cache --add ${infoonly} --\n \n rm $TMPFILE\ndiff --git a/cg-init b/cg-init\n--- a/cg-init\n+++ b/cg-init\n@@ -55,7 +55,7 @@ if [ \"$uri\" ]; then\n \techo \"Cloned (origin $uri available as branch \\\"origin\\\")\"\n else\n \tgit-read-tree # Seed the dircache\n-\tfind * \\( -type f -o -type l \\) -print0 | xargs -0r cg-add ${infoonly}\n+\t[ \"`ls`\" ] && find * \\( -type f -o -type l \\) -print0 | xargs -0 cg-add ${infoonly}\n \tcg-commit -C -m\"Initial commit\" -E ${infoonly}\n fi\n \n"}]}