{"thread":{"id":"12664","subject":"[PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out","startedAt":"2008-03-13T06:10:40Z","lastAt":"2008-03-14T01:00:05Z","messageCount":3,"participants":["Christian Couder","Junio C Hamano","Xavier Maillard"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"71894","messageId":"20080313071040.bbf5528b.chriscool@tuxfamily.org","threadId":"12664","inReplyTo":null,"subject":"[PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-03-13T06:10:40Z","receivedAt":"2008-03-13T06:10:40Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n help.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\n\tThis was suggested by Xavier Maillard.\n\ndiff --git a/help.c b/help.c\nindex 5da8c9c..ecaca77 100644\n--- a/help.c\n+++ b/help.c\n@@ -139,7 +139,7 @@ static int add_man_viewer(const char *value)\n \telse if (!strcasecmp(value, \"konqueror\"))\n \t\tdo_add_man_viewer(exec_man_konqueror);\n \telse\n-\t\treturn error(\"'%s': unsupported man viewer.\", value);\n+\t\twarning(\"'%s': unsupported man viewer.\", value);\n \n \treturn 0;\n }\n-- \n1.5.4.3.395.g492b.dirty\n"},{"id":"71895","messageId":"7vzlt3ywha.fsf@gitster.siamese.dyndns.org","threadId":"12664","inReplyTo":"20080313071040.bbf5528b.chriscool@tuxfamily.org","subject":"Re: [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-03-13T06:22:09Z","receivedAt":"2008-03-13T06:22:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Christian Couder <chriscool@tuxfamily.org> writes:\n\n> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n> ---\n>  help.c |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> \tThis was suggested by Xavier Maillard.\n>\n> diff --git a/help.c b/help.c\n> index 5da8c9c..ecaca77 100644\n> --- a/help.c\n> +++ b/help.c\n> @@ -139,7 +139,7 @@ static int add_man_viewer(const char *value)\n>  \telse if (!strcasecmp(value, \"konqueror\"))\n>  \t\tdo_add_man_viewer(exec_man_konqueror);\n>  \telse\n> -\t\treturn error(\"'%s': unsupported man viewer.\", value);\n> +\t\twarning(\"'%s': unsupported man viewer.\", value);\n>  \n>  \treturn 0;\n>  }\n\nWhile I'd agree this is a good change, the author should justify it in the\ncommit log message.  I ask list regulars like you to set a good example\nfor others.\n\n\tWhen a document viewer that is unknown to the current version of\n\tgit is specified in the .git/config file, instead of erroring out\n\tthe process completely, just issue a warning.  It might be that\n\tthe user usually is using a newer git that supports it (and the\n\tconfiguration is written for that version) but is temporarily\n\tusing an older git that does not know the viewer.\n"},{"id":"72017","messageId":"200803140100.m2E104Qi004663@localhost.localdomain","threadId":"12664","inReplyTo":"20080313071040.bbf5528b.chriscool@tuxfamily.org","subject":"Re: [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out","fromName":"Xavier Maillard","fromEmail":"xma@gnu.org","sentAt":"2008-03-14T01:00:05Z","receivedAt":"2008-03-14T01:00:05Z","isPatch":true,"sender":{"key":"xma@gnu.org","avatar":null},"body":"\n   Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n\nIt's perfect. Thank you Christian.\n\nTested-by: Xavier Maillard <xma@gnu.org>\n\n\tXavier\n-- \nhttp://www.gnu.org\nhttp://www.april.org\nhttp://www.lolica.org\n"}]}