{"thread":{"id":"12496","subject":"[PATCH] git-submodule: Make update verbose for up to date path","startedAt":"2008-03-04T14:58:11Z","lastAt":"2008-03-04T20:31:03Z","messageCount":5,"participants":["Ping Yin","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"70948","messageId":"1204642691-3220-1-git-send-email-pkufranky@gmail.com","threadId":"12496","inReplyTo":null,"subject":"[PATCH] git-submodule: Make update verbose for up to date path","fromName":"Ping Yin","fromEmail":"pkufranky@gmail.com","sentAt":"2008-03-04T14:58:11Z","receivedAt":"2008-03-04T14:58:11Z","isPatch":true,"sender":{"key":"pkufranky@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5346?v=4"},"body":"When 'git submodule update' runs for multiple modules, give 'up to date'\ninfo for up to date modules should be a good idea to show the progress.\n---\n git-submodule.sh |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/git-submodule.sh b/git-submodule.sh\nindex 67d3224..94e3db7 100755\n--- a/git-submodule.sh\n+++ b/git-submodule.sh\n@@ -305,6 +305,8 @@ cmd_update()\n \t\t\tdie \"Unable to checkout '$sha1' in submodule path '$path'\"\n \n \t\t\tsay \"Submodule path '$path': checked out '$sha1'\"\n+\t\telse\n+\t\t\tsay \"Up to date: $path\"\n \t\tfi\n \tdone\n }\n-- \n1.5.4.3.347.g5314c\n\n"},{"id":"70952","messageId":"alpine.LSU.1.00.0803041503360.22527@racer.site","threadId":"12496","inReplyTo":"1204642691-3220-1-git-send-email-pkufranky@gmail.com","subject":"Re: [PATCH] git-submodule: Make update verbose for up to date path","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-03-04T15:04:02Z","receivedAt":"2008-03-04T15:04:02Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 4 Mar 2008, Ping Yin wrote:\n\n> When 'git submodule update' runs for multiple modules, give 'up to date'\n> info for up to date modules should be a good idea to show the progress.\n\nDoes this not go contrary to our efforts to make Git less chatty?  See \ne.g. the output of push and fetch...\n\nCiao,\nDscho\n"},{"id":"70962","messageId":"46dff0320803040803v2f93d749t6b45fc8e47e66d21@mail.gmail.com","threadId":"12496","inReplyTo":"alpine.LSU.1.00.0803041503360.22527@racer.site","subject":"Re: [PATCH] git-submodule: Make update verbose for up to date path","fromName":"Ping Yin","fromEmail":"pkufranky@gmail.com","sentAt":"2008-03-04T16:03:12Z","receivedAt":"2008-03-04T16:03:12Z","isPatch":true,"sender":{"key":"pkufranky@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5346?v=4"},"body":"On Tue, Mar 4, 2008 at 11:04 PM, Johannes Schindelin\n<Johannes.Schindelin@gmx.de> wrote:\n> Hi,\n>\n>\n>  On Tue, 4 Mar 2008, Ping Yin wrote:\n>\n>  > When 'git submodule update' runs for multiple modules, give 'up to date'\n>  > info for up to date modules should be a good idea to show the progress.\n>\n>  Does this not go contrary to our efforts to make Git less chatty?  See\n>  e.g. the output of push and fetch...\n>\nWhen i run 'git submodule update' in a repository whose submodules are\nall clean, there is not any output which makes me not know whether\nthis command are successful. I think this is not friendly.\n>  Ciao,\n>  Dscho\n>\n\n\n\n-- \nPing Yin\n"},{"id":"70967","messageId":"alpine.LSU.1.00.0803041605450.22527@racer.site","threadId":"12496","inReplyTo":"46dff0320803040803v2f93d749t6b45fc8e47e66d21@mail.gmail.com","subject":"Re: [PATCH] git-submodule: Make update verbose for up to date path","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-03-04T16:08:16Z","receivedAt":"2008-03-04T16:08:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 5 Mar 2008, Ping Yin wrote:\n\n> When i run 'git submodule update' in a repository whose submodules are \n> all clean, there is not any output which makes me not know whether this \n> command are successful. I think this is not friendly.\n\nThe problem is: people ignore output.  Back when merge-recursive was even \nmore chatty than it is now, they happily glanced over the fact that there \nwere _conflicts_.\n\nSo we reduced the output.  Drastically.\n\nFor example, git reset --hard (amongst others) does not output a _thing_ \nif it succeeds.  This is good.  No output means it succeeded.\n\nNow, some other commands take a while to complete, so we have a progress \nwhich kicks in after a second or so.  Still, this is just to keep the user \nbusy when she would otherwise think that Git hangs.\n\nSo no, I do not like submodule becoming chattier.  You can add --verbose \nif you want, but the default should be _quiet_.\n\nCiao,\nDscho\n\n"},{"id":"70989","messageId":"7v7igi5j08.fsf@gitster.siamese.dyndns.org","threadId":"12496","inReplyTo":"46dff0320803040803v2f93d749t6b45fc8e47e66d21@mail.gmail.com","subject":"Re: [PATCH] git-submodule: Make update verbose for up to date path","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-03-04T20:31:03Z","receivedAt":"2008-03-04T20:31:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Ping Yin\" <pkufranky@gmail.com> writes:\n\n> When i run 'git submodule update' in a repository whose submodules are\n> all clean, there is not any output which makes me not know whether\n> this command are successful. I think this is not friendly.\n\nNot at all.  If you are unsuccessful and did not issue an error message,\nyou have a bug to fix.\n\nWhen a command finishes successfully doing what it was asked to do,\nespecially when it does a lot of things and has potential to issue useful\nerror messages and warnings to some but not all of them, it should stay\nquiet for successful ones unless there is a very good reason not to.  The\nreasons may include \"the user told it to be chatty with --verbose\", \"it\nmay make the user think it hang, because it takes a long time\", and\nperhaps \"it is a rare thing to run and the user may not be familiar with\nhow it acts\".\n"}]}