{"thread":{"id":"12467","subject":"[PATCH] Paper bag fix git-describe on packed tags","startedAt":"2008-03-03T23:21:36Z","lastAt":"2008-03-03T23:26:17Z","messageCount":2,"participants":["Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"70852","messageId":"20080303232136.GA15312@spearce.org","threadId":"12467","inReplyTo":null,"subject":"[PATCH] Paper bag fix git-describe on packed tags","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-03-03T23:21:36Z","receivedAt":"2008-03-03T23:21:36Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"In 212945d (\"Teach git-describe to verify annotated tag names\")\nwe tried to access a possibly unparsed tag structure.  We must\nmake sure it was parsed before we try to read its tag name.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n\n As 212945d is already in master this probably should be\n fast-tracked there.  Whoops.  :-)\n\n builtin-describe.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-describe.c b/builtin-describe.c\nindex 2f1e7ba..d4204ee 100644\n--- a/builtin-describe.c\n+++ b/builtin-describe.c\n@@ -156,7 +156,7 @@ static void display_name(struct commit_name *n)\n {\n \tif (n->prio == 2 && !n->tag) {\n \t\tn->tag = lookup_tag(n->sha1);\n-\t\tif (!n->tag || !n->tag->tag)\n+\t\tif (!n->tag || parse_tag(n->tag) || !n->tag->tag)\n \t\t\tdie(\"annotated tag %s not available\", n->path);\n \t\tif (strcmp(n->tag->tag, n->path))\n \t\t\twarning(\"tag '%s' is really '%s' here\", n->tag->tag, n->path);\n-- \n1.5.4.3.509.gf785\n"},{"id":"70853","messageId":"20080303232617.GI8410@spearce.org","threadId":"12467","inReplyTo":"20080303232136.GA15312@spearce.org","subject":"Re: [PATCH] Paper bag fix git-describe on packed tags","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-03-03T23:26:17Z","receivedAt":"2008-03-03T23:26:17Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"\"Shawn O. Pearce\" <spearce@spearce.org> wrote:\n> In 212945d (\"Teach git-describe to verify annotated tag names\")\n> we tried to access a possibly unparsed tag structure.  We must\n> make sure it was parsed before we try to read its tag name.\n> \n> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>\n> ---\n> \n>  As 212945d is already in master this probably should be\n>  fast-tracked there.  Whoops.  :-)\n\nHmmph, looks like you already fixed this with\nc374b91cf295f437d438a103bfd2cf3fffcce580 (\"git-describe: use tags\nfound in packed-refs correctly\").\n\n-- \nShawn.\n"}]}