{"thread":{"id":"12449","subject":"[PATCH] receive-pack: Initialize PATH to include exec-dir.","startedAt":"2008-03-03T04:08:43Z","lastAt":"2008-03-03T04:58:02Z","messageCount":3,"participants":["Björn Steinbrink","Junio C Hamano","Bernt Hansen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"70737","messageId":"20080303040843.GA27185@atjola.homenet","threadId":"12449","inReplyTo":null,"subject":"[PATCH] receive-pack: Initialize PATH to include exec-dir.","fromName":"Björn Steinbrink","fromEmail":"b.steinbrink@gmx.de","sentAt":"2008-03-03T04:08:43Z","receivedAt":"2008-03-03T04:08:43Z","isPatch":true,"sender":{"key":"b.steinbrink@gmx.de","avatar":"https://avatars.githubusercontent.com/u/230962?v=4"},"body":"511707d (use only the $PATH for exec'ing git commands) made it a\nrequirement to call setup_path() to include the git exec-dir in PATH\nbefore spawning any other git commands. git-receive-pack was not yet\nadapted to do this and therefore fails to spawn git-unpack-objects if that\nis not in the standard PATH.\n\nSigned-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>\n---\n receive-pack.c |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/receive-pack.c b/receive-pack.c\nindex a971433..f83ae87 100644\n--- a/receive-pack.c\n+++ b/receive-pack.c\n@@ -471,6 +471,8 @@ int main(int argc, char **argv)\n \tif (!dir)\n \t\tusage(receive_pack_usage);\n \n+\tsetup_path(NULL);\n+\n \tif (!enter_repo(dir, 0))\n \t\tdie(\"'%s': unable to chdir or not a git archive\", dir);\n \n-- \n1.5.4.3.1.g3b5b4\n"},{"id":"70739","messageId":"87ve44cu9m.fsf@gollum.intra.norang.ca","threadId":"12449","inReplyTo":"20080303040843.GA27185@atjola.homenet","subject":"Re: [PATCH] receive-pack: Initialize PATH to include exec-dir.","fromName":"Bernt Hansen","fromEmail":"bernt@norang.ca","sentAt":"2008-03-03T04:21:25Z","receivedAt":"2008-03-03T04:21:25Z","isPatch":true,"sender":{"key":"bernt@norang.ca","avatar":null},"body":"Björn Steinbrink <B.Steinbrink@gmx.de> writes:\n\n> 511707d (use only the $PATH for exec'ing git commands) made it a\n> requirement to call setup_path() to include the git exec-dir in PATH\n> before spawning any other git commands. git-receive-pack was not yet\n> adapted to do this and therefore fails to spawn git-unpack-objects if that\n> is not in the standard PATH.\n>\n> Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>\n> ---\n>  receive-pack.c |    2 ++\n>  1 files changed, 2 insertions(+), 0 deletions(-)\n>\n> diff --git a/receive-pack.c b/receive-pack.c\n> index a971433..f83ae87 100644\n> --- a/receive-pack.c\n> +++ b/receive-pack.c\n> @@ -471,6 +471,8 @@ int main(int argc, char **argv)\n>  \tif (!dir)\n>  \t\tusage(receive_pack_usage);\n>  \n> +\tsetup_path(NULL);\n> +\n>  \tif (!enter_repo(dir, 0))\n>  \t\tdie(\"'%s': unable to chdir or not a git archive\", dir);\n>  \n> -- \n> 1.5.4.3.1.g3b5b4\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n\nTested by: Bernt Hansen <bernt@norang.ca>\n"},{"id":"70738","messageId":"7vtzjojtet.fsf@gitster.siamese.dyndns.org","threadId":"12449","inReplyTo":"20080303040843.GA27185@atjola.homenet","subject":"Re: [PATCH] receive-pack: Initialize PATH to include exec-dir.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-03-03T04:58:02Z","receivedAt":"2008-03-03T04:58:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I think this is a sensible companion patch to the earlier 04b3305\n(upload-pack: Initialize the exec-path.).  We should have done this back\nthen.\n\nThanks.\n"}]}