{"thread":{"id":"12334","subject":"[PATCH] Don't use GIT_CONFIG in t5505-remote","startedAt":"2008-02-26T22:15:31Z","lastAt":"2008-02-27T08:21:13Z","messageCount":4,"participants":["Daniel Barkalow","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"70038","messageId":"alpine.LNX.1.00.0802261713520.19665@iabervon.org","threadId":"12334","inReplyTo":null,"subject":"[PATCH] Don't use GIT_CONFIG in t5505-remote","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2008-02-26T22:15:31Z","receivedAt":"2008-02-26T22:15:31Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"For some reason, t5505-remote was setting GIT_CONFIG to .git/config\nand exporting it. The sole effect of this was to cause the tests to\nfail if \"git clone\" obeyed it (which it presumably should).\n\nSigned-off-by: Daniel Barkalow \n---\nMaybe test-lib used to set GIT_CONFIG to something that would interfere? \nOr the default behavior was wrong?\n\n t/t5505-remote.sh | 3 ---\n 1 files changed, 0 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t5505-remote.sh b/t/t5505-remote.sh\nindex 636aec2..4fc62f5 100755\n--- a/t/t5505-remote.sh\n+++ b/t/t5505-remote.sh\n@@ -4,9 +4,6 @@ test_description='git remote porcelain-ish'\n \n . ./test-lib.sh\n \n-GIT_CONFIG=.git/config\n-export GIT_CONFIG\n-\n setup_repository () {\n \tmkdir \"$1\" && (\n \tcd \"$1\" &&\n-- \n1.5.4.3.328.gcaed\n"},{"id":"70039","messageId":"20080226221959.GB6098@sigill.intra.peff.net","threadId":"12334","inReplyTo":"alpine.LNX.1.00.0802261713520.19665@iabervon.org","subject":"Re: [PATCH] Don't use GIT_CONFIG in t5505-remote","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-02-26T22:19:59Z","receivedAt":"2008-02-26T22:19:59Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Feb 26, 2008 at 05:15:31PM -0500, Daniel Barkalow wrote:\n\n> For some reason, t5505-remote was setting GIT_CONFIG to .git/config\n> and exporting it. The sole effect of this was to cause the tests to\n> fail if \"git clone\" obeyed it (which it presumably should).\n> \n> Signed-off-by: Daniel Barkalow \n> ---\n> Maybe test-lib used to set GIT_CONFIG to something that would interfere? \n> Or the default behavior was wrong?\n\ntest-lib used to set it to \".git/config\" until recently, so this would\nhave been a no-op. As to why it was ever in here, I have no idea.\n\n-Peff\n"},{"id":"70067","messageId":"7vk5kqx18u.fsf@gitster.siamese.dyndns.org","threadId":"12334","inReplyTo":"20080226221959.GB6098@sigill.intra.peff.net","subject":"Re: [PATCH] Don't use GIT_CONFIG in t5505-remote","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-27T08:16:49Z","receivedAt":"2008-02-27T08:16:49Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Tue, Feb 26, 2008 at 05:15:31PM -0500, Daniel Barkalow wrote:\n>\n>> For some reason, t5505-remote was setting GIT_CONFIG to .git/config\n>> and exporting it. The sole effect of this was to cause the tests to\n>> fail if \"git clone\" obeyed it (which it presumably should).\n>> \n>> Signed-off-by: Daniel Barkalow \n>> ---\n>> Maybe test-lib used to set GIT_CONFIG to something that would interfere? \n>> Or the default behavior was wrong?\n>\n> test-lib used to set it to \".git/config\" until recently, so this would\n> have been a no-op. As to why it was ever in here, I have no idea.\n\nRight.\n"},{"id":"70068","messageId":"7vd4qix11i.fsf@gitster.siamese.dyndns.org","threadId":"12334","inReplyTo":"alpine.LNX.1.00.0802261713520.19665@iabervon.org","subject":"Re: [PATCH] Don't use GIT_CONFIG in t5505-remote","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-27T08:21:13Z","receivedAt":"2008-02-27T08:21:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Daniel Barkalow writes:\n\n> For some reason, t5505-remote was setting GIT_CONFIG to .git/config\n> and exporting it. The sole effect of this was to cause the tests to\n> fail if \"git clone\" obeyed it (which it presumably should).\n\nYour patch is correct, as it was a no-op to set and export\nGIT_CONFIG to .git/config there as Jeff pointed out.\n\nBut I think git-clone should explicitly ignore user-supplied\nGIT_CONFIG in the environment if exists, when it wants to update\nthe configuration file for the new repository it created, as I\nmentioned in the other message.\n\nAnd I think scripted version has the same issue. It would\nupdate random places GIT_CONFIG points at, when it wants to\nmodify the configuration file for the new repository it just\nbuilt, which would be a bug.\n"}]}