{"thread":{"id":"12307","subject":"[PATCH] Correct fast-export file mode strings to match fast-import standard","startedAt":"2008-02-25T03:57:29Z","lastAt":"2008-02-26T00:54:39Z","messageCount":2,"participants":["Shawn O. Pearce","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"69846","messageId":"20080225035728.GA26302@spearce.org","threadId":"12307","inReplyTo":null,"subject":"[PATCH] Correct fast-export file mode strings to match fast-import standard","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-02-25T03:57:29Z","receivedAt":"2008-02-25T03:57:29Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"The fast-import file format does not expect leading '0' in front\nof a file mode; that is we want '100644' and '0100644'.\n\nThanks to Ian Clatworthy of the Bazaar project for noticing the\ndifference in output/input.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n builtin-fast-export.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-fast-export.c b/builtin-fast-export.c\nindex 49b54de..e1c5630 100755\n--- a/builtin-fast-export.c\n+++ b/builtin-fast-export.c\n@@ -123,7 +123,7 @@ static void show_filemodify(struct diff_queue_struct *q,\n \t\t\tprintf(\"D %s\\n\", spec->path);\n \t\telse {\n \t\t\tstruct object *object = lookup_object(spec->sha1);\n-\t\t\tprintf(\"M 0%06o :%d %s\\n\", spec->mode,\n+\t\t\tprintf(\"M %06o :%d %s\\n\", spec->mode,\n \t\t\t       get_object_mark(object), spec->path);\n \t\t}\n \t}\n-- \n1.5.4.3.295.g6b554\n"},{"id":"69953","messageId":"alpine.DEB.1.00.0802260054000.3322@eeepc-johanness","threadId":"12307","inReplyTo":"20080225035728.GA26302@spearce.org","subject":"Re: [PATCH] Correct fast-export file mode strings to match fast-import standard","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-02-26T00:54:39Z","receivedAt":"2008-02-26T00:54:39Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sun, 24 Feb 2008, Shawn O. Pearce wrote:\n\n> The fast-import file format does not expect leading '0' in front\n> of a file mode; that is we want '100644' and '0100644'.\n\ns/and/& not/\n\n> -\t\t\tprintf(\"M 0%06o :%d %s\\n\", spec->mode,\n> +\t\t\tprintf(\"M %06o :%d %s\\n\", spec->mode,\n\nDefinitely embarassing.\n\nThanks,\nDscho\n"}]}