{"thread":{"id":"12301","subject":"[EGIT PATCH] Refresh history when \"Refresh\" is clicked in the history viewer.","startedAt":"2008-02-24T22:40:08Z","lastAt":"2008-02-25T00:11:13Z","messageCount":4,"participants":["Roger C. Soares","Robin Rosenberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"69830","messageId":"200802242340.09606.robin.rosenberg@dewire.com","threadId":"12301","inReplyTo":"1203895097-3742-1-git-send-email-rogersoares@intelinet.com.br","subject":"Re: [EGIT PATCH] Refresh history when \"Refresh\" is clicked in the history viewer.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2008-02-24T22:40:08Z","receivedAt":"2008-02-24T22:40:08Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"måndagen den 25 februari 2008 skrev Roger C. Soares:\n> ---\n>  .../src/org/spearce/egit/ui/GitHistoryPage.java    |    8 ++++++--\n>  1 files changed, 6 insertions(+), 2 deletions(-)\n\nLooks ok, but what is the effect of refresh, besides possibly working around\nother bugs? I would expect to to refresh with the selected resource as \"filter\",\nbut it doesn't.\n\n-- robin\n"},{"id":"69821","messageId":"1203895097-3742-1-git-send-email-rogersoares@intelinet.com.br","threadId":"12301","inReplyTo":null,"subject":"[EGIT PATCH] Refresh history when \"Refresh\" is clicked in the history viewer.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-02-24T23:18:17Z","receivedAt":"2008-02-24T23:18:17Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"---\n .../src/org/spearce/egit/ui/GitHistoryPage.java    |    8 ++++++--\n 1 files changed, 6 insertions(+), 2 deletions(-)\n\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java\nindex 2fc7afa..268a6ba 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java\n@@ -1207,8 +1207,12 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,\n \t}\n \n \tpublic void refresh() {\n-\t\t// TODO Auto-generated method stub\n-\n+\t\tif (historyRefreshJob.cancel()) {\n+\t\t\tSystem.out.println(\"rescheduling\");\n+\t\t\thistoryRefreshJob.schedule();\n+\t\t} else {\n+\t\t\tSystem.out.println(\"failed to cancel?\");\n+\t\t}\n \t}\n \n \tpublic Object getAdapter(Class adapter) {\n-- \n1.5.4.1\n"},{"id":"69833","messageId":"47C206AF.8050904@intelinet.com.br","threadId":"12301","inReplyTo":"200802242340.09606.robin.rosenberg@dewire.com","subject":"Re: [EGIT PATCH] Refresh history when \"Refresh\" is clicked in the history viewer.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-02-25T00:07:11Z","receivedAt":"2008-02-25T00:07:11Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"\nRobin Rosenberg escreveu:\n> Looks ok, but what is the effect of refresh, besides possibly working around\n> other bugs? I would expect to to refresh with the selected resource as \"filter\",\n> but it doesn't.\n>   \nIf you checkout a branch in gitk or commit something using git-gui or \ngit command line, egit will be out of sync. Refresh updates the history \nview to the current status.\n\nI'm not sure I understand what you were expecting, what do you mean by \n\"filter\"?\n\n[]s,\nRoger.\n"},{"id":"69834","messageId":"200802250111.15172.robin.rosenberg@dewire.com","threadId":"12301","inReplyTo":"47C206AF.8050904@intelinet.com.br","subject":"Re: [EGIT PATCH] Refresh history when \"Refresh\" is clicked in the history viewer.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2008-02-25T00:11:13Z","receivedAt":"2008-02-25T00:11:13Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"måndagen den 25 februari 2008 skrev Roger C. Soares:\n> \n> Robin Rosenberg escreveu:\n> > Looks ok, but what is the effect of refresh, besides possibly working around\n> > other bugs? I would expect to to refresh with the selected resource as \"filter\",\n> > but it doesn't.\n> >   \n> If you checkout a branch in gitk or commit something using git-gui or \n> git command line, egit will be out of sync. Refresh updates the history \n> view to the current status.\nOk, thanks. I'll publish this.  \n\n> I'm not sure I understand what you were expecting, what do you mean by \n> \"filter\"?\n\nHistory is filtered using the selected item in the project explorer and\noptions from the buttons in the history brower.\n"}]}