{"thread":{"id":"12269","subject":"[PATCH] t4014: Replace sed's non-standard 'Q' by standard 'q'","startedAt":"2008-02-23T08:41:56Z","lastAt":"2008-02-23T19:34:53Z","messageCount":4,"participants":["Steffen Prohaska","Junio C Hamano","Daniel Barkalow"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"69662","messageId":"12037561161987-git-send-email-prohaska@zib.de","threadId":"12269","inReplyTo":null,"subject":"[PATCH] t4014: Replace sed's non-standard 'Q' by standard 'q'","fromName":"Steffen Prohaska","fromEmail":"prohaska@zib.de","sentAt":"2008-02-23T08:41:56Z","receivedAt":"2008-02-23T08:41:56Z","isPatch":true,"sender":{"key":"prohaska@zib.de","avatar":"https://avatars.githubusercontent.com/u/217580?v=4"},"body":"This commit should be applied on top of db/cover-letter.\n\n-- >8 --\n\nThis commit avoids sed's 'Q' operator. The Open Group's sed\nman page [1] does not mention 'Q'. sed on Mac OS X 10.4\ndoes not accept Q. 'q' is sufficient for our purpose.\n\n[1] http://opengroup.org/onlinepubs/007908799/xcu/sed.html\n\nSigned-off-by: Steffen Prohaska \n---\n t/t4014-format-patch.sh | 8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh\nindex a39e786..16aa99d 100755\n--- a/t/t4014-format-patch.sh\n+++ b/t/t4014-format-patch.sh\n@@ -95,7 +95,7 @@ test_expect_success 'extra headers' '\n \tgit config --add format.headers \"Cc: S. E. Cipient \n \" &&\n \tgit format-patch --stdout master..side > patch2 &&\n-\tsed -e \"/^$/Q\" patch2 > hdrs2 &&\n+\tsed -e \"/^$/q\" patch2 > hdrs2 &&\n \tgrep \"^To: R. E. Cipient $\" hdrs2 &&\n \tgrep \"^Cc: S. E. Cipient $\" hdrs2\n \t\n@@ -106,7 +106,7 @@ test_expect_success 'extra headers without newlines' '\n \tgit config --replace-all format.headers \"To: R. E. Cipient \" &&\n \tgit config --add format.headers \"Cc: S. E. Cipient \" &&\n \tgit format-patch --stdout master..side >patch3 &&\n-\tsed -e \"/^$/Q\" patch3 > hdrs3 &&\n+\tsed -e \"/^$/q\" patch3 > hdrs3 &&\n \tgrep \"^To: R. E. Cipient $\" hdrs3 &&\n \tgrep \"^Cc: S. E. Cipient $\" hdrs3\n \t\n@@ -117,7 +117,7 @@ test_expect_success 'extra headers with multiple To:s' '\n \tgit config --replace-all format.headers \"To: R. E. Cipient \" &&\n \tgit config --add format.headers \"To: S. E. Cipient \" &&\n \tgit format-patch --stdout master..side > patch4 &&\n-\tsed -e \"/^$/Q\" patch4 > hdrs4 &&\n+\tsed -e \"/^$/q\" patch4 > hdrs4 &&\n \tgrep \"^To: R. E. Cipient ,$\" hdrs4 &&\n \tgrep \"^ *S. E. Cipient $\" hdrs4\n '\n@@ -125,7 +125,7 @@ test_expect_success 'extra headers with multiple To:s' '\n test_expect_success 'additional command line cc' '\n \n \tgit config --replace-all format.headers \"Cc: R. E. Cipient \" &&\n-\tgit format-patch --cc=\"S. E. Cipient \" --stdout master..side | sed -e \"/^$/Q\" >patch5 &&\n+\tgit format-patch --cc=\"S. E. Cipient \" --stdout master..side | sed -e \"/^$/q\" >patch5 &&\n \tgrep \"^Cc: R. E. Cipient ,$\" patch5 &&\n \tgrep \"^ *S. E. Cipient $\" patch5\n '\n-- \n1.5.4.2.199.gb454ad\n"},{"id":"69692","messageId":"7vy79b34w1.fsf@gitster.siamese.dyndns.org","threadId":"12269","inReplyTo":"12037561161987-git-send-email-prohaska@zib.de","subject":"Re: [PATCH] t4014: Replace sed's non-standard 'Q' by standard 'q'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-23T18:27:10Z","receivedAt":"2008-02-23T18:27:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Steffen Prohaska writes:\n\n> This commit should be applied on top of db/cover-letter.\n>\n> -- >8 --\n>\n> This commit avoids sed's 'Q' operator. The Open Group's sed\n> man page [1] does not mention 'Q'. sed on Mac OS X 10.4\n> does not accept Q. 'q' is sufficient for our purpose.\n\nThanks.\n\n> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh\n> index a39e786..16aa99d 100755\n> --- a/t/t4014-format-patch.sh\n> +++ b/t/t4014-format-patch.sh\n> @@ -95,7 +95,7 @@ test_expect_success 'extra headers' '\n> \tgit config --add format.headers \"Cc: S. E. Cipient \n> \" &&\n> \tgit format-patch --stdout master..side > patch2 &&\n> -\tsed -e \"/^$/Q\" patch2 > hdrs2 &&\n> +\tsed -e \"/^$/q\" patch2 > hdrs2 &&\n> \tgrep \"^To: R. E. Cipient $\" hdrs2 &&\n> \tgrep \"^Cc: S. E. Cipient $\" hdrs2\n> \t\n\nI usually try to be pretty careful about these kind of things,\nbut these somehow slipped in. Changing them to 'q' means the\noutput will now have an additional blank line at the end, but\nthat would not affect the result the later tests inspect, so\nit's a good change.\n"},{"id":"69697","messageId":"alpine.LNX.1.00.0802231426560.19024@iabervon.org","threadId":"12269","inReplyTo":"12037561161987-git-send-email-prohaska@zib.de","subject":"Re: [PATCH] t4014: Replace sed's non-standard 'Q' by standard 'q'","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2008-02-23T19:28:57Z","receivedAt":"2008-02-23T19:28:57Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"On Sat, 23 Feb 2008, Steffen Prohaska wrote:\n\n> This commit should be applied on top of db/cover-letter.\n> \n> -- >8 --\n> \n> This commit avoids sed's 'Q' operator. The Open Group's sed\n> man page [1] does not mention 'Q'. sed on Mac OS X 10.4\n> does not accept Q. 'q' is sufficient for our purpose.\n> \n> [1] http://opengroup.org/onlinepubs/007908799/xcu/sed.html\n\nLooks good to me; GNU man pages annoyingly don't tell you what's not more \nstandard.\n\n\t-Daniel\n*This .sig left intentionally blank*\n"},{"id":"69700","messageId":"7vlk5b31r6.fsf@gitster.siamese.dyndns.org","threadId":"12269","inReplyTo":"alpine.LNX.1.00.0802231426560.19024@iabervon.org","subject":"Re: [PATCH] t4014: Replace sed's non-standard 'Q' by standard 'q'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-23T19:34:53Z","receivedAt":"2008-02-23T19:34:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Daniel Barkalow writes:\n\n> On Sat, 23 Feb 2008, Steffen Prohaska wrote:\n>\n>> This commit should be applied on top of db/cover-letter.\n>> \n>> -- >8 --\n>> \n>> This commit avoids sed's 'Q' operator. The Open Group's sed\n>> man page [1] does not mention 'Q'. sed on Mac OS X 10.4\n>> does not accept Q. 'q' is sufficient for our purpose.\n>> \n>> [1] http://opengroup.org/onlinepubs/007908799/xcu/sed.html\n>\n> Looks good to me; GNU man pages annoyingly don't tell you what's not more \n> standard.\n\nProbably. You have to be an old git ;-)\n"}]}