{"thread":{"id":"12263","subject":"[PATCH] git.el: find the git-status buffer whatever its name is","startedAt":"2008-02-22T21:45:17Z","lastAt":"2008-02-29T18:28:19Z","messageCount":6,"participants":["Rémi Vanicat","Remi Vanicat","Alexandre Julliard","Junio C Hamano","Xavier Maillard"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"69618","messageId":"87hcg0fyxe.dlv@maison.homelinux.org","threadId":"12263","inReplyTo":null,"subject":"[PATCH] git.el: find the git-status buffer whatever its name is","fromName":"Rémi Vanicat","fromEmail":"vanicat@debian.org","sentAt":"2008-02-22T21:45:17Z","receivedAt":"2008-02-22T21:45:17Z","isPatch":true,"sender":{"key":"vanicat@debian.org","avatar":"https://gravatar.com/avatar/cd491a7f4c221349809a60f88fc21326b97cce2a705e318898aa74851db92409?d=mp&s=160"},"body":"\ngit-status used the buffer name to find git-status buffers, and that\ncould failed if the buffer had another name, for example when multiple\nworking directories was tracked.\nSigned-off-by: Rémi Vanicat \n---\n contrib/emacs/git.el | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/emacs/git.el b/contrib/emacs/git.el\nindex f69b697..14a1601 100644\n--- a/contrib/emacs/git.el\n+++ b/contrib/emacs/git.el\n@@ -1545,7 +1545,7 @@ Commands:\n (with-current-buffer buffer\n (when (and list-buffers-directory\n (string-equal fulldir (expand-file-name list-buffers-directory))\n- (string-match \"\\\\*git-status\\\\*$\" (buffer-name buffer)))\n+\t\t (eq major-mode 'git-status-mode))\n (setq found buffer))))\n (setq list (cdr list)))\n found))\n-- \n1.5.4.2.191.g7b407\n\n\n-- \nRémi Vanicat\n"},{"id":"70252","messageId":"87skzd44qn.dlv@maison.homelinux.org","threadId":"12263","inReplyTo":"87hcg0fyxe.dlv@maison.homelinux.org","subject":"Re: [PATCH] git.el: find the git-status buffer whatever its name is","fromName":"Remi Vanicat","fromEmail":"vanicat@debian.org","sentAt":"2008-02-28T12:58:40Z","receivedAt":"2008-02-28T12:58:40Z","isPatch":true,"sender":{"key":"vanicat@debian.org","avatar":"https://gravatar.com/avatar/cd491a7f4c221349809a60f88fc21326b97cce2a705e318898aa74851db92409?d=mp&s=160"},"body":"Any comment on this bug fix ? It seem it was forgotten.\nI re-include it for convenience:\n\n\nFrom 8ab57162a69c178dbc04bc4f94271e36ee9d120a Mon Sep 17 00:00:00 2001\nFrom: Rémi Vanicat \nDate: Fri, 22 Feb 2008 22:36:23 +0100\nSubject: [PATCH] git.el: find the git-status buffer whatever its name is\n\ngit-status used the buffer name to find git-status buffers, and that\ncould failed if the buffer had another name, for example when multiple\nworking directories was tracked.\n---\n contrib/emacs/git.el | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/emacs/git.el b/contrib/emacs/git.el\nindex f69b697..14a1601 100644\n--- a/contrib/emacs/git.el\n+++ b/contrib/emacs/git.el\n@@ -1545,7 +1545,7 @@ Commands:\n (with-current-buffer buffer\n (when (and list-buffers-directory\n (string-equal fulldir (expand-file-name list-buffers-directory))\n- (string-match \"\\\\*git-status\\\\*$\" (buffer-name buffer)))\n+\t\t (eq major-mode 'git-status-mode))\n (setq found buffer))))\n (setq list (cdr list)))\n found))\n-- \n1.5.4.2.191.g7b407\n\n\n-- \nRémi Vanicat\n"},{"id":"70256","messageId":"871w6x2n5e.fsf@wine.dyndns.org","threadId":"12263","inReplyTo":"87skzd44qn.dlv@maison.homelinux.org","subject":"Re: [PATCH] git.el: find the git-status buffer whatever its name is","fromName":"Alexandre Julliard","fromEmail":"julliard@winehq.org","sentAt":"2008-02-28T14:03:57Z","receivedAt":"2008-02-28T14:03:57Z","isPatch":true,"sender":{"key":"julliard@winehq.org","avatar":null},"body":"Remi Vanicat writes:\n\n> Any comment on this bug fix ? It seem it was forgotten.\n> I re-include it for convenience:\n\nLooks good to me.\n\n-- \nAlexandre Julliard\njulliard@winehq.org\n"},{"id":"70297","messageId":"7vprugj0t2.fsf@gitster.siamese.dyndns.org","threadId":"12263","inReplyTo":"87skzd44qn.dlv@maison.homelinux.org","subject":"Re: [PATCH] git.el: find the git-status buffer whatever its name is","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-28T20:14:33Z","receivedAt":"2008-02-28T20:14:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Remi Vanicat writes:\n\n> Any comment on this bug fix ? It seem it was forgotten.\n> I re-include it for convenience:\n\nIt is very cumbersome to apply if you \"include everything\ninside\", so please don't do this.\n\nInstead, send as if it is a new patch, adding Acked-by: by Alexandre\nafter your Signed-off-by: line.\n\n> From 8ab57162a69c178dbc04bc4f94271e36ee9d120a Mon Sep 17 00:00:00 2001\n> From: Rémi Vanicat \n> Date: Fri, 22 Feb 2008 22:36:23 +0100\n> Subject: [PATCH] git.el: find the git-status buffer whatever its name is\n>\n> git-status used the buffer name to find git-status buffers, and that\n> could failed if the buffer had another name, for example when multiple\n> working directories was tracked.\n> ---\n> contrib/emacs/git.el | 2 +-\n> 1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el\n> index f69b697..14a1601 100644\n> --- a/contrib/emacs/git.el\n> +++ b/contrib/emacs/git.el\n> @@ -1545,7 +1545,7 @@ Commands:\n> (with-current-buffer buffer\n> (when (and list-buffers-directory\n> (string-equal fulldir (expand-file-name list-buffers-directory))\n> - (string-match \"\\\\*git-status\\\\*$\" (buffer-name buffer)))\n> +\t\t (eq major-mode 'git-status-mode))\n> (setq found buffer))))\n> (setq list (cdr list)))\n> found))\n> -- \n> 1.5.4.2.191.g7b407\n>\n>\n> -- \n> Rémi Vanicat\n"},{"id":"70358","messageId":"200802290200.m1T20MGr018035@localhost.localdomain","threadId":"12263","inReplyTo":"87skzd44qn.dlv@maison.homelinux.org","subject":"Re: [PATCH] git.el: find the git-status buffer whatever its name is","fromName":"Xavier Maillard","fromEmail":"xma@gnu.org","sentAt":"2008-02-29T02:00:23Z","receivedAt":"2008-02-29T02:00:23Z","isPatch":true,"sender":{"key":"xma@gnu.org","avatar":null},"body":"\n Any comment on this bug fix ? It seem it was forgotten.\n I re-include it for convenience:\n\nTested here, it works like a champ.\n\n\tXavier\n-- \nhttp://www.gnu.org\nhttp://www.april.org\nhttp://www.lolica.org\n"},{"id":"70405","messageId":"87wson1ut8.dlv@maison.homelinux.org","threadId":"12263","inReplyTo":"7vprugj0t2.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] git.el: find the git-status buffer whatever its name is","fromName":"Rémi Vanicat","fromEmail":"vanicat@debian.org","sentAt":"2008-02-29T18:28:19Z","receivedAt":"2008-02-29T18:28:19Z","isPatch":true,"sender":{"key":"vanicat@debian.org","avatar":"https://gravatar.com/avatar/cd491a7f4c221349809a60f88fc21326b97cce2a705e318898aa74851db92409?d=mp&s=160"},"body":"git-status used the buffer name to find git-status buffers, and that\ncould failed if the buffer had another name, for example when multiple\nworking directories was tracked.\nSigned-off-by: Rémi Vanicat \nAcked-by: Alexandre Julliard \nTested-by: Xavier Maillard \n---\nResend as requested\n contrib/emacs/git.el | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/emacs/git.el b/contrib/emacs/git.el\nindex f69b697..14a1601 100644\n--- a/contrib/emacs/git.el\n+++ b/contrib/emacs/git.el\n@@ -1545,7 +1545,7 @@ Commands:\n (with-current-buffer buffer\n (when (and list-buffers-directory\n (string-equal fulldir (expand-file-name list-buffers-directory))\n- (string-match \"\\\\*git-status\\\\*$\" (buffer-name buffer)))\n+\t\t (eq major-mode 'git-status-mode))\n (setq found buffer))))\n (setq list (cdr list)))\n found))\n-- \n1.5.4.2.191.g7b407\n\n\n-- \nRémi Vanicat\n\n\n\n-- \nRémi Vanicat\n"}]}