{"thread":{"id":"12238","subject":"git-send-email getting filtered as spam by vger.kernel.org","startedAt":"2008-02-21T09:29:58Z","lastAt":"2008-02-27T19:48:50Z","messageCount":14,"participants":["Len Brown","Uwe Kleine-König","Junio C Hamano","Mike Hommey","Jay Soffian"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"69469","messageId":"200802210429.58353.lenb@kernel.org","threadId":"12238","inReplyTo":null,"subject":"git-send-email getting filtered as spam by vger.kernel.org","fromName":"Len Brown","fromEmail":"lenb@kernel.org","sentAt":"2008-02-21T09:29:58Z","receivedAt":"2008-02-21T09:29:58Z","isPatch":false,"sender":{"key":"lenb@kernel.org","avatar":null},"body":"git-send-email is getting filtered by vger.kernel.org\n\ngit --version\ngit version 1.5.4.2.184.gb23b\n\nExample rejected message below.\nsent this way:\n\ngit-send-email --from \"Len Brown \" --compose --to linux-acpi@vger.kernel.org --smtp-server 192.168.0.6 --suppress-from --no-chain-reply-to patch-release\n\nand then tried again with --chain-reply-to, but it also has not survived vger.kernel.org.\n\nwhen it prompts \"Message-ID to be used as In-Reply-To for the first email?\"\nI simply hit return, b/c I have no idea how to answer that question.\n\nThis has worked for me many times in the past, but seems to have broken recently.\nI don't know if it was a change in git, or a change on vger.kernel.org.\n\nclues?\n\nthanks,\n-Len\n\n---------- Forwarded Message ----------\n\nSubject: Fw: TABOO linux-acpi@vger.kernel.org: global taboo header: m/<>/ global taboo header: m/<>/\nDate: Thursday 21 February 2008 03:56\nFrom: David Miller \nTo: lenb@kernel.org\nCc: len.brown@intel.com\n\n\nAll of your postings to the mailing list bounced because of those \"<>\"\nthings in your headers. We block that because it is a pattern\nfrequently used by spammers to cover up their Received headers.\n\n...\n\nThanks.\n\n\n-------------------------------------------------------\n>From lenb@kernel.org Thu Feb 21 03:46:40 2008\nReceived: from mga09.intel.com ([134.134.136.24]:62635 \"EHLO mga09.intel.com\"\n rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n id S1755925AbYBUIqc (ORCPT );\n Thu, 21 Feb 2008 03:46:32 -0500\nReceived: from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga102.jf.intel.com with ESMTP; 21 Feb 2008 00:46:30 -0800\nX-ExtLoop1: 1\nX-IronPort-AV: E=Sophos;i=\"4.25,385,1199692800\"; \n d=\"scan'208\";a=\"300482149\"\nReceived: from unknown (HELO localhost.localdomain) ([10.127.56.36])\n by fmsmga002.fm.intel.com with ESMTP; 21 Feb 2008 00:44:45 -0800\nFrom: Len Brown \nTo: linux-acpi@vger.kernel.org\nCc: Henrique de Moraes Holschuh ,\n Len Brown \nSubject: [PATCH 14/26] ACPI: thinkpad-acpi: make the video output feature optional\nDate: Thu, 21 Feb 2008 03:45:16 -0500\nMessage-Id: \nX-Mailer: git-send-email 1.5.4.2.184.gb23b\nIn-Reply-To: <>\nReferences: <>\nIn-Reply-To: <208c70a45624400fafd7511b96bc426bf01f8f5e.1203581637.git.len.brown@intel.com>\nReferences: <208c70a45624400fafd7511b96bc426bf01f8f5e.1203581637.git.len.brown@intel.com>\nOrganization: Intel Open Source Technology Center\nReturn-Path: \nX-Envelope-To: <\"|/opt/Majordomo/wrapper resend -l linux-acpi -f x-linux-acpi -h vger.kernel.org linux-acpi-outgoing\"> (uid 400)\nX-Orcpt: rfc822;linux-acpi@vger.kernel.org\nOriginal-Recipient: rfc822;linux-acpi@vger.kernel.org\n\nFrom: Henrique de Moraes Holschuh \n\nThe video output port control feature is not very useful on many ThinkPads\n(especially when a X server is running), and lately userspace is getting\nbetter and better at it, so it makes sense to allow users to stripe out the\nthinkpad-acpi video feature from their kernels and save at least 2KB.\n\nSigned-off-by: Henrique de Moraes Holschuh \nSigned-off-by: Len Brown \n---\n drivers/misc/Kconfig | 17 +++++++++++++++++\n drivers/misc/thinkpad_acpi.c | 20 +++++++++++++-------\n 2 files changed, 30 insertions(+), 7 deletions(-)\n\ndiff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig\nindex 1abc95c..982e27b 100644\n--- a/drivers/misc/Kconfig\n+++ b/drivers/misc/Kconfig\n@@ -258,6 +258,23 @@ config THINKPAD_ACPI_BAY\n \n If you are not sure, say Y here.\n \n+config THINKPAD_ACPI_VIDEO\n+ bool \"Video output control support\"\n+ depends on THINKPAD_ACPI\n+ default y\n+ ---help---\n+ Allows the thinkpad_acpi driver to provide an interface to control\n+ the various video output ports.\n+\n+ This feature often won't work well, depending on ThinkPad model,\n+ display state, video output devices in use, whether there is a X\n+ server running, phase of the moon, and the current mood of\n+ Schroedinger's cat. If you can use X.org's RandR to control\n+ your ThinkPad's video output ports instead of this feature,\n+ don't think twice: do it and say N here to save some memory.\n+\n+ If you are not sure, say Y here.\n+\n config THINKPAD_ACPI_HOTKEY_POLL\n bool \"Suport NVRAM polling for hot keys\"\n depends on THINKPAD_ACPI\ndiff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c\nindex 02f9465..4ea3866 100644\n--- a/drivers/misc/thinkpad_acpi.c\n+++ b/drivers/misc/thinkpad_acpi.c\n@@ -301,6 +301,13 @@ TPACPI_HANDLE(hkey, ec, \"\\\\_SB.HKEY\", /* 600e/x, 770e, 770x */\n \"HKEY\", /* all others */\n ); /* 570 */\n \n+TPACPI_HANDLE(vid, root, \"\\\\_SB.PCI.AGP.VGA\", /* 570 */\n+ \"\\\\_SB.PCI0.AGP0.VID0\", /* 600e/x, 770x */\n+ \"\\\\_SB.PCI0.VID0\", /* 770e */\n+ \"\\\\_SB.PCI0.VID\", /* A21e, G4x, R50e, X30, X40 */\n+ \"\\\\_SB.PCI0.AGP.VID\", /* all others */\n+ ); /* R30, R31 */\n+\n \n /*************************************************************************\n * ACPI helpers\n@@ -2680,6 +2687,8 @@ static struct ibm_struct wan_driver_data = {\n * Video subdriver\n */\n \n+#ifdef CONFIG_THINKPAD_ACPI_VIDEO\n+\n enum video_access_mode {\n TPACPI_VIDEO_NONE = 0,\n TPACPI_VIDEO_570, /* 570 */\n@@ -2707,13 +2716,6 @@ static int video_orig_autosw;\n static int video_autosw_get(void);\n static int video_autosw_set(int enable);\n \n-TPACPI_HANDLE(vid, root, \"\\\\_SB.PCI.AGP.VGA\", /* 570 */\n- \"\\\\_SB.PCI0.AGP0.VID0\", /* 600e/x, 770x */\n- \"\\\\_SB.PCI0.VID0\", /* 770e */\n- \"\\\\_SB.PCI0.VID\", /* A21e, G4x, R50e, X30, X40 */\n- \"\\\\_SB.PCI0.AGP.VID\", /* all others */\n- ); /* R30, R31 */\n-\n TPACPI_HANDLE(vid2, root, \"\\\\_SB.PCI0.AGPB.VID\"); /* G41 */\n \n static int __init video_init(struct ibm_init_struct *iibm)\n@@ -3023,6 +3025,8 @@ static struct ibm_struct video_driver_data = {\n .exit = video_exit,\n };\n \n+#endif /* CONFIG_THINKPAD_ACPI_VIDEO */\n+\n /*************************************************************************\n * Light (thinklight) subdriver\n */\n@@ -5807,10 +5811,12 @@ static struct ibm_init_struct ibms_init[] __initdata = {\n .init = wan_init,\n .data = &wan_driver_data,\n },\n+#ifdef CONFIG_THINKPAD_ACPI_VIDEO\n {\n .init = video_init,\n .data = &video_driver_data,\n },\n+#endif\n {\n .init = light_init,\n .data = &light_driver_data,\n-- \n1.5.4.2.184.gb23b\n"},{"id":"69470","messageId":"200802210721.29188.lenb@kernel.org","threadId":"12238","inReplyTo":"200802210429.58353.lenb@kernel.org","subject":"Re: git-send-email getting filtered as spam by vger.kernel.org","fromName":"Len Brown","fromEmail":"lenb@kernel.org","sentAt":"2008-02-21T12:21:29Z","receivedAt":"2008-02-21T12:21:29Z","isPatch":false,"sender":{"key":"lenb@kernel.org","avatar":null},"body":"It looks like the same patches formatted and set with git 1.5.4.2\nmade it through to the list.\n\n-Len\n\nOn Thursday 21 February 2008 04:29, Len Brown wrote:\n> git-send-email is getting filtered by vger.kernel.org\n> \n> git --version\n> git version 1.5.4.2.184.gb23b\n> \n> Example rejected message below.\n> sent this way:\n> \n> git-send-email --from \"Len Brown \" --compose --to linux-acpi@vger.kernel.org --smtp-server 192.168.0.6 --suppress-from --no-chain-reply-to patch-release\n> \n> and then tried again with --chain-reply-to, but it also has not survived vger.kernel.org.\n> \n> when it prompts \"Message-ID to be used as In-Reply-To for the first email?\"\n> I simply hit return, b/c I have no idea how to answer that question.\n> \n> This has worked for me many times in the past, but seems to have broken recently.\n> I don't know if it was a change in git, or a change on vger.kernel.org.\n> \n> clues?\n> \n> thanks,\n> -Len\n> \n> ---------- Forwarded Message ----------\n> \n> Subject: Fw: TABOO linux-acpi@vger.kernel.org: global taboo header: m/<>/ global taboo header: m/<>/\n> Date: Thursday 21 February 2008 03:56\n> From: David Miller \n> To: lenb@kernel.org\n> Cc: len.brown@intel.com\n> \n> \n> All of your postings to the mailing list bounced because of those \"<>\"\n> things in your headers. We block that because it is a pattern\n> frequently used by spammers to cover up their Received headers.\n> \n> ...\n> \n> Thanks.\n> \n> \n> -------------------------------------------------------\n> >From lenb@kernel.org Thu Feb 21 03:46:40 2008\n> Received: from mga09.intel.com ([134.134.136.24]:62635 \"EHLO mga09.intel.com\"\n> rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n> id S1755925AbYBUIqc (ORCPT );\n> Thu, 21 Feb 2008 03:46:32 -0500\n> Received: from fmsmga002.fm.intel.com ([10.253.24.26])\n> by orsmga102.jf.intel.com with ESMTP; 21 Feb 2008 00:46:30 -0800\n> X-ExtLoop1: 1\n> X-IronPort-AV: E=Sophos;i=\"4.25,385,1199692800\"; \n> d=\"scan'208\";a=\"300482149\"\n> Received: from unknown (HELO localhost.localdomain) ([10.127.56.36])\n> by fmsmga002.fm.intel.com with ESMTP; 21 Feb 2008 00:44:45 -0800\n> From: Len Brown \n> To: linux-acpi@vger.kernel.org\n> Cc: Henrique de Moraes Holschuh ,\n> Len Brown \n> Subject: [PATCH 14/26] ACPI: thinkpad-acpi: make the video output feature optional\n> Date: Thu, 21 Feb 2008 03:45:16 -0500\n> Message-Id: \n> X-Mailer: git-send-email 1.5.4.2.184.gb23b\n> In-Reply-To: <>\n> References: <>\n> In-Reply-To: <208c70a45624400fafd7511b96bc426bf01f8f5e.1203581637.git.len.brown@intel.com>\n> References: <208c70a45624400fafd7511b96bc426bf01f8f5e.1203581637.git.len.brown@intel.com>\n> Organization: Intel Open Source Technology Center\n> Return-Path: \n> X-Envelope-To: <\"|/opt/Majordomo/wrapper resend -l linux-acpi -f x-linux-acpi -h vger.kernel.org linux-acpi-outgoing\"> (uid 400)\n> X-Orcpt: rfc822;linux-acpi@vger.kernel.org\n> Original-Recipient: rfc822;linux-acpi@vger.kernel.org\n> \n> From: Henrique de Moraes Holschuh \n> \n> The video output port control feature is not very useful on many ThinkPads\n> (especially when a X server is running), and lately userspace is getting\n> better and better at it, so it makes sense to allow users to stripe out the\n> thinkpad-acpi video feature from their kernels and save at least 2KB.\n> \n> Signed-off-by: Henrique de Moraes Holschuh \n> Signed-off-by: Len Brown \n> ---\n> drivers/misc/Kconfig | 17 +++++++++++++++++\n> drivers/misc/thinkpad_acpi.c | 20 +++++++++++++-------\n> 2 files changed, 30 insertions(+), 7 deletions(-)\n> \n> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig\n> index 1abc95c..982e27b 100644\n> --- a/drivers/misc/Kconfig\n> +++ b/drivers/misc/Kconfig\n> @@ -258,6 +258,23 @@ config THINKPAD_ACPI_BAY\n> \n> If you are not sure, say Y here.\n> \n> +config THINKPAD_ACPI_VIDEO\n> + bool \"Video output control support\"\n> + depends on THINKPAD_ACPI\n> + default y\n> + ---help---\n> + Allows the thinkpad_acpi driver to provide an interface to control\n> + the various video output ports.\n> +\n> + This feature often won't work well, depending on ThinkPad model,\n> + display state, video output devices in use, whether there is a X\n> + server running, phase of the moon, and the current mood of\n> + Schroedinger's cat. If you can use X.org's RandR to control\n> + your ThinkPad's video output ports instead of this feature,\n> + don't think twice: do it and say N here to save some memory.\n> +\n> + If you are not sure, say Y here.\n> +\n> config THINKPAD_ACPI_HOTKEY_POLL\n> bool \"Suport NVRAM polling for hot keys\"\n> depends on THINKPAD_ACPI\n> diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c\n> index 02f9465..4ea3866 100644\n> --- a/drivers/misc/thinkpad_acpi.c\n> +++ b/drivers/misc/thinkpad_acpi.c\n> @@ -301,6 +301,13 @@ TPACPI_HANDLE(hkey, ec, \"\\\\_SB.HKEY\", /* 600e/x, 770e, 770x */\n> \"HKEY\", /* all others */\n> ); /* 570 */\n> \n> +TPACPI_HANDLE(vid, root, \"\\\\_SB.PCI.AGP.VGA\", /* 570 */\n> + \"\\\\_SB.PCI0.AGP0.VID0\", /* 600e/x, 770x */\n> + \"\\\\_SB.PCI0.VID0\", /* 770e */\n> + \"\\\\_SB.PCI0.VID\", /* A21e, G4x, R50e, X30, X40 */\n> + \"\\\\_SB.PCI0.AGP.VID\", /* all others */\n> + ); /* R30, R31 */\n> +\n> \n> /*************************************************************************\n> * ACPI helpers\n> @@ -2680,6 +2687,8 @@ static struct ibm_struct wan_driver_data = {\n> * Video subdriver\n> */\n> \n> +#ifdef CONFIG_THINKPAD_ACPI_VIDEO\n> +\n> enum video_access_mode {\n> TPACPI_VIDEO_NONE = 0,\n> TPACPI_VIDEO_570, /* 570 */\n> @@ -2707,13 +2716,6 @@ static int video_orig_autosw;\n> static int video_autosw_get(void);\n> static int video_autosw_set(int enable);\n> \n> -TPACPI_HANDLE(vid, root, \"\\\\_SB.PCI.AGP.VGA\", /* 570 */\n> - \"\\\\_SB.PCI0.AGP0.VID0\", /* 600e/x, 770x */\n> - \"\\\\_SB.PCI0.VID0\", /* 770e */\n> - \"\\\\_SB.PCI0.VID\", /* A21e, G4x, R50e, X30, X40 */\n> - \"\\\\_SB.PCI0.AGP.VID\", /* all others */\n> - ); /* R30, R31 */\n> -\n> TPACPI_HANDLE(vid2, root, \"\\\\_SB.PCI0.AGPB.VID\"); /* G41 */\n> \n> static int __init video_init(struct ibm_init_struct *iibm)\n> @@ -3023,6 +3025,8 @@ static struct ibm_struct video_driver_data = {\n> .exit = video_exit,\n> };\n> \n> +#endif /* CONFIG_THINKPAD_ACPI_VIDEO */\n> +\n> /*************************************************************************\n> * Light (thinklight) subdriver\n> */\n> @@ -5807,10 +5811,12 @@ static struct ibm_init_struct ibms_init[] __initdata = {\n> .init = wan_init,\n> .data = &wan_driver_data,\n> },\n> +#ifdef CONFIG_THINKPAD_ACPI_VIDEO\n> {\n> .init = video_init,\n> .data = &video_driver_data,\n> },\n> +#endif\n> {\n> .init = light_init,\n> .data = &light_driver_data,\n"},{"id":"69512","messageId":"20080221205104.GA14247@informatik.uni-freiburg.de","threadId":"12238","inReplyTo":"200802210721.29188.lenb@kernel.org","subject":"Re: git-send-email getting filtered as spam by vger.kernel.org","fromName":"Uwe Kleine-König","fromEmail":"ukleinek@informatik.uni-freiburg.de","sentAt":"2008-02-21T20:51:04Z","receivedAt":"2008-02-21T20:51:04Z","isPatch":false,"sender":{"key":"u.kleine-koenig@pengutronix.de","avatar":"https://gravatar.com/avatar/354b5e3ceb2806a2f1e1e382ac29ddbdad18288654da62b61eb13583a857eee7?d=mp&s=160"},"body":"Len Brown wrote:\n> It looks like the same patches formatted and set with git 1.5.4.2\n> made it through to the list.\nI suspect 1ca3d6ed01774eab37e96d9c88b840ea618f97af.\n\nBest regards\nUwe\n\n-- \nUwe Kleine-König\n"},{"id":"69516","messageId":"7vejb6t3kk.fsf@gitster.siamese.dyndns.org","threadId":"12238","inReplyTo":"20080221205104.GA14247@informatik.uni-freiburg.de","subject":"Re: git-send-email getting filtered as spam by vger.kernel.org","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-21T21:14:19Z","receivedAt":"2008-02-21T21:14:19Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Uwe Kleine-König writes:\n\n> Len Brown wrote:\n>> It looks like the same patches formatted and set with git 1.5.4.2\n>> made it through to the list.\n> I suspect 1ca3d6ed01774eab37e96d9c88b840ea618f97af.\n\nWhen you talk about commits, please also add the summary line,\nlike this [*1*]:\n\n 1ca3d6e (send-email: squelch warning due to comparing undefined $_ to \"\")\n\nLen said he has the issue with v1.5.4.2-184-gb23b27e but not\nwith v1.5.4.2.\n\n $ git lg v1.5.4.2..b23b27e -- git-send-email.perl\n 1ca3d6e... send-email: squelch warning due to comparing undefined $_ to \"\"\n 6564828... git-send-email: Generalize auto-cc recipient mechanism.\n 8a7c56e... git-send-email: Better handling of EOF\n 8742997... git-send-email: SIG{TERM,INT} handlers\n 2363d74... git-send-email: ssh/login style password requests\n\nand I think you are right. I see In-reply-to: <> in the reject\nmessage.\n\nPerhaps we should fix it up like this...\n\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex ccb87a2..c9f8c6b 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -475,7 +475,7 @@ if ($thread && !defined $initial_reply_to && $prompting) {\n \n \t$initial_reply_to = $_;\n }\n-if (defined $initial_reply_to) {\n+if (defined $initial_reply_to && $initial_reply_to ne '') {\n \t$initial_reply_to =~ s/^\\s*?\\s*$/>/;\n }\n\n\n\n[Footnote]\n\n*1* Here is what I have in $HOME/.gitconfig to allow me to say\n\"git one 1ca3d6ed0177\".\n\n[alias]\n\tlg = log --pretty=oneline --abbrev-commit\n\tone = show -s --pretty='format:%h (%s)'\n"},{"id":"69519","messageId":"20080221213423.GA31786@glandium.org","threadId":"12238","inReplyTo":"7vejb6t3kk.fsf@gitster.siamese.dyndns.org","subject":"Re: git-send-email getting filtered as spam by vger.kernel.org","fromName":"Mike Hommey","fromEmail":"mh@glandium.org","sentAt":"2008-02-21T21:34:23Z","receivedAt":"2008-02-21T21:34:23Z","isPatch":false,"sender":{"key":"mh@glandium.org","avatar":"https://avatars.githubusercontent.com/u/1038527?v=4"},"body":"On Thu, Feb 21, 2008 at 01:14:19PM -0800, Junio C Hamano wrote:\n> Uwe Kleine-König writes:\n> \n> > Len Brown wrote:\n> >> It looks like the same patches formatted and set with git 1.5.4.2\n> >> made it through to the list.\n> > I suspect 1ca3d6ed01774eab37e96d9c88b840ea618f97af.\n> \n> When you talk about commits, please also add the summary line,\n> like this [*1*]:\n> \n> 1ca3d6e (send-email: squelch warning due to comparing undefined $_ to \"\")\n> \n> Len said he has the issue with v1.5.4.2-184-gb23b27e but not\n> with v1.5.4.2.\n> \n> $ git lg v1.5.4.2..b23b27e -- git-send-email.perl\n> 1ca3d6e... send-email: squelch warning due to comparing undefined $_ to \"\"\n> 6564828... git-send-email: Generalize auto-cc recipient mechanism.\n> 8a7c56e... git-send-email: Better handling of EOF\n> 8742997... git-send-email: SIG{TERM,INT} handlers\n> 2363d74... git-send-email: ssh/login style password requests\n> \n> and I think you are right. I see In-reply-to: <> in the reject\n> message.\n> \n> Perhaps we should fix it up like this...\n(...)\n\nAnd perhaps add a test, because it's not the first time the issue is\ndiscussed http://kerneltrap.org/mailarchive/git/2007/12/11/488243 ;)\n\nMike\n"},{"id":"69520","messageId":"76718490802211341o1ddc36bbne4e6d551712e7cd0@mail.gmail.com","threadId":"12238","inReplyTo":"7vejb6t3kk.fsf@gitster.siamese.dyndns.org","subject":"Re: git-send-email getting filtered as spam by vger.kernel.org","fromName":"Jay Soffian","fromEmail":"jaysoffian@gmail.com","sentAt":"2008-02-21T21:41:08Z","receivedAt":"2008-02-21T21:41:08Z","isPatch":false,"sender":{"key":"jaysoffian@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155970?v=4"},"body":"On Thu, Feb 21, 2008 at 4:14 PM, Junio C Hamano wrote:\n> Perhaps we should fix it up like this...\n\nDoh, my bad...\n\n> diff --git a/git-send-email.perl b/git-send-email.perl\n> index ccb87a2..c9f8c6b 100755\n> --- a/git-send-email.perl\n> +++ b/git-send-email.perl\n> @@ -475,7 +475,7 @@ if ($thread && !defined $initial_reply_to && $prompting) {\n>\n> $initial_reply_to = $_;\n> }\n> -if (defined $initial_reply_to) {\n> +if (defined $initial_reply_to && $initial_reply_to ne '') {\n> $initial_reply_to =~ s/^\\s* $initial_reply_to =~ s/>?\\s*$/>/;\n> }\n\nActually:\n\nif ($initial_reply_to) { ...\n\nshould be all that's needed.\n\nj.\n"},{"id":"69523","messageId":"20080221214959.GA4338@glandium.org","threadId":"12238","inReplyTo":"76718490802211341o1ddc36bbne4e6d551712e7cd0@mail.gmail.com","subject":"Re: git-send-email getting filtered as spam by vger.kernel.org","fromName":"Mike Hommey","fromEmail":"mh@glandium.org","sentAt":"2008-02-21T21:49:59Z","receivedAt":"2008-02-21T21:49:59Z","isPatch":false,"sender":{"key":"mh@glandium.org","avatar":"https://avatars.githubusercontent.com/u/1038527?v=4"},"body":"On Thu, Feb 21, 2008 at 04:41:08PM -0500, Jay Soffian wrote:\n> On Thu, Feb 21, 2008 at 4:14 PM, Junio C Hamano wrote:\n> > Perhaps we should fix it up like this...\n> \n> Doh, my bad...\n> \n> > diff --git a/git-send-email.perl b/git-send-email.perl\n> > index ccb87a2..c9f8c6b 100755\n> > --- a/git-send-email.perl\n> > +++ b/git-send-email.perl\n> > @@ -475,7 +475,7 @@ if ($thread && !defined $initial_reply_to && $prompting) {\n> >\n> > $initial_reply_to = $_;\n> > }\n> > -if (defined $initial_reply_to) {\n> > +if (defined $initial_reply_to && $initial_reply_to ne '') {\n> > $initial_reply_to =~ s/^\\s* > $initial_reply_to =~ s/>?\\s*$/>/;\n> > }\n> \n> Actually:\n> \n> if ($initial_reply_to) { ...\n> \n> should be all that's needed.\n\nAnd reminds me something ;)\nhttp://kerneltrap.org/mailarchive/git/2007/12/11/488177\n\nMike\n"},{"id":"69524","messageId":"76718490802211351n1f0a6c36nb84902a624ee2120@mail.gmail.com","threadId":"12238","inReplyTo":"20080221214959.GA4338@glandium.org","subject":"Re: git-send-email getting filtered as spam by vger.kernel.org","fromName":"Jay Soffian","fromEmail":"jaysoffian@gmail.com","sentAt":"2008-02-21T21:51:49Z","receivedAt":"2008-02-21T21:51:49Z","isPatch":false,"sender":{"key":"jaysoffian@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155970?v=4"},"body":"On Thu, Feb 21, 2008 at 4:49 PM, Mike Hommey wrote:\n> And reminds me something ;)\n> http://kerneltrap.org/mailarchive/git/2007/12/11/488177\n\nOkay, I'll contribute a patch with a test case since I broke it (this time...).\n\nj.\n"},{"id":"69526","messageId":"7v4pc2t181.fsf@gitster.siamese.dyndns.org","threadId":"12238","inReplyTo":"20080221214959.GA4338@glandium.org","subject":"Re: git-send-email getting filtered as spam by vger.kernel.org","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-21T22:05:02Z","receivedAt":"2008-02-21T22:05:02Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mike Hommey writes:\n\n> And reminds me something ;)\n> http://kerneltrap.org/mailarchive/git/2007/12/11/488177\n\nAlthough I admit I try to be less picky about what I am not a\nheavy user of, I do not want to be deliberately sloppy by saying\n\"if ($var)\" in Perl when $var is an end-user string (i.e. could\nbe \"0\").\n\nYes, it is unlikely the user mistypes \"0\" when asked for a\nmessage Id, but it is just a matter of principle...\n \n"},{"id":"69542","messageId":"1203639364-91817-1-git-send-email-jaysoffian@gmail.com","threadId":"12238","inReplyTo":"76718490802211351n1f0a6c36nb84902a624ee2120@mail.gmail.com","subject":"[PATCH] send-email: fix In-Reply-To regression","fromName":"Jay Soffian","fromEmail":"jaysoffian@gmail.com","sentAt":"2008-02-22T00:16:04Z","receivedAt":"2008-02-22T00:16:04Z","isPatch":true,"sender":{"key":"jaysoffian@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155970?v=4"},"body":"Fix a regression introduced by\n\n1ca3d6e (send-email: squelch warning due to comparing undefined $_ to \"\")\n\nwhere if the user was prompted for an initial In-Reply-To and didn't\nprovide one, messages would be sent out with an invalid In-Reply-To of\n\"<>\"\n\nAlso add test cases for the regression and the fix. A small modification\nwas needed to allow send-email to take its replies from stdin if the\nenvironment variable GIT_SEND_EMAIL_NOTTY is set.\n\nSigned-off-by: Jay Soffian \n---\n\nAn issue cropped up with testing the regression: it only occured if\ninitial_reply_to was \"\", and the only way to do that is to respond to\nthe Initial-Reply-To prompt with \"\\n\". But send-email uses readline,\nwhich insists on /dev/tty.\n\nSo, I initially simulated the breakage by using --initial-reply-to=\" \",\nbut this isn't quite the same thing. However, it turns out this can also\ncause an invalid In-Reply-To, which wasn't fixed by Junio's suggestion\nof checking that initial_reply_to ne \"\". So I did a slightly different\nfix that handles initial_reply_to eq \" \".\n\nAnyway, back to testing the original problem. I didn't want to use\nexpect or Expect.pm, so I made a small change to send-email where if\nGIT_SEND_EMAIL_NOTTY is set, it will read from stdin instead of\n/dev/tty.\n\nBut, I wonder if in the future we'll want to enhance the testing\nframework to be able to do expect-type stuff?\n\nj.\n\n git-send-email.perl | 9 ++++++---\n t/t9001-send-email.sh | 21 +++++++++++++++++++++\n 2 files changed, 27 insertions(+), 3 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex ccb87a2..29b1105 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -170,7 +170,9 @@ my $envelope_sender;\n \n my $repo = Git->repository();\n my $term = eval {\n-\tnew Term::ReadLine 'git-send-email';\n+\t$ENV{\"GIT_SEND_EMAIL_NOTTY\"}\n+\t\t? new Term::ReadLine 'git-send-email', \\*STDIN, \\*STDOUT\n+\t\t: new Term::ReadLine 'git-send-email';\n };\n if ($@) {\n \t$term = new FakeTerm \"$@: going non-interactive\";\n@@ -476,8 +478,9 @@ if ($thread && !defined $initial_reply_to && $prompting) {\n \t$initial_reply_to = $_;\n }\n if (defined $initial_reply_to) {\n-\t$initial_reply_to =~ s/^\\s*?\\s*$/>/;\n+\t$initial_reply_to =~ s/^\\s*?\\s*$//;\n+\t$initial_reply_to = \"<$initial_reply_to>\" if $initial_reply_to ne '';\n }\n \n if (!defined $smtp_server) {\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex 08f7c3d..1422e9f 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -108,4 +108,25 @@ test_expect_success 'allow long lines with --no-validate' '\n \t\t2>errors\n '\n \n+test_expect_failure 'Invalid In-Reply-To' '\n+\tgit send-email \\\n+\t\t--from=\"Example \" \\\n+\t\t--to=nobody@example.com \\\n+\t\t--in-reply-to=\" \" \\\n+\t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n+\t\t$patches\n+\t\t2>errors\n+\t! grep \"^In-Reply-To: < *>\" msgtxt\n+'\n+\n+test_expect_success 'Valid In-Reply-To when prompting' '\n+\t(echo \"From Example \"\n+\t echo \"To Example \"\n+\t echo \"\"\n+\t) | env GIT_SEND_EMAIL_NOTTY=1 git send-email \\\n+\t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n+\t\t$patches 2>errors &&\n+\t! grep \"^In-Reply-To: < *>\" msgtxt\n+'\n+\n test_done\n-- \n1.5.4.2.236.g77b4.dirty\n"},{"id":"69544","messageId":"7vejb5rdpz.fsf@gitster.siamese.dyndns.org","threadId":"12238","inReplyTo":"1203639364-91817-1-git-send-email-jaysoffian@gmail.com","subject":"Re: [PATCH] send-email: fix In-Reply-To regression","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-22T01:18:00Z","receivedAt":"2008-02-22T01:18:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The patch looked Ok with my initial cursory review. Success\nreports with Tested-by: would be appreciated.\n"},{"id":"69659","messageId":"200802230123.52390.lenb@kernel.org","threadId":"12238","inReplyTo":"200802210721.29188.lenb@kernel.org","subject":"Re: git-send-email getting filtered as spam by vger.kernel.org","fromName":"Len Brown","fromEmail":"lenb@kernel.org","sentAt":"2008-02-23T06:23:52Z","receivedAt":"2008-02-23T06:23:52Z","isPatch":false,"sender":{"key":"lenb@kernel.org","avatar":null},"body":"On Thursday 21 February 2008 07:21, Len Brown wrote:\n> It looks like the same patches formatted and set with git 1.5.4.2\n> made it through to the list.\n> \n> -Len\n> \n> On Thursday 21 February 2008 04:29, Len Brown wrote:\n> > git-send-email is getting filtered by vger.kernel.org\n> > \n> > git --version\n> > git version 1.5.4.2.184.gb23b\n> > \n\nThe top of tree,\ngit version 1.5.4.2.197.g22c43\nis working.\n\nthanks for the quick response.\n-Len\n"},{"id":"70078","messageId":"20080227111336.GA25374@informatik.uni-freiburg.de","threadId":"12238","inReplyTo":"7vejb5rdpz.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] send-email: fix In-Reply-To regression","fromName":"Uwe Kleine-König","fromEmail":"ukleinek@informatik.uni-freiburg.de","sentAt":"2008-02-27T11:13:36Z","receivedAt":"2008-02-27T11:13:36Z","isPatch":true,"sender":{"key":"u.kleine-koenig@pengutronix.de","avatar":"https://gravatar.com/avatar/354b5e3ceb2806a2f1e1e382ac29ddbdad18288654da62b61eb13583a857eee7?d=mp&s=160"},"body":"Hello Junio,\n\nJunio C Hamano wrote:\n> The patch looked Ok with my initial cursory review. Success\n> reports with Tested-by: would be appreciated.\nI see you took the patch as \n\n\t0fb7fc7... send-email: fix In-Reply-To regression\n\n. Do you consider adding it to your maint branch?\n\nBest regards\nUwe\n\n-- \nUwe Kleine-König\n"},{"id":"70150","messageId":"7v3aretc2l.fsf@gitster.siamese.dyndns.org","threadId":"12238","inReplyTo":"20080227111336.GA25374@informatik.uni-freiburg.de","subject":"Re: [PATCH] send-email: fix In-Reply-To regression","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-27T19:48:50Z","receivedAt":"2008-02-27T19:48:50Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Uwe Kleine-König writes:\n\n> I see you took the patch as \n>\n> \t0fb7fc7... send-email: fix In-Reply-To regression\n>\n> . Do you consider adding it to your maint branch?\n\nThanks for a reminder. Done.\n"}]}