{"thread":{"id":"12200","subject":"[PATCH] git.el: Set process-environment instead of invoking env","startedAt":"2008-02-19T14:01:53Z","lastAt":"2008-02-20T11:21:28Z","messageCount":2,"participants":["David Kågedal","Alexandre Julliard"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"69267","messageId":"87r6f958k5.fsf@lysator.liu.se","threadId":"12200","inReplyTo":null,"subject":"[PATCH] git.el: Set process-environment instead of invoking env","fromName":"David Kågedal","fromEmail":"davidk@lysator.liu.se","sentAt":"2008-02-19T14:01:53Z","receivedAt":"2008-02-19T14:01:53Z","isPatch":true,"sender":{"key":"davidk@lysator.liu.se","avatar":"https://avatars.githubusercontent.com/u/60530?v=4"},"body":"This will make it a little less posix-dependent, and more efficient.\n\nIncluded is also a minor doc improvement.\n\nSigned-off-by: David Kågedal <davidk@lysator.liu.se>\n---\n contrib/emacs/git.el |    7 +++----\n 1 files changed, 3 insertions(+), 4 deletions(-)\n\ndiff --git a/contrib/emacs/git.el b/contrib/emacs/git.el\nindex a8bf0ef..f69b697 100644\n--- a/contrib/emacs/git.el\n+++ b/contrib/emacs/git.el\n@@ -185,9 +185,8 @@ if there is already one that displays the same directory.\"\n \n (defun git-call-process-env (buffer env &rest args)\n   \"Wrapper for call-process that sets environment strings.\"\n-  (if env\n-      (apply #'call-process \"env\" nil buffer nil\n-             (append (git-get-env-strings env) (list \"git\") args))\n+  (let ((process-environment (append (git-get-env-strings env)\n+                                     process-environment)))\n     (apply #'call-process \"git\" nil buffer nil args)))\n \n (defun git-call-process-display-error (&rest args)\n@@ -204,7 +203,7 @@ if there is already one that displays the same directory.\"\n \n (defun git-call-process-env-string (env &rest args)\n   \"Wrapper for call-process that sets environment strings,\n-and returns the process output as a string.\"\n+and returns the process output as a string, or nil if the git failed.\"\n   (with-temp-buffer\n     (and (eq 0 (apply #' git-call-process-env t env args))\n          (buffer-string))))\n-- \n1.5.4.2.148.g410dc\n\n\n-- \nDavid Kågedal\n"},{"id":"69366","messageId":"87y79fvpon.fsf@wine.dyndns.org","threadId":"12200","inReplyTo":"87r6f958k5.fsf@lysator.liu.se","subject":"Re: [PATCH] git.el: Set process-environment instead of invoking env","fromName":"Alexandre Julliard","fromEmail":"julliard@winehq.org","sentAt":"2008-02-20T11:21:28Z","receivedAt":"2008-02-20T11:21:28Z","isPatch":true,"sender":{"key":"julliard@winehq.org","avatar":null},"body":"David Kågedal <davidk@lysator.liu.se> writes:\n\n> This will make it a little less posix-dependent, and more efficient.\n>\n> Included is also a minor doc improvement.\n>\n> Signed-off-by: David Kågedal <davidk@lysator.liu.se>\n\nAcked-by: Alexandre Julliard <julliard@winehq.org>\n\n-- \nAlexandre Julliard\njulliard@winehq.org\n"}]}