{"thread":{"id":"12170","subject":"[PATCH] git-gui: relax \"dirty\" version detection","startedAt":"2008-02-18T08:36:33Z","lastAt":"2008-02-20T01:57:35Z","messageCount":2,"participants":["Wincent Colaiuta","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"69102","messageId":"1203323793-18020-1-git-send-email-win@wincent.com","threadId":"12170","inReplyTo":null,"subject":"[PATCH] git-gui: relax \"dirty\" version detection","fromName":"Wincent Colaiuta","fromEmail":"win@wincent.com","sentAt":"2008-02-18T08:36:33Z","receivedAt":"2008-02-18T08:36:33Z","isPatch":true,"sender":{"key":"greg@hurrell.net","avatar":"https://avatars.githubusercontent.com/u/7074?v=4"},"body":"\"git gui\" would complain at launch if the local version of Git was\n\"1.5.4.2.dirty\". Loosen the regular expression to look for either\n\"-dirty\" or \".dirty\", thus eliminating spurious warnings.\n\nSigned-off-by: Wincent Colaiuta <win@wincent.com>\n---\n git-gui/git-gui.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex 5d65272..238a239 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -663,7 +663,7 @@ if {![regsub {^git version } $_git_version {} _git_version]} {\n }\n \n set _real_git_version $_git_version\n-regsub -- {-dirty$} $_git_version {} _git_version\n+regsub -- {[\\-\\.]dirty$} $_git_version {} _git_version\n regsub {\\.[0-9]+\\.g[0-9a-f]+$} $_git_version {} _git_version\n regsub {\\.rc[0-9]+$} $_git_version {} _git_version\n regsub {\\.GIT$} $_git_version {} _git_version\n-- \n1.5.4.2.dirty\n"},{"id":"69355","messageId":"20080220015735.GW24004@spearce.org","threadId":"12170","inReplyTo":"1203323793-18020-1-git-send-email-win@wincent.com","subject":"Re: [PATCH] git-gui: relax \"dirty\" version detection","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-02-20T01:57:35Z","receivedAt":"2008-02-20T01:57:35Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Wincent Colaiuta <win@wincent.com> wrote:\n> \"git gui\" would complain at launch if the local version of Git was\n> \"1.5.4.2.dirty\". Loosen the regular expression to look for either\n> \"-dirty\" or \".dirty\", thus eliminating spurious warnings.\n> \n> Signed-off-by: Wincent Colaiuta <win@wincent.com>\n\nThanks.  Its now queued in my maint branch.\n\n-- \nShawn.\n"}]}