{"thread":{"id":"12164","subject":"segfault in http-push","startedAt":"2008-02-17T22:00:13Z","lastAt":"2008-02-18T03:06:39Z","messageCount":5,"participants":["Bob Copeland","Johannes Schindelin","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"69057","messageId":"20080217220013.GA12419@hash.localnet","threadId":"12164","inReplyTo":null,"subject":"segfault in http-push","fromName":"Bob Copeland","fromEmail":"me@bobcopeland.com","sentAt":"2008-02-17T22:00:13Z","receivedAt":"2008-02-17T22:00:13Z","isPatch":false,"sender":{"key":"me@bobcopeland.com","avatar":null},"body":"Hi,\n\nWith 1.4.5.2, I see this whenever I try to push a new branch over http:\n\n$ git-push hash long_ids\nFetching remote heads...\n refs/\n refs/heads/\n refs/tags/\n refs/remotes/\nupdating 'refs/heads/long_ids'\n from 0000000000000000000000000000000000000000\n to b24938890f04f3ba42b88f56f3ff2bbe0fda6629\n sending 10200 objects\n done\nUpdating remote server info\nerror: http-push died with strange error\nerror: failed to push to 'https://user@machine/foo.git/'\n\nHere's a backtrace:\n\n#0 0xb7cbd583 in strlen () from /lib/tls/i686/cmov/libc.so.6\n#1 0x08053b5a in start_put (request=0xdce9ad8) at http-push.c:520\n#2 0x080550d7 in fill_active_slot (unused=0x0) at http-push.c:810\n#3 0x0804da9d in fill_active_slots () at http.c:428\n#4 0x0804dc8b in step_active_slots () at http.c:454\n#5 0x0804dd0b in run_active_slot (slot=0x8e70148) at http.c:474\n#6 0x080502c9 in remote_ls (path=0x808bdbd \"refs/\", flags=5, \n userFunc=0x804f2b0 , userData=0xbfa04434)\n at http-push.c:1467\n#7 0x08050552 in update_remote_info_refs (lock=0x80e66c0) at http-push.c:1942\n#8 0x080534ee in main (argc=3, argv=Cannot access memory at address 0x4\n) at http-push.c:2421\n\nError is at:\n520 request->url = xmalloc(strlen(remote->url) +\n521 strlen(request->lock->token) + 51);\n\n(gdb) p request->lock\n$1 = (struct remote_lock *) 0x80e7d40\n(gdb) p request->lock->token\n$2 = 0x65707954
\n\nIf I go fix up the remote repository I can usually get it to work. \nAny thoughts?\n\n-- \nBob Copeland %% www.bobcopeland.com\n"},{"id":"69060","messageId":"alpine.LSU.1.00.0802172321551.30505@racer.site","threadId":"12164","inReplyTo":"20080217220013.GA12419@hash.localnet","subject":"Re: segfault in http-push","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-02-17T23:23:38Z","receivedAt":"2008-02-17T23:23:38Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sun, 17 Feb 2008, Bob Copeland wrote:\n\n> With 1.4.5.2, I see this whenever I try to push a new branch over http:\n\nI can only suspect that you mean 1.5.4.2, not 1.4.5.2 (which I could not \nfind).\n\nAlas, a fix I provided for exactly this case did not make it into master \nyet, let alone into any released version. Can you please test the current \n\"next\"?\n\nFWIW, the fix is add8e8ce(http-push: avoid invalid memory accesses).\n\nThanks,\nDscho\n"},{"id":"69074","messageId":"20080218020555.GA12814@hash.localnet","threadId":"12164","inReplyTo":"alpine.LSU.1.00.0802172321551.30505@racer.site","subject":"Re: segfault in http-push","fromName":"Bob Copeland","fromEmail":"me@bobcopeland.com","sentAt":"2008-02-18T02:05:55Z","receivedAt":"2008-02-18T02:05:55Z","isPatch":false,"sender":{"key":"me@bobcopeland.com","avatar":null},"body":"On Sun, Feb 17, 2008 at 11:23:38PM +0000, Johannes Schindelin wrote:\n> I can only suspect that you mean 1.5.4.2, not 1.4.5.2 (which I could not \n> find).\n\nJust so...\n\n> Alas, a fix I provided for exactly this case did not make it into master \n> yet, let alone into any released version. Can you please test the current \n> \"next\"?\n\nYep, next fixes it for me, thanks!\n\n-- \nBob Copeland %% www.bobcopeland.com \n"},{"id":"69075","messageId":"alpine.LSU.1.00.0802180207360.30505@racer.site","threadId":"12164","inReplyTo":"20080218020555.GA12814@hash.localnet","subject":"Re: segfault in http-push","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-02-18T02:08:09Z","receivedAt":"2008-02-18T02:08:09Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sun, 17 Feb 2008, Bob Copeland wrote:\n\n> On Sun, Feb 17, 2008 at 11:23:38PM +0000, Johannes Schindelin wrote:\n> \n> > Alas, a fix I provided for exactly this case did not make it into \n> > master yet, let alone into any released version. Can you please test \n> > the current \"next\"?\n> \n> Yep, next fixes it for me, thanks!\n\nThanks for testing!\n\nCiao,\nDscho \"who is pleased that we fix some bugs before they are reported\"\n"},{"id":"69078","messageId":"7v7ih3vu80.fsf@gitster.siamese.dyndns.org","threadId":"12164","inReplyTo":"alpine.LSU.1.00.0802180207360.30505@racer.site","subject":"Re: segfault in http-push","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-18T03:06:39Z","receivedAt":"2008-02-18T03:06:39Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi,\n>\n> On Sun, 17 Feb 2008, Bob Copeland wrote:\n>\n>> On Sun, Feb 17, 2008 at 11:23:38PM +0000, Johannes Schindelin wrote:\n>> \n>> > Alas, a fix I provided for exactly this case did not make it into \n>> > master yet, let alone into any released version. Can you please test \n>> > the current \"next\"?\n>> \n>> Yep, next fixes it for me, thanks!\n>\n> Thanks for testing!\n>\n> Ciao,\n> Dscho \"who is pleased that we fix some bugs before they are reported\"\n\nWonderful.\n\nI take this as a go ahead to merge js/maint-http-push topic to 'maint'\nbefore we cut 1.5.4.3.\n\nThanks both of you, especially Dscho.\n"}]}