{"thread":{"id":"12132","subject":"[PATCH 6/6] diff.c: add \"const\" qualifier to \"char *cmd\" member of \"struct ll_diff_driver\"","startedAt":"2008-02-16T05:02:17Z","lastAt":"2008-02-16T05:02:17Z","messageCount":1,"participants":["Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"68871","messageId":"20080216060217.c2ed3bb1.chriscool@tuxfamily.org","threadId":"12132","inReplyTo":null,"subject":"[PATCH 6/6] diff.c: add \"const\" qualifier to \"char *cmd\" member of \"struct ll_diff_driver\"","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-02-16T05:02:17Z","receivedAt":"2008-02-16T05:02:17Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Also use \"git_config_string\" to simplify code where \"cmd\" is set.\n\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n diff.c |    7 ++-----\n 1 files changed, 2 insertions(+), 5 deletions(-)\n\ndiff --git a/diff.c b/diff.c\nindex 5640cbf..173bb61 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -57,7 +57,7 @@ static int parse_diff_color_slot(const char *var, int ofs)\n static struct ll_diff_driver {\n \tconst char *name;\n \tstruct ll_diff_driver *next;\n-\tchar *cmd;\n+\tconst char *cmd;\n } *user_diff, **user_diff_tail;\n \n /*\n@@ -86,10 +86,7 @@ static int parse_lldiff_command(const char *var, const char *ep, const char *val\n \t\tuser_diff_tail = &(drv->next);\n \t}\n \n-\tif (!value)\n-\t\treturn config_error_nonbool(var);\n-\tdrv->cmd = xstrdup(value);\n-\treturn 0;\n+\treturn git_config_string(&(drv->cmd), var, value);\n }\n \n /*\n-- \n1.5.4.1.129.gf12af-dirty\n"}]}