{"thread":{"id":"12119","subject":"[PATCH] hg-to-git: fix parent analysis","startedAt":"2008-02-15T21:20:44Z","lastAt":"2008-02-19T10:12:44Z","messageCount":2,"participants":["Stelian Pop","Karl Hasselström"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"68840","messageId":"1203110444.5579.23.camel@galileo","threadId":"12119","inReplyTo":null,"subject":"[PATCH] hg-to-git: fix parent analysis","fromName":"Stelian Pop","fromEmail":"stelian@popies.net","sentAt":"2008-02-15T21:20:44Z","receivedAt":"2008-02-15T21:20:44Z","isPatch":true,"sender":{"key":"stelian@popies.net","avatar":"https://gravatar.com/avatar/c99e49c3b3d851deb85e4557b368712c890a09985211f183bd151f8ab6357c03?d=mp&s=160"},"body":"Fix a bug in the hg-to-git convertor introduced by commit\n1bc7c13af9f936aa80893100120b542338a10bf4: when searching the changeset\nparents, 'hg log' returns an extra space at the end of the line, which\nconfuses the .split(' ') based tokenizer:\n\n    Traceback (most recent call last):\n      File \"hg-to-git.py\", line 123, in <module>\n          hgchildren[mparent] += ( str(cset), )\n      KeyError: ''\n\nSigned-off-by: Stelian Pop <stelian@popies.net>\n\n---\n\ndiff --git a/contrib/hg-to-git/hg-to-git.py b/contrib/hg-to-git/hg-to-git.py\nindex c35b158..d72ffbb 100755\n--- a/contrib/hg-to-git/hg-to-git.py\n+++ b/contrib/hg-to-git/hg-to-git.py\n@@ -111,7 +111,7 @@ hgparents[\"0\"] = (None, None)\n hgbranch[\"0\"] = \"master\"\n for cset in range(1, int(tip) + 1):\n     hgchildren[str(cset)] = ()\n-    prnts = os.popen('hg log -r %d --template \"{parents}\"' % cset).read().split(' ')\n+    prnts = os.popen('hg log -r %d --template \"{parents}\"' % cset).read().strip().split(' ')\n     prnts = map(lambda x: x[:x.find(':')], prnts)\n     if prnts[0] != '':\n         parent = prnts[0].strip()\n\n-- \nStelian Pop <stelian@popies.net>\n"},{"id":"69248","messageId":"20080219101244.GA3825@diana.vm.bytemark.co.uk","threadId":"12119","inReplyTo":"1203110444.5579.23.camel@galileo","subject":"Re: [PATCH] hg-to-git: fix parent analysis","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2008-02-19T10:12:44Z","receivedAt":"2008-02-19T10:12:44Z","isPatch":true,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2008-02-15 22:20:44 +0100, Stelian Pop wrote:\n\n> -    prnts = os.popen('hg log -r %d --template \"{parents}\"' % cset).read().split(' ')\n> +    prnts = os.popen('hg log -r %d --template \"{parents}\"' % cset).read().strip().split(' ')\n\nIf it's not already too late, you could wrap this line when you're\nchanging it anyway. Something like this maybe:\n\n    prnts = os.popen('hg log -r %d --template \"{parents}\"' % cset\n                     ).read().strip().split(' ')\n\n-- \nKarl Hasselström, kha@treskal.com\n      www.treskal.com/kalle\n"}]}