{"thread":{"id":"12103","subject":"[PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11","startedAt":"2008-02-14T12:29:58Z","lastAt":"2008-03-13T19:19:46Z","messageCount":7,"participants":["Johannes Schindelin","Peter Karlsson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"68730","messageId":"alpine.LSU.1.00.0802141228300.30505@racer.site","threadId":"12103","inReplyTo":null,"subject":"[PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-02-14T12:29:58Z","receivedAt":"2008-02-14T12:29:58Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nWhen deciding if gitk or git-log should be used to visualize the current\nstate, the environment variable DISPLAY was checked.  Now, we check\nMSYSTEM (for MinGW32/MSys) and SECURITYSESSIONID (for MacOSX) in addition.\n\nNote that there is currently no way to ssh into MinGW32, and that\nSECURITYSESSIONID is not set automatically on MacOSX when ssh'ing into it.  \nSo this patch should be safe.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n\n\tTechnically, we do not even support MinGW32 yet in git.git,\n\tbut does it really hurt?  After all, you can call cygwin's git\n\tfrom MinGW32 as well...\n\n git-bisect.sh |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex 6594a62..74715ed 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -331,9 +331,9 @@ bisect_visualize() {\n \n \tif test $# = 0\n \tthen\n-\t\tcase \"${DISPLAY+set}\" in\n+\t\tcase \"${DISPLAY+set}${MSYSTEM+set}${SECURITYSESSIONID+set}\" in\n \t\t'')\tset git log ;;\n-\t\tset)\tset gitk ;;\n+\t\tset*)\tset gitk ;;\n \t\tesac\n \telse\n \t\tcase \"$1\" in\n-- \n1.5.4.1.1353.g0d5dd\n"},{"id":"68805","messageId":"Pine.LNX.4.64.0802151038520.18292@ds9.cixit.se","threadId":"12103","inReplyTo":"alpine.LSU.1.00.0802141228300.30505@racer.site","subject":"Re: [PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11","fromName":"Peter Karlsson","fromEmail":"peter@softwolves.pp.se","sentAt":"2008-02-15T09:40:27Z","receivedAt":"2008-02-15T09:40:27Z","isPatch":true,"sender":{"key":"peter@softwolves.pp.se","avatar":"https://avatars.githubusercontent.com/u/990764?v=4"},"body":"Johannes Schindelin:\n\n> When deciding if gitk or git-log should be used to visualize the current\n> state, the environment variable DISPLAY was checked.  Now, we check\n> MSYSTEM (for MinGW32/MSys) and SECURITYSESSIONID (for MacOSX) in addition.\n\nThat was quick! I haven't tried it, but I guess it should solve the\nproblem I was seeing.\n\n-- \n\\\\// Peter - http://www.softwolves.pp.se/\n"},{"id":"68809","messageId":"alpine.LSU.1.00.0802151050340.30505@racer.site","threadId":"12103","inReplyTo":"Pine.LNX.4.64.0802151038520.18292@ds9.cixit.se","subject":"Re: [PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-02-15T10:51:15Z","receivedAt":"2008-02-15T10:51:15Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 15 Feb 2008, Peter Karlsson wrote:\n\n> Johannes Schindelin:\n> \n> > When deciding if gitk or git-log should be used to visualize the \n> > current state, the environment variable DISPLAY was checked.  Now, we \n> > check MSYSTEM (for MinGW32/MSys) and SECURITYSESSIONID (for MacOSX) in \n> > addition.\n> \n> That was quick! I haven't tried it, but I guess it should solve the \n> problem I was seeing.\n\nCan you please test?  The we could at least add a \"Tested-by:\" to the \ncommit message.\n\nThanks,\nDscho\n"},{"id":"68811","messageId":"Pine.LNX.4.64.0802151346000.18292@ds9.cixit.se","threadId":"12103","inReplyTo":"alpine.LSU.1.00.0802151050340.30505@racer.site","subject":"Re: [PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11","fromName":"Peter Karlsson","fromEmail":"peter@softwolves.pp.se","sentAt":"2008-02-15T12:46:31Z","receivedAt":"2008-02-15T12:46:31Z","isPatch":true,"sender":{"key":"peter@softwolves.pp.se","avatar":"https://avatars.githubusercontent.com/u/990764?v=4"},"body":"Johannes Schindelin:\n\n> Can you please test?  The we could at least add a \"Tested-by:\" to the \n> commit message.\n\nWhen starting from the \"Git bash\" shell, it works.\n\nWhen starting from a Cygwin prompt, it does not work ($MSYSTEM is not\nset).\n\n-- \n\\\\// Peter - http://www.softwolves.pp.se/\n"},{"id":"68812","messageId":"alpine.LSU.1.00.0802151249290.30505@racer.site","threadId":"12103","inReplyTo":"Pine.LNX.4.64.0802151346000.18292@ds9.cixit.se","subject":"Re: [PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-02-15T12:50:50Z","receivedAt":"2008-02-15T12:50:50Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 15 Feb 2008, Peter Karlsson wrote:\n\n> Johannes Schindelin:\n> \n> > Can you please test?  The we could at least add a \"Tested-by:\" to the \n> > commit message.\n> \n> When starting from the \"Git bash\" shell, it works.\n\nGreat.\n\n> When starting from a Cygwin prompt, it does not work ($MSYSTEM is not \n> set).\n\nThat is expected.  You _can_ ssh into Cygwin, so we need a way to tell if \nthis is a desktop session or a terminal session.  If you have ideas how to \ntell that, please tell me.\n\nCiao,\nDscho\n"},{"id":"71605","messageId":"alpine.LSU.1.00.0803101919060.3975@racer.site","threadId":"12103","inReplyTo":"Pine.LNX.4.64.0802151346000.18292@ds9.cixit.se","subject":"Re: [PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-03-10T18:20:10Z","receivedAt":"2008-03-10T18:20:10Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 15 Feb 2008, Peter Karlsson wrote:\n\n> Johannes Schindelin:\n> \n> > Can you please test?  The we could at least add a \"Tested-by:\" to the \n> > commit message.\n> \n> When starting from the \"Git bash\" shell, it works.\n> \n> When starting from a Cygwin prompt, it does not work ($MSYSTEM is not \n> set).\n\nCan you please test this patch (both from interactive and ssh'ed \nsessions)?\n\n-- snipsnap --\n[PATCH] bisect view: call gitk if Cygwin's SESSIONNAME variable is set\n\nIt seems that Cygwin sets the variable SESSIONNAME when an interactive\nsession is running, and does not set it when you log in via ssh.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n git-bisect.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex 2c32d0b..af8f9e3 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -333,7 +333,7 @@ bisect_visualize() {\n \n \tif test $# = 0\n \tthen\n-\t\tcase \"${DISPLAY+set}${MSYSTEM+set}${SECURITYSESSIONID+set}\" in\n+\t\tcase \"${DISPLAY+set}${SESSIONNAME+set}${MSYSTEM+set}${SECURITYSESSIONID+set}\" in\n \t\t'')\tset git log ;;\n \t\tset*)\tset gitk ;;\n \t\tesac\n-- \n1.5.4.4.643.g7cb9b.dirty\n"},{"id":"71990","messageId":"alpine.DEB.1.00.0803132018410.23484@perkele.intern.softwolves.pp.se","threadId":"12103","inReplyTo":"alpine.LSU.1.00.0803101919060.3975@racer.site","subject":"Re: [PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11","fromName":"Peter Karlsson","fromEmail":"peter@softwolves.pp.se","sentAt":"2008-03-13T19:19:46Z","receivedAt":"2008-03-13T19:19:46Z","isPatch":true,"sender":{"key":"peter@softwolves.pp.se","avatar":"https://avatars.githubusercontent.com/u/990764?v=4"},"body":"Johannes Schindelin:\n\n> Can you please test this patch (both from interactive and ssh'ed\n> sessions)?\n\nIt does indeed seem to work. I get gitk when running from a local Cygwin \nshell and from a local cmd.exe shell, and git log when logging in over ssh.\n\nThank you.\n\n-- \n\\\\// Peter - http://www.softwolves.pp.se/\n"}]}