{"thread":{"id":"12065","subject":"[PATCH] Fix \"git submodule status\" output when \"git describe\" is not possible","startedAt":"2008-02-13T00:19:46Z","lastAt":"2008-02-24T20:49:39Z","messageCount":3,"participants":["Alberto Bertogli","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"68576","messageId":"1202861986-1159-1-git-send-email-albertito@gmail.com","threadId":"12065","inReplyTo":null,"subject":"[PATCH] Fix \"git submodule status\" output when \"git describe\" is not possible","fromName":"Alberto Bertogli","fromEmail":"albertito@gmail.com","sentAt":"2008-02-13T00:19:46Z","receivedAt":"2008-02-13T00:19:46Z","isPatch":true,"sender":{"key":"albertito@gmail.com","avatar":null},"body":"When a submodule cannot be described, doing a \"git submodule status\" on\nthe supermodule produces unnecesary and scary output, for example:\n\n    fatal: cannot describe 'cac575f1bccf0c6942d11962cf4d44ba974d3e8e'\n     cac575f1bccf0c6942d11962cf4d44ba974d3e8e megaco/megaco_tipc\n\nWhere it should just show:\n\n     cac575f1bccf0c6942d11962cf4d44ba974d3e8e megaco/megaco_tipc\n\nThe culprit (after manual inspection of git log) seems to be commit\na2cf9f4.\n\nThis patch fixes this by making git submodule aware of that behaviour\nchange.\n\nSigned-off-by: Alberto Bertogli <albertito@gmail.com>\n---\n git-submodule.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-submodule.sh b/git-submodule.sh\nindex a6aaf40..5e8b84f 100755\n--- a/git-submodule.sh\n+++ b/git-submodule.sh\n@@ -315,7 +315,7 @@ set_name_rev () {\n \t\tcd \"$1\" && {\n \t\t\tgit describe \"$2\" 2>/dev/null ||\n \t\t\tgit describe --tags \"$2\" 2>/dev/null ||\n-\t\t\tgit describe --contains --tags \"$2\"\n+\t\t\tgit describe --contains --tags \"$2\" 2>/dev/null\n \t\t}\n \t) )\n \ttest -z \"$revname\" || revname=\" ($revname)\"\n-- \n1.5.4.1.1279.g0d205f-dirty\n"},{"id":"68583","messageId":"7vprv1zn27.fsf@gitster.siamese.dyndns.org","threadId":"12065","inReplyTo":"1202861986-1159-1-git-send-email-albertito@gmail.com","subject":"Re: [PATCH] Fix \"git submodule status\" output when \"git describe\" is not possible","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-13T01:01:52Z","receivedAt":"2008-02-13T01:01:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alberto Bertogli <albertito@gmail.com> writes:\n\n> When a submodule cannot be described, doing a \"git submodule status\" on\n> the supermodule produces unnecesary and scary output,...\n\nI had an impression that describe got a new feature for a case\nlike this recently.\n"},{"id":"69816","messageId":"20080224204939.GE10119@gmail.com","threadId":"12065","inReplyTo":"7vprv1zn27.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Fix \"git submodule status\" output when \"git describe\" is not possible","fromName":"Alberto Bertogli","fromEmail":"albertito@gmail.com","sentAt":"2008-02-24T20:49:39Z","receivedAt":"2008-02-24T20:49:39Z","isPatch":true,"sender":{"key":"albertito@gmail.com","avatar":null},"body":"On Tue, Feb 12, 2008 at 05:01:52PM -0800, Junio C Hamano wrote:\n> Alberto Bertogli <albertito@gmail.com> writes:\n> \n> > When a submodule cannot be described, doing a \"git submodule status\" on\n> > the supermodule produces unnecesary and scary output,...\n> \n> I had an impression that describe got a new feature for a case\n> like this recently.\n\nI'm sorry but I've read the docs and tried with a few options and I have\nno idea what that one may be.\n\nThe bug is still present on 'next' as of an hour ago.\n\nThanks,\n\t\tAlberto\n"}]}