{"thread":{"id":"12061","subject":"[BUG] git bisect should not expand file globs in log","startedAt":"2008-02-12T19:23:28Z","lastAt":"2008-02-12T21:10:50Z","messageCount":4,"participants":["Frans Pop","Johannes Schindelin","Alex Riesen"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"68541","messageId":"200802122023.28879.elendil@planet.nl","threadId":"12061","inReplyTo":null,"subject":"[BUG] git bisect should not expand file globs in log","fromName":"Frans Pop","fromEmail":"elendil@planet.nl","sentAt":"2008-02-12T19:23:28Z","receivedAt":"2008-02-12T19:23:28Z","isPatch":false,"sender":{"key":"elendil@planet.nl","avatar":null},"body":"Hi,\n\nDuring a git bisect session I ended up with the following in the\n.git/BISECT_LOG:\n\n# bad: [38a382ae5dd4f4d04e3046816b0a41836094e538] Kobject: convert \narch/alpha arch/arm arch/avr32 arch/blackfin arch/cris arch/frv arch/h8300 \narch/ia64 arch/m32r arch/m68k arch/m68knommu arch/mips arch/parisc \narch/powerpc arch/ppc arch/s390 arch/sh arch/sh64 arch/sparc arch/sparc64 \narch/um arch/v850 arch/x86 arch/x86_64 arch/xtensa from \nkobject_unregister() to kobject_put()\ngit-bisect bad 38a382ae5dd4f4d04e3046816b0a41836094e538\n\n>From the following command you can see shat happened: the 'arch/*' from the \ncommit log was expanded in the comment line in the bisect log file.\n\n$ git bisect bad\n38a382ae5dd4f4d04e3046816b0a41836094e538 is first bad commit\ncommit 38a382ae5dd4f4d04e3046816b0a41836094e538\nAuthor: Greg Kroah-Hartman \nDate: Thu Dec 20 08:13:05 2007 -0800\n\n Kobject: convert arch/* from kobject_unregister() to kobject_put()\n\ngit version: 1.5.4 (current Debian unstable)\n\nCheers,\nFJP\n"},{"id":"68542","messageId":"alpine.LSU.1.00.0802121950210.3870@racer.site","threadId":"12061","inReplyTo":"200802122023.28879.elendil@planet.nl","subject":"Re: [BUG] git bisect should not expand file globs in log","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-02-12T19:50:57Z","receivedAt":"2008-02-12T19:50:57Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\ndoes this help? (It is a really trivial patch...)\n\n-- snipsnap --\n[PATCH] bisect: use verbatim commit subject in the bisect log\n\nDue to a typo, the commit subject was shell expanded in the bisect log.\nThat is, if you had some shell pattern in the commit subject, bisect\nwould happily put all matching file names into the log.\n\nNoticed by Frans Pop.\n\nSigned-off-by: Johannes Schindelin \n---\n git-bisect.sh | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex 5385249..0bb51d7 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -131,7 +131,7 @@ bisect_write() {\n \t\t*)\t\tdie \"Bad bisect_write argument: $state\" ;;\n \tesac\n \tgit update-ref \"refs/bisect/$tag\" \"$rev\"\n-\techo \"# $state: \"$(git show-branch $rev) >>\"$GIT_DIR/BISECT_LOG\"\n+\techo \"# $state: $(git show-branch $rev)\" >>\"$GIT_DIR/BISECT_LOG\"\n \ttest -z \"$nolog\" && echo \"git-bisect $state $rev\" >>\"$GIT_DIR/BISECT_LOG\"\n }\n \n-- \n1.5.4.18.gb6d712\n"},{"id":"68543","messageId":"20080212200650.GA15258@steel.home","threadId":"12061","inReplyTo":"200802122023.28879.elendil@planet.nl","subject":"[PATCH] Fix shell quoting in git-bisect","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-02-12T20:06:50Z","receivedAt":"2008-02-12T20:06:50Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Signed-off-by: Alex Riesen \n---\nFrans Pop, Tue, Feb 12, 2008 20:23:28 +0100:\n> During a git bisect session I ended up with the following in the\n> .git/BISECT_LOG:\n> \n> # bad: [38a382ae5dd4f4d04e3046816b0a41836094e538] Kobject: convert \n> arch/alpha arch/arm arch/avr32 arch/blackfin arch/cris arch/frv arch/h8300 \n> ...\n> \n> From the following command you can see shat happened: the 'arch/*' from the \n> commit log was expanded in the comment line in the bisect log file.\n\nThis should fix it\n\n git-bisect.sh | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex 5385249..0bb51d7 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -131,7 +131,7 @@ bisect_write() {\n \t\t*)\t\tdie \"Bad bisect_write argument: $state\" ;;\n \tesac\n \tgit update-ref \"refs/bisect/$tag\" \"$rev\"\n-\techo \"# $state: \"$(git show-branch $rev) >>\"$GIT_DIR/BISECT_LOG\"\n+\techo \"# $state: $(git show-branch $rev)\" >>\"$GIT_DIR/BISECT_LOG\"\n \ttest -z \"$nolog\" && echo \"git-bisect $state $rev\" >>\"$GIT_DIR/BISECT_LOG\"\n }\n \n-- \n1.5.4.1.112.g94408\n"},{"id":"68549","messageId":"200802122210.50990.elendil@planet.nl","threadId":"12061","inReplyTo":"alpine.LSU.1.00.0802121950210.3870@racer.site","subject":"Re: [BUG] git bisect should not expand file globs in log","fromName":"Frans Pop","fromEmail":"elendil@planet.nl","sentAt":"2008-02-12T21:10:50Z","receivedAt":"2008-02-12T21:10:50Z","isPatch":false,"sender":{"key":"elendil@planet.nl","avatar":null},"body":"On Tuesday 12 February 2008, you wrote:\n> does this help? (It is a really trivial patch...)\n\nYes, it does. Thanks.\n\nYou beat Alex by about 15 minutes. If I'd known this was just shell script, \nI could've done the patch myself :-P\n\n> [PATCH] bisect: use verbatim commit subject in the bisect log\n>\n> Due to a typo, the commit subject was shell expanded in the bisect log.\n> That is, if you had some shell pattern in the commit subject, bisect\n> would happily put all matching file names into the log.\n>\n> Noticed by Frans Pop.\n>\n> Signed-off-by: Johannes Schindelin \nTested-by: Frans Pop \n"}]}