{"thread":{"id":"12027","subject":"[DOC BUG] git tag uses GIT_COMMITTER_DATE, not GIT_AUTHOR_DATE","startedAt":"2008-02-11T08:38:23Z","lastAt":"2008-02-11T09:09:27Z","messageCount":2,"participants":["Kalle Olavi Niemitalo","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"68340","messageId":"87ir0vc2gw.fsf@Astalo.kon.iki.fi","threadId":"12027","inReplyTo":null,"subject":"[DOC BUG] git tag uses GIT_COMMITTER_DATE, not GIT_AUTHOR_DATE","fromName":"Kalle Olavi Niemitalo","fromEmail":"kon@iki.fi","sentAt":"2008-02-11T08:38:23Z","receivedAt":"2008-02-11T08:38:23Z","isPatch":false,"sender":{"key":"kon@iki.fi","avatar":null},"body":"In Git v1.5.4.1, Documentation/git-tag.txt advises:\n\n> To set the date used in future tag objects, set the environment\n> variable GIT_AUTHOR_DATE to one or more of the date and time.  The\n> date and time can be specified in a number of ways; the most common\n> is \"YYYY-MM-DD HH:MM\".\n\nBut this does not work because git tag uses GIT_COMMITTER_DATE instead.\nIn builtin-tag.c:\n\n> \theader_len = snprintf(header_buf, sizeof(header_buf),\n> \t\t\t  \"object %s\\n\"\n> \t\t\t  \"type %s\\n\"\n> \t\t\t  \"tag %s\\n\"\n> \t\t\t  \"tagger %s\\n\\n\",\n> \t\t\t  sha1_to_hex(object),\n> \t\t\t  typename(type),\n> \t\t\t  tag,\n> \t\t\t  git_committer_info(IDENT_ERROR_ON_NO_NAME));\n\ni.e. it does not call git_author_info.\n\nThe backdating section was added to git-tag.txt in 5040beff,\nand builtin-tag.c already used git_committer_info at that time.\nThe older git-tag.sh used tagger=$(git-var GIT_COMMITTER_IDENT).\nThus it seems the bug is in the documentation, not in the code.\n"},{"id":"68345","messageId":"7vir0vamgo.fsf@gitster.siamese.dyndns.org","threadId":"12027","inReplyTo":"87ir0vc2gw.fsf@Astalo.kon.iki.fi","subject":"Re: [DOC BUG] git tag uses GIT_COMMITTER_DATE, not GIT_AUTHOR_DATE","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-11T09:09:27Z","receivedAt":"2008-02-11T09:09:27Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kalle Olavi Niemitalo <kon@iki.fi> writes:\n\n> In Git v1.5.4.1, Documentation/git-tag.txt advises:\n>\n>> To set the date used in future tag objects, set the environment\n>> variable GIT_AUTHOR_DATE to one or more of the date and time.  The\n>> date and time can be specified in a number of ways; the most common\n>> is \"YYYY-MM-DD HH:MM\".\n>\n> But this does not work because git tag uses GIT_COMMITTER_DATE instead.\n> In builtin-tag.c:\n>\n>> \theader_len = snprintf(header_buf, sizeof(header_buf),\n>> \t\t\t  \"object %s\\n\"\n>> \t\t\t  \"type %s\\n\"\n>> \t\t\t  \"tag %s\\n\"\n>> \t\t\t  \"tagger %s\\n\\n\",\n>> \t\t\t  sha1_to_hex(object),\n>> \t\t\t  typename(type),\n>> \t\t\t  tag,\n>> \t\t\t  git_committer_info(IDENT_ERROR_ON_NO_NAME));\n>\n> i.e. it does not call git_author_info.\n>\n> The backdating section was added to git-tag.txt in 5040beff,\n> and builtin-tag.c already used git_committer_info at that time.\n> The older git-tag.sh used tagger=$(git-var GIT_COMMITTER_IDENT).\n> Thus it seems the bug is in the documentation, not in the code.\n\nCorrect.  We've always used committer ident as far as I can\nremember.\n"}]}