{"thread":{"id":"11980","subject":"[PATCH] http.c: guard config parser from value=NULL","startedAt":"2008-02-09T00:39:04Z","lastAt":"2008-02-09T21:09:34Z","messageCount":3,"participants":["Govind Salinas","Christian Couder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"68035","messageId":"5d46db230802081639n78aab3b2s1e83ab9c4afc6a38@mail.gmail.com","threadId":"11980","inReplyTo":null,"subject":"[PATCH] http.c: guard config parser from value=NULL","fromName":"Govind Salinas","fromEmail":"blix@sophiasuchtig.com","sentAt":"2008-02-09T00:39:04Z","receivedAt":"2008-02-09T00:39:04Z","isPatch":true,"sender":{"key":"blix@sophiasuchtig.com","avatar":null},"body":"Signed-off-by: Govind Salinas <blix@sophiasuchtig.com>\n---\n http.c |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/http.c b/http.c\nindex d2c11ae..0a2c1c8 100644\n--- a/http.c\n+++ b/http.c\n@@ -92,6 +92,9 @@ static void process_curl_messages(void)\n\n static int http_options(const char *var, const char *value)\n {\n+\tif (!value)\n+\t\treturn git_default_config(var, value);\n+\n \tif (!strcmp(\"http.sslverify\", var)) {\n \t\tif (curl_ssl_verify == -1) {\n \t\t\tcurl_ssl_verify = git_config_bool(var, value);\n-- \n1.5.4.36.g9af61\n"},{"id":"68105","messageId":"200802091846.26708.chriscool@tuxfamily.org","threadId":"11980","inReplyTo":"5d46db230802081639n78aab3b2s1e83ab9c4afc6a38@mail.gmail.com","subject":"Re: [PATCH] http.c: guard config parser from value=NULL","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-02-09T17:46:26Z","receivedAt":"2008-02-09T17:46:26Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Le samedi 9 février 2008, Govind Salinas a écrit :\n> Signed-off-by: Govind Salinas <blix@sophiasuchtig.com>\n> ---\n>  http.c |    3 +++\n>  1 files changed, 3 insertions(+), 0 deletions(-)\n>\n> diff --git a/http.c b/http.c\n> index d2c11ae..0a2c1c8 100644\n> --- a/http.c\n> +++ b/http.c\n> @@ -92,6 +92,9 @@ static void process_curl_messages(void)\n>\n>  static int http_options(const char *var, const char *value)\n>  {\n> +\tif (!value)\n> +\t\treturn git_default_config(var, value);\n> +\n>  \tif (!strcmp(\"http.sslverify\", var)) {\n>  \t\tif (curl_ssl_verify == -1) {\n>  \t\t\tcurl_ssl_verify = git_config_bool(var, value);\n\nAfter a very quick look at this, it seems that no change is needed here \nbecause 'git_config_bool' handles a NULL value correctly. Some changes may \nbe needed below though.\n\nThanks,\nChristian.\n"},{"id":"68124","messageId":"7vabm9et0x.fsf@gitster.siamese.dyndns.org","threadId":"11980","inReplyTo":"5d46db230802081639n78aab3b2s1e83ab9c4afc6a38@mail.gmail.com","subject":"Re: [PATCH] http.c: guard config parser from value=NULL","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-09T21:09:34Z","receivedAt":"2008-02-09T21:09:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Govind Salinas\" <blix@sophiasuchtig.com> writes:\n\n> Signed-off-by: Govind Salinas <blix@sophiasuchtig.com>\n> ---\n>  http.c |    3 +++\n>  1 files changed, 3 insertions(+), 0 deletions(-)\n>\n> diff --git a/http.c b/http.c\n> index d2c11ae..0a2c1c8 100644\n> --- a/http.c\n> +++ b/http.c\n> @@ -92,6 +92,9 @@ static void process_curl_messages(void)\n>\n>  static int http_options(const char *var, const char *value)\n>  {\n> +\tif (!value)\n> +\t\treturn git_default_config(var, value);\n> +\n>  \tif (!strcmp(\"http.sslverify\", var)) {\n>  \t\tif (curl_ssl_verify == -1) {\n>  \t\t\tcurl_ssl_verify = git_config_bool(var, value);\n\nI think this patch is wrong.\n\nYou just broke existing repositories with:\n\n\t[http]\n        \tsslverify\n\nto set it to true.\n"}]}