{"thread":{"id":"1197","subject":"Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 appears to have broken cg-init","startedAt":"2005-07-11T01:58:20Z","lastAt":"2005-07-11T04:01:55Z","messageCount":2,"participants":["Joel Becker","Bryan Larsen"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"5925","messageId":"20050711015820.GA16618@ca-server1.us.oracle.com","threadId":"1197","inReplyTo":null,"subject":"Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 appears to have broken cg-init","fromName":"Joel Becker","fromEmail":"joel.becker@oracle.com","sentAt":"2005-07-11T01:58:20Z","receivedAt":"2005-07-11T01:58:20Z","isPatch":false,"sender":{"key":"joel.becker@oracle.com","avatar":null},"body":"Petr,\n\tCommit 7c5977297f07c2a52c8c0f486309076b2a795d33 contains the\nchunk:\n\n-uri=$1\n+\n+infoonly=\n+while optparse; do\n+\tif optparse -N; then\n+\t\tinfoonly=-N\n+\telse\n+\t\toptfail\n+\tfi\n+done\n+\n+uri=$ARGV\n\n\tHowever, $ARGV is not a variable I've ever seen supported in a\nBourne-like shell.  Certainly Bash supports BASH_ARGV, but not ARGV.\n\tThe recent option parsing code adds ARGS in cg-Xlib, but not\nARGV.\n\tThe upshot is that a cg-clone/cg-init attempt thinks $uri is\nempty, and always creates an initial commit.  No clone.  I don't know\nhow folks have gotten cg-clone rsync://linus to work since this change\nwent in.\n\tI don't know what the proper solution is with the modern option\ncode, but changing it back to 'url=$1' allows me to grab Linus' tree.\n\nJoel\n-- \n\nLife's Little Instruction Book #3\n\n\t\"Watch a sunrise at least once a year.\"\n\nJoel Becker\nSenior Member of Technical Staff\nOracle\nE-mail: joel.becker@oracle.com\nPhone: (650) 506-8127\n"},{"id":"5934","messageId":"42D1EF33.2070000@gmail.com","threadId":"1197","inReplyTo":"20050711015820.GA16618@ca-server1.us.oracle.com","subject":"Re: Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 appears to have broken cg-init","fromName":"Bryan Larsen","fromEmail":"bryan.larsen@gmail.com","sentAt":"2005-07-11T04:01:55Z","receivedAt":"2005-07-11T04:01:55Z","isPatch":false,"sender":{"key":"bryan@larsen.st","avatar":"https://avatars.githubusercontent.com/u/32073?v=4"},"body":"Yes, I meant to use $ARGS.  I included the fix in the patchset I just sent.\n\nSorry,\nBryan\n\n\nJoel Becker wrote:\n> Petr,\n> \tCommit 7c5977297f07c2a52c8c0f486309076b2a795d33 contains the\n> chunk:\n> \n> -uri=$1\n> +\n> +infoonly=\n> +while optparse; do\n> +\tif optparse -N; then\n> +\t\tinfoonly=-N\n> +\telse\n> +\t\toptfail\n> +\tfi\n> +done\n> +\n> +uri=$ARGV\n> \n> \tHowever, $ARGV is not a variable I've ever seen supported in a\n> Bourne-like shell.  Certainly Bash supports BASH_ARGV, but not ARGV.\n> \tThe recent option parsing code adds ARGS in cg-Xlib, but not\n> ARGV.\n> \tThe upshot is that a cg-clone/cg-init attempt thinks $uri is\n> empty, and always creates an initial commit.  No clone.  I don't know\n> how folks have gotten cg-clone rsync://linus to work since this change\n> went in.\n> \tI don't know what the proper solution is with the modern option\n> code, but changing it back to 'url=$1' allows me to grab Linus' tree.\n> \n> Joel\n"}]}