{"thread":{"id":"11956","subject":"Using thunderbird to post/apply patches?","startedAt":"2008-02-07T23:21:24Z","lastAt":"2008-02-08T11:38:20Z","messageCount":9,"participants":["Martin Langhoff","Johannes Schindelin","Brandon Casey","Jay Soffian","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"67873","messageId":"46a038f90802071521n674b61c2t5e4d4c740375b951@mail.gmail.com","threadId":"11956","inReplyTo":null,"subject":"Using thunderbird to post/apply patches?","fromName":"Martin Langhoff","fromEmail":"martin.langhoff@gmail.com","sentAt":"2008-02-07T23:21:24Z","receivedAt":"2008-02-07T23:21:24Z","isPatch":false,"sender":{"key":"martin.langhoff@gmail.com","avatar":"https://gravatar.com/avatar/1e3f311b6c4c15836501901ca58f8c0b0667246488084ba524d8bc9867e22fd9?d=mp&s=160"},"body":"Is there anyone using thunderbird/mozilla to post patches with\nadditional email commentary like Junio and Linus do? Are there good\ntricks for this? Or otherwise a similar MUA that does things right?\n\nThe 2 workflows I am after are...\n\n - Load up a patch created with git-format-patch into my email editor\nto add some commentary before sending. Should not munge the patch\nitself!\n\n - Feed an email I am reading to git-apply-mbox so that if it's\nreasonably formatted as a patch it will do the right thing and apply\nit.\n\ncheers,\n\n\n\nm\n"},{"id":"67876","messageId":"alpine.LSU.1.00.0802072333120.11591@racer.site","threadId":"11956","inReplyTo":"46a038f90802071521n674b61c2t5e4d4c740375b951@mail.gmail.com","subject":"Re: Using thunderbird to post/apply patches?","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-02-07T23:34:06Z","receivedAt":"2008-02-07T23:34:06Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 8 Feb 2008, Martin Langhoff wrote:\n\n> Is there anyone using thunderbird/mozilla to post patches with \n> additional email commentary like Junio and Linus do? Are there good \n> tricks for this? Or otherwise a similar MUA that does things right?\n> \n> The 2 workflows I am after are...\n> \n> - Load up a patch created with git-format-patch into my email editor\n> to add some commentary before sending. Should not munge the patch\n> itself!\n\nThe \"Thunderbird\" section in Documentation/SubmittingPatches should help \nhere.\n\n> - Feed an email I am reading to git-apply-mbox so that if it's\n> reasonably formatted as a patch it will do the right thing and apply\n> it.\n\nRecently, git-am learnt to apply mails in maildir format. Thunderbird \nuses maildir format internally, if I am not mistaken.\n\nHth,\nDscho\n"},{"id":"67877","messageId":"46a038f90802071542j765a8501kc57b065f22c734b2@mail.gmail.com","threadId":"11956","inReplyTo":"alpine.LSU.1.00.0802072333120.11591@racer.site","subject":"Re: Using thunderbird to post/apply patches?","fromName":"Martin Langhoff","fromEmail":"martin.langhoff@gmail.com","sentAt":"2008-02-07T23:42:09Z","receivedAt":"2008-02-07T23:42:09Z","isPatch":false,"sender":{"key":"martin.langhoff@gmail.com","avatar":"https://gravatar.com/avatar/1e3f311b6c4c15836501901ca58f8c0b0667246488084ba524d8bc9867e22fd9?d=mp&s=160"},"body":"On Feb 8, 2008 12:34 PM, Johannes Schindelin wrote:\n> The \"Thunderbird\" section in Documentation/SubmittingPatches should help\n> here.\n\nIf that's state-of-the-art then thunderbird hasn't gotten any better\nsince I last tried. Shame.\n\n> > - Feed an email I am reading to git-apply-mbox so that if it's\n> > reasonably formatted as a patch it will do the right thing and apply\n> > it.\n>\n> Recently, git-am learnt to apply mails in maildir format. Thunderbird\n> uses maildir format internally, if I am not mistaken.\n\nIt uses mbox - but the delimiter is somewhat broken, so sometimes\ngit-am fails to split the emails correctly.\n\nA pretty sad story overall. Grumble...\n\n\nm\n"},{"id":"67878","messageId":"47AB97EC.8030002@nrlssc.navy.mil","threadId":"11956","inReplyTo":"46a038f90802071521n674b61c2t5e4d4c740375b951@mail.gmail.com","subject":"Re: Using thunderbird to post/apply patches?","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2008-02-07T23:44:44Z","receivedAt":"2008-02-07T23:44:44Z","isPatch":false,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Martin Langhoff wrote:\n> Is there anyone using thunderbird/mozilla to post patches with\n> additional email commentary like Junio and Linus do? Are there good\n> tricks for this? Or otherwise a similar MUA that does things right?\n> \n> The 2 workflows I am after are...\n> \n> - Load up a patch created with git-format-patch into my email editor\n> to add some commentary before sending. Should not munge the patch\n> itself!\n\nI use git-send-email to first send the patch to myself.\nWhen it shows up in thunderbird, I Right-click and select \"Edit As New...\"\nAdd my text, update the recipients, and voila.\n\nIf you're replying to a previous message, you can get the Message-ID to\nsupply to git-send-email by selecting View->Headers->All. Copy&Paste\neverything between the angle brackets.\n\nI have these options set in Edit->Preferences:\n Display->Formatting->Display emoticons as graphics: unchecked, it turns\n HEAD^2 into HEAD squared\n Composition->General->Wrap plain text messages at 0 characters\n ^\n\nI also have mailnews.send_plaintext_flowed => false as suggested in\nSubmittingPatches. There is a different suggestion in that document\nyou may want to read.\n\n> - Feed an email I am reading to git-apply-mbox so that if it's\n> reasonably formatted as a patch it will do the right thing and apply\n> it.\n\nI just Right-click and Save As...\n\ncat | git am\n\n-brandon\n"},{"id":"67879","messageId":"alpine.LSU.1.00.0802080011420.11591@racer.site","threadId":"11956","inReplyTo":"46a038f90802071542j765a8501kc57b065f22c734b2@mail.gmail.com","subject":"Re: Using thunderbird to post/apply patches?","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-02-08T00:12:26Z","receivedAt":"2008-02-08T00:12:26Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 8 Feb 2008, Martin Langhoff wrote:\n\n> On Feb 8, 2008 12:34 PM, Johannes Schindelin \n> wrote:\n>\n> > Martin wrote:\n> >\n> > > - Feed an email I am reading to git-apply-mbox so that if it's \n> > > reasonably formatted as a patch it will do the right thing and apply \n> > > it.\n> >\n> > Recently, git-am learnt to apply mails in maildir format. \n> > Thunderbird uses maildir format internally, if I am not mistaken.\n> \n> It uses mbox - but the delimiter is somewhat broken, so sometimes git-am \n> fails to split the emails correctly.\n> \n> A pretty sad story overall. Grumble...\n\nDo you have an example of a non-working mbox for git-am?\n\nThanks,\nDscho\n"},{"id":"67888","messageId":"76718490802072010x63e2082akf1aa92b12cd24030@mail.gmail.com","threadId":"11956","inReplyTo":"47AB97EC.8030002@nrlssc.navy.mil","subject":"Re: Using thunderbird to post/apply patches?","fromName":"Jay Soffian","fromEmail":"jaysoffian+git@gmail.com","sentAt":"2008-02-08T04:10:13Z","receivedAt":"2008-02-08T04:10:13Z","isPatch":false,"sender":{"key":"jaysoffian@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155970?v=4"},"body":"On Feb 7, 2008 6:44 PM, Brandon Casey wrote:\n\n> I also have mailnews.send_plaintext_flowed => false as suggested in\n> SubmittingPatches.\n\nWould teaching git-mailsplit to handle format=flowed be considered a\nuseful contribution?\n\n(W/o sounding like a total script weenie, I'm actually wondering if\nconverting git-am, git-mailsplit, and git-mailinfo to Perl code\nwouldn't be a bad idea... groking email is a lot more pleasant in Perl\nthan shell and/or C.)\n\nj.\n"},{"id":"67890","messageId":"46a038f90802072027h759114b1l3a2b861505eded2c@mail.gmail.com","threadId":"11956","inReplyTo":"alpine.LSU.1.00.0802080011420.11591@racer.site","subject":"Re: Using thunderbird to post/apply patches?","fromName":"Martin Langhoff","fromEmail":"martin.langhoff@gmail.com","sentAt":"2008-02-08T04:27:20Z","receivedAt":"2008-02-08T04:27:20Z","isPatch":false,"sender":{"key":"martin.langhoff@gmail.com","avatar":"https://gravatar.com/avatar/1e3f311b6c4c15836501901ca58f8c0b0667246488084ba524d8bc9867e22fd9?d=mp&s=160"},"body":"On Feb 8, 2008 1:12 PM, Johannes Schindelin wrote:\n> Do you have an example of a non-working mbox for git-am?\n\ngood news - tested the mbox files I have (which used to get git-am to\nbarf back in the v0.99 days), and they work well. So things have\ngotten much better on that front... probably git mailsplit got\nsmarter. I doubt thunderbird has changed one bit :-)\n\ncheers!\n\n\nm\n"},{"id":"67905","messageId":"7vejbnlxhz.fsf@gitster.siamese.dyndns.org","threadId":"11956","inReplyTo":"76718490802072010x63e2082akf1aa92b12cd24030@mail.gmail.com","subject":"Re: Using thunderbird to post/apply patches?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-08T07:26:32Z","receivedAt":"2008-02-08T07:26:32Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Jay Soffian\" writes:\n\n> On Feb 7, 2008 6:44 PM, Brandon Casey wrote:\n>\n>> I also have mailnews.send_plaintext_flowed => false as suggested in\n>> SubmittingPatches.\n>\n> Would teaching git-mailsplit to handle format=flowed be considered a\n> useful contribution?\n\nIn the way the e-mail processing toolchain is structured, I\nthink git-mailinfo is the logical place to do that, not\ngit-mailsplit. It already knows how to unwrap single level of\nMIME multi-part and also CTE.\n"},{"id":"67933","messageId":"alpine.LSU.1.00.0802081135080.11591@racer.site","threadId":"11956","inReplyTo":"76718490802072010x63e2082akf1aa92b12cd24030@mail.gmail.com","subject":"Re: Using thunderbird to post/apply patches?","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-02-08T11:38:20Z","receivedAt":"2008-02-08T11:38:20Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 7 Feb 2008, Jay Soffian wrote:\n\n> On Feb 7, 2008 6:44 PM, Brandon Casey wrote:\n> \n> > I also have mailnews.send_plaintext_flowed => false as suggested in \n> > SubmittingPatches.\n> \n> Would teaching git-mailsplit to handle format=flowed be considered a \n> useful contribution?\n> \n> (W/o sounding like a total script weenie, I'm actually wondering if \n> converting git-am, git-mailsplit, and git-mailinfo to Perl code wouldn't \n> be a bad idea... groking email is a lot more pleasant in Perl than shell \n> and/or C.)\n\nFWIW I think you have it backwards. It might look nicer in Perl, but we \ntry very hard to consolidate the major pieces into C code. This is done \nfor several reasons:\n\n- reducing dependencies (not everybody needs all git programs, so it even \nhelps if one script is converted at a time), and\n\n- making the experience nicer on Windows (reducing the foot-print, since \nPerl is _not_ commonly installed, and drastically improving performance, \nsince the number of processes is reduced).\n\nSo no, I would not like these scripts being converted (back?) to scripts.\n\nThank you,\nDscho\n"}]}