{"thread":{"id":"11920","subject":"[PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list","startedAt":"2008-02-06T17:15:12Z","lastAt":"2008-02-10T02:46:11Z","messageCount":6,"participants":["Bruno Ribas","Jakub Narebski","Bruno Cesar Ribas","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"67677","messageId":"1202318112-8223-1-git-send-email-ribas@c3sl.ufpr.br","threadId":"11920","inReplyTo":null,"subject":"[PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list","fromName":"Bruno Ribas","fromEmail":"ribas@c3sl.ufpr.br","sentAt":"2008-02-06T17:15:12Z","receivedAt":"2008-02-06T17:15:12Z","isPatch":true,"sender":{"key":"ribas@c3sl.ufpr.br","avatar":null},"body":"\nSigned-off-by: Bruno Ribas \n---\n gitweb/gitweb.perl | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex ae2d057..0cb3cb0 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1620,7 +1620,7 @@ sub git_get_project_url_list {\n \tmy $path = shift;\n \n \t$git_dir = \"$projectroot/$path\";\n-\topen my $fd, \"$projectroot/$path/cloneurl\"\n+\topen my $fd, \"$git_dir/cloneurl\"\n \t\tor return wantarray ?\n \t\t@{ config_to_multi(git_get_project_config('url')) } :\n \t\t config_to_multi(git_get_project_config('url'));\n-- \n1.5.4.23.gef5b9\n"},{"id":"67688","messageId":"m3ve51511t.fsf@localhost.localdomain","threadId":"11920","inReplyTo":"1202318112-8223-1-git-send-email-ribas@c3sl.ufpr.br","subject":"Re: [PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-02-06T19:37:51Z","receivedAt":"2008-02-06T19:37:51Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Bruno Ribas writes:\n\n> @@ -1620,7 +1620,7 @@ sub git_get_project_url_list {\n> \tmy $path = shift;\n> \n> \t$git_dir = \"$projectroot/$path\";\n> -\topen my $fd, \"$projectroot/$path/cloneurl\"\n> +\topen my $fd, \"$git_dir/cloneurl\"\n> \t\tor return wantarray ?\n> \t\t@{ config_to_multi(git_get_project_config('url')) } :\n> \t\t config_to_multi(git_get_project_config('url'));\n\nGood catch (although it wasn't actually a bug).\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"67889","messageId":"20080208041542.GA28336@c3sl.ufpr.br","threadId":"11920","inReplyTo":"m3ve51511t.fsf@localhost.localdomain","subject":"Re: [PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list","fromName":"Bruno Cesar Ribas","fromEmail":"ribas@c3sl.ufpr.br","sentAt":"2008-02-08T04:15:42Z","receivedAt":"2008-02-08T04:15:42Z","isPatch":true,"sender":{"key":"ribas@c3sl.ufpr.br","avatar":null},"body":"Just Remembering\n\nOn Wed, Feb 06, 2008 at 11:37:51AM -0800, Jakub Narebski wrote:\n> Bruno Ribas writes:\n> \n> Good catch (although it wasn't actually a bug).\n\nNot a bug but makes the code cleaner =)\n> \n> -- \n> Jakub Narebski\n> Poland\n> ShadeHawk on #git\n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n\n-- \nBruno Ribas - ribas@c3sl.ufpr.br\nhttp://web.inf.ufpr.br/ribas\nC3SL: http://www.c3sl.ufpr.br \n"},{"id":"67899","messageId":"7vbq6sm0j3.fsf@gitster.siamese.dyndns.org","threadId":"11920","inReplyTo":"20080208041542.GA28336@c3sl.ufpr.br","subject":"Re: [PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-08T06:21:04Z","receivedAt":"2008-02-08T06:21:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Bruno Cesar Ribas writes:\n\n> Just Remembering\n>\n> On Wed, Feb 06, 2008 at 11:37:51AM -0800, Jakub Narebski wrote:\n>> Bruno Ribas writes:\n>> \n>> Good catch (although it wasn't actually a bug).\n>\n> Not a bug but makes the code cleaner =)\n\nI think I saw very similar 's|projectroot/$path|$git_dir|' patch\nrecently. If there are more of the same, I'd rather see all of\nthem in a single patch.\n"},{"id":"67912","messageId":"200802081015.39707.jnareb@gmail.com","threadId":"11920","inReplyTo":"7vbq6sm0j3.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-02-08T09:15:39Z","receivedAt":"2008-02-08T09:15:39Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n> Bruno Cesar Ribas writes:\n>> On Wed, Feb 06, 2008 at 11:37:51AM -0800, Jakub Narebski wrote:\n>>> Bruno Ribas writes:\n>>>\n>>> \n>>>\n>>> Good catch (although it wasn't actually a bug).\n>>\n>> Not a bug but makes the code cleaner =)\n> \n> I think I saw very similar 's|projectroot/$path|$git_dir|' patch\n> recently. If there are more of the same, I'd rather see all of\n> them in a single patch.\n\nThat's all that it is. Those patches are about places where we read\nfile inside repo or get repo config, and there are only two places now: \ndescription and cloneurl/URL list.\n\n-- \nJakub Narebski\nPoland\n"},{"id":"68154","messageId":"20080210024611.GA31577@c3sl.ufpr.br","threadId":"11920","inReplyTo":"200802081015.39707.jnareb@gmail.com","subject":"Re: [PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list","fromName":"Bruno Cesar Ribas","fromEmail":"ribas@c3sl.ufpr.br","sentAt":"2008-02-10T02:46:11Z","receivedAt":"2008-02-10T02:46:11Z","isPatch":true,"sender":{"key":"ribas@c3sl.ufpr.br","avatar":null},"body":"On Fri, Feb 08, 2008 at 10:15:39AM +0100, Jakub Narebski wrote:\n> Junio C Hamano wrote:\n> > Bruno Cesar Ribas writes:\n> >> On Wed, Feb 06, 2008 at 11:37:51AM -0800, Jakub Narebski wrote:\n> >>> Bruno Ribas writes:\n> >>>\n> >>> \n> >>>\n> >>> Good catch (although it wasn't actually a bug).\n> >>\n> >> Not a bug but makes the code cleaner =)\n> > \n> > I think I saw very similar 's|projectroot/$path|$git_dir|' patch\n> > recently. If there are more of the same, I'd rather see all of\n> > them in a single patch.\n> \n> That's all that it is. Those patches are about places where we read\n> file inside repo or get repo config, and there are only two places now: \n> description and cloneurl/URL list.\n\nAnd (if added) at the owner's place ;)\n\n> \n> -- \n> Jakub Narebski\n> Poland\n\n-- \nBruno Ribas - ribas@c3sl.ufpr.br\nhttp://web.inf.ufpr.br/ribas\nC3SL: http://www.c3sl.ufpr.br \n"}]}