{"thread":{"id":"1189","subject":"Re: qgit-0.7","startedAt":"2005-07-09T15:06:21Z","lastAt":"2005-07-09T15:06:21Z","messageCount":1,"participants":["Marco Costalba"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"5868","messageId":"20050709150621.51442.qmail@web26310.mail.ukl.yahoo.com","threadId":"1189","inReplyTo":null,"subject":"Re: qgit-0.7","fromName":"Marco Costalba","fromEmail":"mcostalba@yahoo.it","sentAt":"2005-07-09T15:06:21Z","receivedAt":"2005-07-09T15:06:21Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"Wolfgang Denk ha scritto:\n\n>Dear Marco,\n>\n>in message <20050709081512.33503.qmail@web26306.mail.ukl.yahoo.com> you wrote:\n>\n>>Here is qgit-0.7, a GUI git viewer.\n>\n>\n>Sorry, but I cannot compile it on a Fedora Core 4 system:\n>\n>-> ./configure \n>+scons was found, that's excellent+\n>scons: Reading SConscript files ...\n>-> make\n>scons -Q\n>g++ -DQT_THREAD_SUPPORT -D_REENTRANT -I/usr/lib64/qt-3.3/include -c -o src/annotate.o\nsrc/annotate.cpp\n>src/annotate.cpp: In member function `QStringList Annotate::processDiff(const \n>   QString&, QStringList&, const QString&)':\n>src/annotate.cpp:378: error: jump to case label\n>src/annotate.cpp:373: error:   crosses initialization of `int num'\n>src/annotate.cpp:387: error: jump to case label\n>src/annotate.cpp:373: error:   crosses initialization of `int num'\n>src/annotate.cpp:401: error: jump to case label\n>src/annotate.cpp:373: error:   crosses initialization of `int num'\n>scons: *** [src/annotate.o] Error 1\n>make: *** [all] Error 2\n>\n>The following patch solves this problem:\n>\n>--- src/annotate.cpp.ORIG\t2005-07-09 07:10:23.000000000 +0200\n>+++ src/annotate.cpp\t2005-07-09 16:05:09.556653902 +0200\n>@@ -370,10 +370,12 @@\n> \t\tchar firstChar = line[0].latin1();\n> \t\tswitch (firstChar) {\n> \t\tcase '@':\n>+\t\t    {\n> \t\t\tint num = line.section(',', 1, 1). section('+', 1, 1).toInt();\n> \t\t\t// diff lines start from 1, 0 is empty file,\n> \t\t\t// instead QValueList::at() starts from 0\n> \t\t\tcur = (num > 0) ? newAnn.at(num - 1) : newAnn.end();\n>+\t\t    }\n> \t\t\tbreak;\n> \t\tcase '+':\n> \t\t\tif (cur != newAnn.end()) {\n>\n>\n\nThanks for your patch, applied.\n\nWhat version og gcc you have? \nMine is gcc version 4.0.1 and I don't have this compile error (of course ;-) ).\n\nI have cc'ed to git@vger.kernel.org in case someone else have the same problem.\n\n\n>With this patch, I get a lot of build errors:\n>\n>QSettings: error creating /.qt\n>QSettings: error creating /.qt\n>QSettings: error creating /.qt\n>QSettings: error creating /.qt\n>QSettings: error creating /.qt\n>QSettings::sync: filename is null/empty\n>QSettings: error creating /.qt\n>QSettings::sync: filename is null/empty\n>QSettings: error creating /.qt\n>QSettings::sync: filename is null/empty\n>QSettings: error creating /.qt\n>QSettings::sync: filename is null/empty\n>QSettings: error creating /.qt\n>QSettings::sync: filename is null/empty\n>QSettings: error creating /.qt\n>QSettings::sync: filename is null/empty\n>...\n>\n>It links and seems to run, though.\n>\n\nIt's a known issue, probably due to scons setup, but I am not so familiar with scons\nto find a fix, in any case should be absolutely painless.\n\n\nMarco\n\n\n__________________________________________________\nDo You Yahoo!?\nTired of spam?  Yahoo! Mail has the best spam protection around \nhttp://mail.yahoo.com \n"}]}