{"thread":{"id":"11861","subject":"[PATCH] Documentation/SubmittingPatches: Instruct how to use [PATCH] Subject header","startedAt":"2008-02-04T00:24:10Z","lastAt":"2008-02-04T08:12:14Z","messageCount":6,"participants":["Jari Aalto","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"67289","messageId":"r6ft1sd1.fsf@blue.sea.net","threadId":"11861","inReplyTo":null,"subject":"[PATCH] Documentation/SubmittingPatches: Instruct how to use [PATCH] Subject header","fromName":"Jari Aalto","fromEmail":"jari.aalto@cante.net","sentAt":"2008-02-04T00:24:10Z","receivedAt":"2008-02-04T00:24:10Z","isPatch":true,"sender":{"key":"jari.aalto@cante.net","avatar":"https://avatars.githubusercontent.com/u/34601?v=4"},"body":"Suggest putting additional message inside brackets, like [PATCH v2]\nfor reworked content.\n\nSigned-off-by: Jari Aalto \n---\n Idea by Jakub Narebski\n\n Documentation/SubmittingPatches | 3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex de08d09..69ecbd3 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -37,6 +37,9 @@ Checklist (and a short version for the impatient):\n \t maintainer (gitster@pobox.com). If you use\n \t git-send-email(1), please test it first by sending\n \t email to yourself.\n+ - If you rework the patch, announce the message\n+ in brackets. For example \"[PATCH/RFC]\", \"[PATCH (resend)]\",\n+ \"[PATCH v2]\" etc.\n \n Long version:\n \n-- \n1.5.4-rc5.GIT-dirty\n\n\n\n-- \nWelcome to FOSS revolution: we fix and modify until it shines\n"},{"id":"67293","messageId":"alpine.LSU.1.00.0802040029020.7372@racer.site","threadId":"11861","inReplyTo":"r6ft1sd1.fsf@blue.sea.net","subject":"Re: [PATCH] Documentation/SubmittingPatches: Instruct how to use [PATCH] Subject header","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-02-04T00:29:34Z","receivedAt":"2008-02-04T00:29:34Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 4 Feb 2008, Jari Aalto wrote:\n\n> @@ -37,6 +37,9 @@ Checklist (and a short version for the impatient):\n> \t maintainer (gitster@pobox.com). If you use\n> \t git-send-email(1), please test it first by sending\n> \t email to yourself.\n> + - If you rework the patch, announce the message\n> + in brackets. For example \"[PATCH/RFC]\", \"[PATCH (resend)]\",\n> + \"[PATCH v2]\" etc.\n\nWhitespace error? (Spaces instead of Tabs)\n\nCiao,\nDscho\n"},{"id":"67296","messageId":"7v7ihlpmkm.fsf@gitster.siamese.dyndns.org","threadId":"11861","inReplyTo":"r6ft1sd1.fsf@blue.sea.net","subject":"Re: [PATCH] Documentation/SubmittingPatches: Instruct how to use [PATCH] Subject header","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-04T00:55:21Z","receivedAt":"2008-02-04T00:55:21Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jari Aalto writes:\n\n> Suggest putting additional message inside brackets, like [PATCH v2]\n> for reworked content.\n>\n> Signed-off-by: Jari Aalto \n> ---\n> Idea by Jakub Narebski\n>\n> Documentation/SubmittingPatches | 3 +++\n> 1 files changed, 3 insertions(+), 0 deletions(-)\n>\n> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\n> index de08d09..69ecbd3 100644\n> --- a/Documentation/SubmittingPatches\n> +++ b/Documentation/SubmittingPatches\n> @@ -37,6 +37,9 @@ Checklist (and a short version for the impatient):\n> \t maintainer (gitster@pobox.com). If you use\n> \t git-send-email(1), please test it first by sending\n> \t email to yourself.\n> + - If you rework the patch, announce the message\n> + in brackets. For example \"[PATCH/RFC]\", \"[PATCH (resend)]\",\n> + \"[PATCH v2]\" etc.\n> \n\nThis adds something to the \"short version\" that the full version\ndoes not even talk about?\n\nI do not think this needs to be in the short version, but an\nupdate to the full version would indeed be a good idea.\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex de08d09..0661293 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -112,7 +112,12 @@ lose tabs that way if you are not careful.\n \n It is a common convention to prefix your subject line with\n [PATCH]. This lets people easily distinguish patches from other\n-e-mail discussions.\n+e-mail discussions. Use of additional markers after PATCH and\n+the closing bracket to mark the nature of the patch is also\n+encouraged. E.g. [PATCH/RFC] is often used when the patch is\n+not ready to be applied but it is for discussion, [PATCH v2],\n+[PATCH v3] etc. are often seen when you are sending an update to\n+what you have previously sent.\n \n \"git format-patch\" command follows the best current practice to\n format the body of an e-mail message. At the beginning of the\n"},{"id":"67299","messageId":"7v3as9pmcf.fsf_-_@gitster.siamese.dyndns.org","threadId":"11861","inReplyTo":"7v7ihlpmkm.fsf@gitster.siamese.dyndns.org","subject":"[PATCH 1/2 (RFC)] Documentation/SubmittingPatches: discuss first then submit","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-04T01:00:16Z","receivedAt":"2008-02-04T01:00:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"This is something I've had in mind for some time. I get enough\ne-mails as-is, and I suspect the workflow to get list members\ninvolved would work better if we get the discussion concluded on\nthe list first before patches hit my tree (even 'next').\n\n---\nOn top of the previous one to talk about [PATCH v2] and friends...\n\n Documentation/SubmittingPatches | 23 ++++++++++++++++-------\n 1 files changed, 16 insertions(+), 7 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex cd80148..0661293 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -34,9 +34,9 @@ Checklist (and a short version for the impatient):\n \t- if your name is not writable in ASCII, make sure that\n \t you send off a message in the correct encoding.\n \t- send the patch to the list (git@vger.kernel.org) and the\n-\t maintainer (gitster@pobox.com). If you use\n-\t git-send-email(1), please test it first by sending\n-\t email to yourself.\n+\t maintainer (gitster@pobox.com) if (and only if) the patch\n+\t is ready for inclusion. If you use git-send-email(1),\n+\t please test it first by sending email to yourself.\n \n Long version:\n \n@@ -162,7 +162,8 @@ Note that your maintainer does not necessarily read everything\n on the git mailing list. If your patch is for discussion first,\n send it \"To:\" the mailing list, and optionally \"cc:\" him. If it\n is trivially correct or after the list reached a consensus, send\n-it \"To:\" the maintainer and optionally \"cc:\" the list.\n+it \"To:\" the maintainer and optionally \"cc:\" the list for\n+inclusion.\n \n Also note that your maintainer does not actively involve himself in\n maintaining what are in contrib/ hierarchy. When you send fixes and\n"},{"id":"67301","messageId":"7vwsplo7ob.fsf_-_@gitster.siamese.dyndns.org","threadId":"11861","inReplyTo":"7v7ihlpmkm.fsf@gitster.siamese.dyndns.org","subject":"[PATCH 2/2] Documentation/SubmittingPatches: What's Acked-by and Tested-by?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-04T01:02:28Z","receivedAt":"2008-02-04T01:02:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"We used to talk about \"internal company procedures\", but this\ndocument is about submitting patches to the git mailing list.\n\nMore useful information is when to say Acked-by: and Tested-by:.\n\nSigned-off-by: Junio C Hamano \n---\n Documentation/SubmittingPatches | 16 ++++++++++++----\n 1 files changed, 12 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex 7900223..0661293 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -216,10 +216,18 @@ then you just add a line saying\n This line can be automatically added by git if you run the git-commit\n command with the -s option.\n \n-Some people also put extra tags at the end. They'll just be ignored for\n-now, but you can do this to mark internal company procedures or just\n-point out some special detail about the sign-off.\n-\n+Notice that you can place your own Signed-off-by: line when\n+forwarding somebody else's patch with the above rules for\n+D-C-O. Indeed you are encouraged to do so. Do not forget to\n+place an in-body \"From: \" line at the beginning to properly attribute\n+the change to its true author (see (2) above).\n+\n+Some people also put extra tags at the end.\n+\n+\"Acked-by:\" says that the patch was reviewed by the person who\n+is more familiar with the issues and the area the patch attempts\n+to modify. \"Tested-by:\" says the patch was tested by the person\n+and found to have the desired effect.\n \n ------------------------------------------------\n MUA specific hints\n"},{"id":"67334","messageId":"ejbt16ox.fsf@blue.sea.net","threadId":"11861","inReplyTo":"alpine.LSU.1.00.0802040029020.7372@racer.site","subject":"Re: [PATCH] Documentation/SubmittingPatches: Instruct how to use [PATCH] Subject header","fromName":"Jari Aalto","fromEmail":"jari.aalto@cante.net","sentAt":"2008-02-04T08:12:14Z","receivedAt":"2008-02-04T08:12:14Z","isPatch":true,"sender":{"key":"jari.aalto@cante.net","avatar":"https://avatars.githubusercontent.com/u/34601?v=4"},"body":"* Mon 2008-02-04 Johannes Schindelin \n>\n> Whitespace error? (Spaces instead of Tabs)\n\nThere should be a big notice at the beginning of\nDocumentation/SubmittingPatches:\n\nJunio, would you add this.\n\nJari\n\n----------------------------------------------------------------\nChecklist (and a short version for the impatient):\n\n General:\n\n NOTE: Please set your editor to use tabs instead of\n spaces. In Emacs this can be set with\n (setq indent-tabs-mode t) and in vi this can be set \n with ...\n\n Commits:\n\n-- \nWelcome to FOSS revolution: we fix and modify until it shines\n"}]}