{"thread":{"id":"11830","subject":"[PATCH 4/4] instaweb: use 'git-web--browse' to launch browser.","startedAt":"2008-02-02T06:32:56Z","lastAt":"2008-02-02T06:32:56Z","messageCount":1,"participants":["Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"67085","messageId":"20080202073256.d9ce1dba.chriscool@tuxfamily.org","threadId":"11830","inReplyTo":null,"subject":"[PATCH 4/4] instaweb: use 'git-web--browse' to launch browser.","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2008-02-02T06:32:56Z","receivedAt":"2008-02-02T06:32:56Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n git-instaweb.sh |   20 ++++++--------------\n 1 files changed, 6 insertions(+), 14 deletions(-)\n\ndiff --git a/git-instaweb.sh b/git-instaweb.sh\nindex 3e4452b..6f91c8f 100755\n--- a/git-instaweb.sh\n+++ b/git-instaweb.sh\n@@ -24,8 +24,6 @@ restart        restart the web server\n fqgitdir=\"$GIT_DIR\"\n local=\"`git config --bool --get instaweb.local`\"\n httpd=\"`git config --get instaweb.httpd`\"\n-browser=\"`git config --get instaweb.browser`\"\n-test -z \"$browser\" && browser=\"`git config --get web.browser`\"\n port=`git config --get instaweb.port`\n module_path=\"`git config --get instaweb.modulepath`\"\n \n@@ -36,9 +34,6 @@ conf=\"$GIT_DIR/gitweb/httpd.conf\"\n # if installed, it doesn't need further configuration (module_path)\n test -z \"$httpd\" && httpd='lighttpd -f'\n \n-# probably the most popular browser among gitweb users\n-test -z \"$browser\" && browser='firefox'\n-\n # any untaken local port will do...\n test -z \"$port\" && port=1234\n \n@@ -274,14 +269,11 @@ webrick)\n \t;;\n esac\n \n-init_browser_path() {\n-\tbrowser_path=\"`git config browser.$1.path`\"\n-\ttest -z \"$browser_path\" && browser_path=\"$1\"\n-}\n-\n start_httpd\n url=http://127.0.0.1:$port\n-test -n \"$browser\" && {\n-\tinit_browser_path \"$browser\"\n-\t\"$browser_path\" $url\n-} || echo $url\n+\n+if test -n \"$browser\"; then\n+\tgit web--browse -b \"$browser\" $url || echo $url\n+else\n+\tgit web--browse -c \"instaweb.browser\" $url || echo $url\n+fi\n-- \n1.5.4.rc5.25.g7a831-dirty\n"}]}