{"thread":{"id":"11821","subject":"[EGIT PATCH] Comment private modifier to improve performace.","startedAt":"2008-02-02T02:23:38Z","lastAt":"2008-02-03T22:25:47Z","messageCount":7,"participants":["Roger C. Soares","Robin Rosenberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"67064","messageId":"1201919018-10782-1-git-send-email-rogersoares@intelinet.com.br","threadId":"11821","inReplyTo":null,"subject":"[EGIT PATCH] Comment private modifier to improve performace.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-02-02T02:23:38Z","receivedAt":"2008-02-02T02:23:38Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"Changed private modifiers to default to improve perfomance and remove\nwarnings of the type:\nWrite access to enclosing field GitHistoryPage.hintShowDiffNow is\nemulated by a synthetic accessor method. Increasing its visibility will\nimprove your performance\n\nSigned-off-by: Roger C. Soares <rogersoares@intelinet.com.br>\n---\n .../egit/core/internal/mapping/GitFileHistory.java |    2 +-\n .../src/org/spearce/egit/ui/GitHistoryPage.java    |    2 +-\n .../internal/actions/AbstractOperationAction.java  |    2 +-\n .../internal/decorators/GitResourceDecorator.java  |    2 +-\n .../ui/internal/dialogs/BranchSelectionDialog.java |    2 +-\n .../egit/ui/internal/dialogs/CommitDialog.java     |    2 +-\n .../src/org/spearce/jgit/lib/GitIndex.java         |   14 +++++++-------\n .../src/org/spearce/jgit/lib/Walker.java           |   12 ++++++------\n .../src/org/spearce/jgit/lib/WindowedFile.java     |    6 +++---\n .../src/org/spearce/jgit/lib/WorkDirCheckout.java  |    2 +-\n 10 files changed, 23 insertions(+), 23 deletions(-)\n\ndiff --git a/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitFileHistory.java b/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitFileHistory.java\nindex 889ca0c..9e683a5 100644\n--- a/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitFileHistory.java\n+++ b/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitFileHistory.java\n@@ -107,7 +107,7 @@ public class GitFileHistory extends FileHistory implements IAdaptable {\n \n \t\tIResource resource;\n \t\tprivate final IProgressMonitor monitor;\n-\t\tprivate Map<ObjectId, IFileRevision> revisions = new HashMap<ObjectId, IFileRevision>();\n+\t\t/* private */Map<ObjectId, IFileRevision> revisions = new HashMap<ObjectId, IFileRevision>();\n \n \t\tEclipseWalker(Repository repository, Commit[] starts, String[] relativeResourceName,boolean leafIsBlob,IResource resource,boolean followMainOnly, Boolean merges, ObjectId lastActiveDiffId, boolean returnAll, IProgressMonitor monitor) {\n \t\t\tsuper(repository, starts, relativeResourceName, leafIsBlob, followMainOnly, merges, lastActiveDiffId, returnAll);\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java\nindex 812747d..1f154a5 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java\n@@ -137,7 +137,7 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,\n \n \t/* private */List<IFileRevision> fileRevisions;\n \n-\tprivate boolean hintShowDiffNow;\n+\t/* private */boolean hintShowDiffNow;\n \n \tprivate boolean showAllProjectVersions;\n \ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/AbstractOperationAction.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/AbstractOperationAction.java\nindex c3f347e..d8e1961 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/AbstractOperationAction.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/AbstractOperationAction.java\n@@ -42,7 +42,7 @@ import org.spearce.egit.ui.UIText;\n public abstract class AbstractOperationAction implements IObjectActionDelegate {\n \tprivate IWorkbenchPart wp;\n \n-\tprivate IWorkspaceRunnable op;\n+\t/* private */IWorkspaceRunnable op;\n \n \tpublic void selectionChanged(final IAction act, final ISelection sel) {\n \t\tfinal List selection;\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java\nindex c13c38a..cc387bc 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java\n@@ -67,7 +67,7 @@ import org.spearce.jgit.lib.Repository.RepositoryState;\n public class GitResourceDecorator extends LabelProvider implements\n \t\tILightweightLabelDecorator {\n \n-\tprivate static final RCL myrcl = new RCL();\n+\t/* private */static final RCL myrcl = new RCL();\n \n \tstatic class RCL implements RepositoryChangeListener, Runnable {\n \t\tprivate boolean requested;\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/BranchSelectionDialog.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/BranchSelectionDialog.java\nindex 5e30027..2d140a4 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/BranchSelectionDialog.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/BranchSelectionDialog.java\n@@ -215,7 +215,7 @@ public class BranchSelectionDialog extends Dialog {\n \t\treturn refName;\n \t}\n \n-\tprivate ResetType resetType = ResetType.MIXED;\n+\t/* private */ResetType resetType = ResetType.MIXED;\n \t\n \t/**\n \t * @return Type of Reset\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java\nindex 3778b94..847666f 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java\n@@ -327,7 +327,7 @@ public class CommitDialog extends Dialog {\n \tprivate boolean amendAllowed = true;\n \n \tprivate ArrayList<IFile> selectedItems = new ArrayList<IFile>();\n-\tprivate String previousCommitMessage = \"\";\n+\t/* private */String previousCommitMessage = \"\";\n \n \t/**\n \t * Pre-select suggested set of resources to commit\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java b/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java\nindex f49370c..bdcb71a 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java\n@@ -64,7 +64,7 @@ public class GitIndex {\n \n \tprivate long lastCacheTime;\n \n-\tprivate final Repository db;\n+\t/* private */final Repository db;\n \n \tprivate Map entries = new TreeMap(new Comparator() {\n \t\tpublic int compare(Object arg0, Object arg1) {\n@@ -311,7 +311,7 @@ public class GitIndex {\n \t}\n \n \tBoolean filemode;\n-\tprivate boolean config_filemode() {\n+\t/* private */boolean config_filemode() {\n \t\t// temporary til we can actually set parameters. We need to be able\n \t\t// to change this for testing.\n \t\tif (filemode != null)\n@@ -322,15 +322,15 @@ public class GitIndex {\n \n \t/** An index entry */\n \tpublic class Entry {\n-\t\tprivate long ctime;\n+\t\t/* private */long ctime;\n \n-\t\tprivate long mtime;\n+\t\t/* private */long mtime;\n \n \t\tprivate int dev;\n \n \t\tprivate int ino;\n \n-\t\tprivate int mode;\n+\t\t/* private */int mode;\n \n \t\tprivate int uid;\n \n@@ -338,11 +338,11 @@ public class GitIndex {\n \n \t\tprivate int size;\n \n-\t\tprivate ObjectId sha1;\n+\t\t/* private */ObjectId sha1;\n \n \t\tprivate short flags;\n \n-\t\tprivate byte[] name;\n+\t\t/* private */byte[] name;\n \n \t\tEntry(byte[] key, File f, int stage)\n \t\t\t\tthrows IOException {\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java b/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java\nindex 1f6c531..eb824e0 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java\n@@ -17,15 +17,15 @@ import java.util.Map;\n  * data according to some criteria.\n  */\n public abstract class Walker {\n-\tprivate String[] relativeResourceName;\n-\tprivate boolean leafIsBlob;\n-\tprivate boolean followMainOnly;\n+\t/* private */String[] relativeResourceName;\n+\t/* private */boolean leafIsBlob;\n+\t/* private */boolean followMainOnly;\n \tprotected Repository repository;\n \tprivate ObjectId activeDiffLeafId;\n \tprotected final Commit[] starts;\n-\tprivate final Boolean merges;\n-\tprivate Map donewith = new ObjectIdMap();\n-\tprivate Collection<Todo> todo = new ArrayList<Todo>(20000);\n+\t/* private */final Boolean merges;\n+\t/* private */Map donewith = new ObjectIdMap();\n+\t/* private */Collection<Todo> todo = new ArrayList<Todo>(20000);\n \n \tprotected abstract boolean isCancelled();\n \t\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java\nindex 39f1477..13fecad 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java\n@@ -66,15 +66,15 @@ public class WindowedFile {\n \n \tprivate final WindowCache cache;\n \n-\tprivate final int sz;\n+\t/* private */final int sz;\n \n-\tprivate final int szb;\n+\t/* private */final int szb;\n \n \tprivate final int szm;\n \n \tprivate final Provider wp;\n \n-\tprivate final long length;\n+\t/* private */final long length;\n \n \t/**\n \t * Open a file for reading through window caching.\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WorkDirCheckout.java b/org.spearce.jgit/src/org/spearce/jgit/lib/WorkDirCheckout.java\nindex 926dac3..6159469 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/lib/WorkDirCheckout.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WorkDirCheckout.java\n@@ -362,7 +362,7 @@ public class WorkDirCheckout {\n \t\treturn hasParentBlob(t, parent);\n \t}\n \n-\tprivate void checkConflictsWithFile(File file) {\n+\t/* private */void checkConflictsWithFile(File file) {\n \t\tif (file.isDirectory()) {\n \t\t\tArrayList<String> childFiles = listFiles(file);\n \t\t\tconflicts.addAll(childFiles);\n-- \n1.5.3.7\n"},{"id":"67167","messageId":"200802030201.10971.robin.rosenberg@dewire.com","threadId":"11821","inReplyTo":"1201919018-10782-1-git-send-email-rogersoares@intelinet.com.br","subject":"Re: [EGIT PATCH] Comment private modifier to improve performace.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2008-02-03T01:01:10Z","receivedAt":"2008-02-03T01:01:10Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"lördagen den 2 februari 2008 skrev Roger C. Soares:\n> Changed private modifiers to default to improve perfomance and remove\n> warnings of the type:\n> Write access to enclosing field GitHistoryPage.hintShowDiffNow is\n> emulated by a synthetic accessor method. Increasing its visibility will\n> improve your performance\n\nI'm not fully convinced this is the right way after all. Good\nperformance is obviously good, but so is good encapsulation. \nI've sometimes tried changing things like this even in pieces\nof code that I really thought it should matter, but not been able\nto measure any real improvemen even with performance measurment tools.\n\nObviously seeing that warning is annoying so maybe we should just set it to\nignore or exclude it from the project settings (if that is possible). The\nonly project where I think it might make a difference is the jgit part because\nthat is where we optimize and that is where I experimented with visibility\nchanges. In the Eclipse part we need to encapsulate more, partly because \nEclipse is less understood by the current authors than Java in general. \nEncapsulation means encapsulating bad coding and bad design that comes\nfrom lack of understanding of the framework we are working within.\n\n-- robin\n\nFrom f26deb2c14e1df7513b3954594ea09b7746fcb69 Mon Sep 17 00:00:00 2001\nFrom: Robin Rosenberg <robin.rosenberg@dewire.com>\nDate: Sun, 3 Feb 2008 01:46:33 +0100\nSubject: [PATCH] Ignore warning for \"Access to enclosing method/field X emulated by a synthetic accessor method\"\n\nThere is no measurable performance degradation from this. Increasing visibility\nof methods and fields in order to get rid of this warning reduces encapsulation.\n\nInstead of choosing the Ignore setting we remove the setting from the project,\nwhich may be somwhat hackish but has the benefit that the setting can be changed\nin the workspace for those that wants to investigate the issue.\n\nSigned-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n 5 files changed, 0 insertions(+), 5 deletions(-)\n\ndiff --git a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\nindex deec031..7a0fbe4 100644\n--- a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n@@ -55,7 +55,6 @@ org.eclipse.jdt.core.compiler.problem.redundantNullCheck=warning\n org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled\n org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error\n org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled\n-org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=warning\n org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\ndiff --git a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\nindex fa7a0b7..bcde160 100644\n--- a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n@@ -55,7 +55,6 @@ org.eclipse.jdt.core.compiler.problem.redundantNullCheck=warning\n org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled\n org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error\n org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled\n-org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=warning\n org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\ndiff --git a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\nindex 0ef7591..0a89f52 100644\n--- a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n@@ -55,7 +55,6 @@ org.eclipse.jdt.core.compiler.problem.redundantNullCheck=warning\n org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled\n org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error\n org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled\n-org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=warning\n org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\ndiff --git a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\nindex 65d5c31..c203c20 100644\n--- a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n@@ -55,7 +55,6 @@ org.eclipse.jdt.core.compiler.problem.redundantNullCheck=warning\n org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled\n org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error\n org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled\n-org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=warning\n org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\ndiff --git a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\nindex 4c38185..b0c694c 100644\n--- a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n@@ -55,7 +55,6 @@ org.eclipse.jdt.core.compiler.problem.redundantNullCheck=warning\n org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled\n org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error\n org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled\n-org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=warning\n org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\n-- \n1.5.4.rc4.25.g81cc\n"},{"id":"67174","messageId":"200802030326.40446.robin.rosenberg@dewire.com","threadId":"11821","inReplyTo":"200802030201.10971.robin.rosenberg@dewire.com","subject":"Re: [EGIT PATCH] Comment private modifier to improve performace.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2008-02-03T02:26:39Z","receivedAt":"2008-02-03T02:26:39Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"\nWe could drop these settings from the projects too. \n\n-- robin\n\n\nFrom a1aed72a122a05d01ed57db5d51b45debeb247b7 Mon Sep 17 00:00:00 2001\nFrom: Robin Rosenberg <robin.rosenberg@dewire.com>\nDate: Sun, 3 Feb 2008 03:13:44 +0100\nSubject: [PATCH] Make it possible to ignore warnings about discouraged access\n\nBy removing the setting from the project the workspace settings\nwill be applied (default: Warning)\n\nSigned-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n 5 files changed, 0 insertions(+), 5 deletions(-)\n\ndiff --git a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\nindex 7a0fbe4..1c978ca 100644\n--- a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n@@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning\n org.eclipse.jdt.core.compiler.problem.deprecation=warning\n org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled\n org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled\n-org.eclipse.jdt.core.compiler.problem.discouragedReference=warning\n org.eclipse.jdt.core.compiler.problem.emptyStatement=warning\n org.eclipse.jdt.core.compiler.problem.enumIdentifier=error\n org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning\ndiff --git a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\nindex bcde160..2afc050 100644\n--- a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n@@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning\n org.eclipse.jdt.core.compiler.problem.deprecation=warning\n org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled\n org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled\n-org.eclipse.jdt.core.compiler.problem.discouragedReference=warning\n org.eclipse.jdt.core.compiler.problem.emptyStatement=warning\n org.eclipse.jdt.core.compiler.problem.enumIdentifier=error\n org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning\ndiff --git a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\nindex 0a89f52..0da92c7 100644\n--- a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n@@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning\n org.eclipse.jdt.core.compiler.problem.deprecation=warning\n org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled\n org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled\n-org.eclipse.jdt.core.compiler.problem.discouragedReference=warning\n org.eclipse.jdt.core.compiler.problem.emptyStatement=warning\n org.eclipse.jdt.core.compiler.problem.enumIdentifier=error\n org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning\ndiff --git a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\nindex c203c20..9adf651 100644\n--- a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n@@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning\n org.eclipse.jdt.core.compiler.problem.deprecation=warning\n org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled\n org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled\n-org.eclipse.jdt.core.compiler.problem.discouragedReference=warning\n org.eclipse.jdt.core.compiler.problem.emptyStatement=warning\n org.eclipse.jdt.core.compiler.problem.enumIdentifier=error\n org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning\ndiff --git a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\nindex b0c694c..faecf76 100644\n--- a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n@@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning\n org.eclipse.jdt.core.compiler.problem.deprecation=warning\n org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled\n org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled\n-org.eclipse.jdt.core.compiler.problem.discouragedReference=warning\n org.eclipse.jdt.core.compiler.problem.emptyStatement=warning\n org.eclipse.jdt.core.compiler.problem.enumIdentifier=error\n org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning\n-- \n1.5.4.rc4.25.g81cc\n\n\n\nFrom e9f312599eb5941a7bf1acd70c6f0ac9fb1ea889 Mon Sep 17 00:00:00 2001\nFrom: Robin Rosenberg <robin.rosenberg@dewire.com>\nDate: Sun, 3 Feb 2008 03:19:09 +0100\nSubject: [PATCH] Drop warnings about unnecessary else\n\nUse workspace setting, default ignore.\n\nSigned-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n .../.settings/org.eclipse.jdt.core.prefs           |    3 +--\n 5 files changed, 1 insertions(+), 6 deletions(-)\n\ndiff --git a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\nindex 1c978ca..7279d81 100644\n--- a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n@@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\n org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning\n-org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning\n org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error\n org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore\n org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error\ndiff --git a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\nindex 2afc050..2d94530 100644\n--- a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n@@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\n org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning\n-org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning\n org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error\n org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore\n org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error\ndiff --git a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\nindex 0da92c7..ff09222 100644\n--- a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n@@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\n org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning\n-org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning\n org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error\n org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore\n org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error\ndiff --git a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\nindex 9adf651..b93093f 100644\n--- a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n@@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\n org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning\n-org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning\n org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error\n org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore\n org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error\ndiff --git a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\nindex faecf76..4a5d15f 100644\n--- a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n+++ b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n@@ -1,4 +1,4 @@\n-#Tue Dec 18 01:35:52 CET 2007\n+#Sun Feb 03 03:16:45 CET 2008\n eclipse.preferences.version=1\n org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled\n org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5\n@@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\n org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning\n-org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning\n org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error\n org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore\n org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error\n-- \n1.5.4.rc4.25.g81cc\n\n"},{"id":"67254","messageId":"47A61A30.3000904@intelinet.com.br","threadId":"11821","inReplyTo":"200802030201.10971.robin.rosenberg@dewire.com","subject":"Re: [EGIT PATCH] Comment private modifier to improve performace.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-02-03T19:46:56Z","receivedAt":"2008-02-03T19:46:56Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"Robin Rosenberg escreveu:\n>\n> I'm not fully convinced this is the right way after all. Good\n> performance is obviously good, but so is good encapsulation. \n> I've sometimes tried changing things like this even in pieces\n> of code that I really thought it should matter, but not been able\n> to measure any real improvemen even with performance measurment tools.\n>\n> Obviously seeing that warning is annoying so maybe we should just set it to\n> ignore or exclude it from the project settings (if that is possible). The\n> only project where I think it might make a difference is the jgit part because\n> that is where we optimize and that is where I experimented with visibility\n> changes. In the Eclipse part we need to encapsulate more, partly because \n> Eclipse is less understood by the current authors than Java in general. \n> Encapsulation means encapsulating bad coding and bad design that comes\n> from lack of understanding of the framework we are working within.\n>\n>   \n\nOk, so some more points for your consideration:\n\n. I saw this /* private */ notation on eclipse code and found it \ninteresting.\n\n. I won't bother measuaring any single case to make sure it is not \nimpacting performance under some circunstance, so resolving those \nwarnings puts me in the safe area. On the other hand, I think it is a \nlot easier to tell if a patch is breaking encapsulation in a bad way \njust by reviewing it, which is something that is already done. \nEspecially if it has the private modifier commented out. Someone can \neven do a script to uncomment them and verify that it still builds \nwithout errors.\n\n. The ui part isn't supposed to be reused by other projects, so I think \nencapsulation there is less important than for jgit. But even so, the \ndefault modifier (or package-private) is good enough for encapsulation. \nOther projects shouldn't write code in the the same packages from jgit, \nif they do so they know that they are using internal things and they can \nrun into problems in the future.\n\nThat said, I'm ok with your patch too. I think the important is to \nchoose one so we stop mixing things, for consistency's sake.\n\n[]s,\nRoger.\n"},{"id":"67255","messageId":"47A61E17.7060303@intelinet.com.br","threadId":"11821","inReplyTo":"200802030326.40446.robin.rosenberg@dewire.com","subject":"Re: [EGIT PATCH] Comment private modifier to improve performace.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-02-03T20:03:35Z","receivedAt":"2008-02-03T20:03:35Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"With the else warnings patch I'm ok.\n\nAbout the discouraged access, I read those warnings as: we are using \nmethods that are not part of the eclipse public API and they can change \nin the future. Not depending on internal eclipse API will make egit less \nlikely to break with a future eclipse version, which sounds like a good \nthing to me. So, I would keep those.\n\n[]s,\nRoger.\n\n--\nRobin Rosenberg escreveu:\n> We could drop these settings from the projects too. \n>\n> -- robin\n>   \n> ------------------------------------------------------------------------\n>\n> From a1aed72a122a05d01ed57db5d51b45debeb247b7 Mon Sep 17 00:00:00 2001\n> From: Robin Rosenberg <robin.rosenberg@dewire.com>\n> Date: Sun, 3 Feb 2008 03:13:44 +0100\n> Subject: [PATCH] Make it possible to ignore warnings about discouraged access\n>\n> By removing the setting from the project the workspace settings\n> will be applied (default: Warning)\n>\n> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n> ---\n>  .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n>  .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n>  .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n>  .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n>  .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n>  5 files changed, 0 insertions(+), 5 deletions(-)\n>\n> diff --git a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n> index 7a0fbe4..1c978ca 100644\n> --- a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n> +++ b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n> @@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning\n>  org.eclipse.jdt.core.compiler.problem.deprecation=warning\n>  org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled\n>  org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled\n> -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning\n>  org.eclipse.jdt.core.compiler.problem.emptyStatement=warning\n>  org.eclipse.jdt.core.compiler.problem.enumIdentifier=error\n>  org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning\n> diff --git a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n> index bcde160..2afc050 100644\n> --- a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n> +++ b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n> @@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning\n>  org.eclipse.jdt.core.compiler.problem.deprecation=warning\n>  org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled\n>  org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled\n> -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning\n>  org.eclipse.jdt.core.compiler.problem.emptyStatement=warning\n>  org.eclipse.jdt.core.compiler.problem.enumIdentifier=error\n>  org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning\n> diff --git a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n> index 0a89f52..0da92c7 100644\n> --- a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n> +++ b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n> @@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning\n>  org.eclipse.jdt.core.compiler.problem.deprecation=warning\n>  org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled\n>  org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled\n> -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning\n>  org.eclipse.jdt.core.compiler.problem.emptyStatement=warning\n>  org.eclipse.jdt.core.compiler.problem.enumIdentifier=error\n>  org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning\n> diff --git a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n> index c203c20..9adf651 100644\n> --- a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n> +++ b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n> @@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning\n>  org.eclipse.jdt.core.compiler.problem.deprecation=warning\n>  org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled\n>  org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled\n> -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning\n>  org.eclipse.jdt.core.compiler.problem.emptyStatement=warning\n>  org.eclipse.jdt.core.compiler.problem.enumIdentifier=error\n>  org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning\n> diff --git a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n> index b0c694c..faecf76 100644\n> --- a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n> +++ b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n> @@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning\n>  org.eclipse.jdt.core.compiler.problem.deprecation=warning\n>  org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled\n>  org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled\n> -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning\n>  org.eclipse.jdt.core.compiler.problem.emptyStatement=warning\n>  org.eclipse.jdt.core.compiler.problem.enumIdentifier=error\n>  org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning\n>   \n> ------------------------------------------------------------------------\n>\n> From e9f312599eb5941a7bf1acd70c6f0ac9fb1ea889 Mon Sep 17 00:00:00 2001\n> From: Robin Rosenberg <robin.rosenberg@dewire.com>\n> Date: Sun, 3 Feb 2008 03:19:09 +0100\n> Subject: [PATCH] Drop warnings about unnecessary else\n>\n> Use workspace setting, default ignore.\n>\n> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n> ---\n>  .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n>  .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n>  .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n>  .../.settings/org.eclipse.jdt.core.prefs           |    1 -\n>  .../.settings/org.eclipse.jdt.core.prefs           |    3 +--\n>  5 files changed, 1 insertions(+), 6 deletions(-)\n>\n> diff --git a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n> index 1c978ca..7279d81 100644\n> --- a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n> +++ b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs\n> @@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n>  org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n>  org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\n>  org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning\n> -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning\n>  org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error\n>  org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore\n>  org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error\n> diff --git a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n> index 2afc050..2d94530 100644\n> --- a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n> +++ b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs\n> @@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n>  org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n>  org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\n>  org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning\n> -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning\n>  org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error\n>  org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore\n>  org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error\n> diff --git a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n> index 0da92c7..ff09222 100644\n> --- a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n> +++ b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs\n> @@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n>  org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n>  org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\n>  org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning\n> -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning\n>  org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error\n>  org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore\n>  org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error\n> diff --git a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n> index 9adf651..b93093f 100644\n> --- a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n> +++ b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs\n> @@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n>  org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n>  org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\n>  org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning\n> -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning\n>  org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error\n>  org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore\n>  org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error\n> diff --git a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n> index faecf76..4a5d15f 100644\n> --- a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n> +++ b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs\n> @@ -1,4 +1,4 @@\n> -#Tue Dec 18 01:35:52 CET 2007\n> +#Sun Feb 03 03:16:45 CET 2008\n>  eclipse.preferences.version=1\n>  org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled\n>  org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5\n> @@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning\n>  org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning\n>  org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning\n>  org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning\n> -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning\n>  org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error\n>  org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore\n>  org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error\n>   \n"},{"id":"67267","messageId":"200802032314.34005.robin.rosenberg@dewire.com","threadId":"11821","inReplyTo":"47A61E17.7060303@intelinet.com.br","subject":"Re: [EGIT PATCH] Comment private modifier to improve performace.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2008-02-03T22:14:32Z","receivedAt":"2008-02-03T22:14:32Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"söndagen den 3 februari 2008 skrev Roger C. Soares:\n> With the else warnings patch I'm ok.\n> \n> About the discouraged access, I read those warnings as: we are using \n> methods that are not part of the eclipse public API and they can change \n> in the future. Not depending on internal eclipse API will make egit less \n> likely to break with a future eclipse version, which sounds like a good \n> thing to me. So, I would keep those.\n\nThe thing with that one is that by default the warning is on, so removing\nthe setting doesn't remvoe the warning unless one disables it at the workspace\nlevel. I'll hold it back for the moment anyway and push the \"else\" and \"synthetic\"\npatches. Thanks for your opinions on the subject matter.\n\n-- robin\n"},{"id":"67269","messageId":"200802032325.47844.robin.rosenberg@dewire.com","threadId":"11821","inReplyTo":"47A61A30.3000904@intelinet.com.br","subject":"Re: [EGIT PATCH] Comment private modifier to improve performace.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2008-02-03T22:25:47Z","receivedAt":"2008-02-03T22:25:47Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"söndagen den 3 februari 2008 skrev Roger C. Soares:\n> Ok, so some more points for your consideration:\n> \n> . I saw this /* private */ notation on eclipse code and found it \n> interesting.\nIt is.\n\n> . I won't bother measuaring any single case to make sure it is not \n> impacting performance under some circunstance, so resolving those \n> warnings puts me in the safe area. On the other hand, I think it is a \n> lot easier to tell if a patch is breaking encapsulation in a bad way \n> just by reviewing it, which is something that is already done. \nWe do not have a large number of people reviewing our code at this stage,\nso I would not trust that at the moment.\n\n> Especially if it has the private modifier commented out. Someone can \n> even do a script to uncomment them and verify that it still builds \n> without errors.\nThere is more to reviewing than just looking at the diffs.\n\n> . The ui part isn't supposed to be reused by other projects, so I think \n> encapsulation there is less important than for jgit. But even so, the \n> default modifier (or package-private) is good enough for encapsulation. \n> Other projects shouldn't write code in the the same packages from jgit, \n> if they do so they know that they are using internal things and they can \n> run into problems in the future.\n\nI'm thinking more about internal encapsulation between the classes within the \nproject. Many of the classes in the ui (and jgit) packages have little in \ncommon other than that they contribute to the same overall goal (an Eclipse \nplugin). I guess that is what happens when things get build a small patch at \na time. Obviously we could have more packages, but that might make things \nworse by forcing us to have more public methods and having a lot of one and \ntwo class packages feels wrong too (though it actually may be right). I don't \nthink I'll look at that right now though.\n\n-- robin\n"}]}