{"thread":{"id":"11777","subject":"[PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain","startedAt":"2008-01-29T02:14:00Z","lastAt":"2008-01-30T05:10:01Z","messageCount":9,"participants":["Yasushi SHOJI","Ismail Dönmez","Junio C Hamano","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"66788","messageId":"87ve5dicih.wl@mail2.atmark-techno.com","threadId":"11777","inReplyTo":null,"subject":"[PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain","fromName":"Yasushi SHOJI","fromEmail":"yashi@atmark-techno.com","sentAt":"2008-01-29T02:14:00Z","receivedAt":"2008-01-29T02:14:00Z","isPatch":true,"sender":{"key":"yashi@atmark-techno.com","avatar":"https://gravatar.com/avatar/4817e8703ac4379935834d87453faa9d0c94b9dc19d83fcc54c67875eb133e59?d=mp&s=160"},"body":"commitdiff with raw, or plain format if you are reading the code,\ndoesn't convert any word from perl internal to utf8, which is set to\ncharset in http header.  this cause a problem when commit includes non\nascii code.\n\nhere is a few example in the git tree:\n\nhttp://git.kernel.org/?p=git/git.git;a=commitdiff_plain;h=6ba78238a824282816944550edc4297dd2808a72\nhttp://git.kernel.org/?p=git/git.git;a=commitdiff_plain;h=e360bebf713b6b03768c62de8b94ddf9350b0953\nhttp://git.kernel.org/?p=git/git.git;a=commitdiff_plain;h=9459aa77a032621a29d53605542844641cca843a\n\nThis patch effectively revert the commitdiff plain part of the commit\n\n\t59b9f61a3f76762dc975e99cc05335a3b97ad1f9\n\nwhich converted from print to here-doc. but it doesn't\nexplain why in the commit log.\n---\n gitweb/gitweb.perl |   12 ++++++------\n 1 files changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 6256641..5d9ac1d 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -5048,16 +5048,16 @@ sub git_commitdiff {\n \t\t\t-expires => $expires,\n \t\t\t-content_disposition => 'inline; filename=\"' . \"$filename\" . '\"');\n \t\tmy %ad = parse_date($co{'author_epoch'}, $co{'author_tz'});\n-\t\tprint <<TEXT;\n-From: $co{'author'}\n-Date: $ad{'rfc2822'} ($ad{'tz_local'})\n-Subject: $co{'title'}\n-TEXT\n+\t\tprint \"From: \" . to_utf8($co{'author'}) . \"\\n\";\n+\t\tprint \"Date: \" . to_utf8($ad{'rfc2822'}) . \" \"\n+\t\t\t       . to_utf8($ad{'tz_local'}) . \"\\n\";\n+\t\tprint \"Subject: \" . to_utf8($co{'title'}) . \"\\n\";\n+\n \t\tprint \"X-Git-Tag: $tagname\\n\" if $tagname;\n \t\tprint \"X-Git-Url: \" . $cgi->self_url() . \"\\n\\n\";\n \n \t\tforeach my $line (@{$co{'comment'}}) {\n-\t\t\tprint \"$line\\n\";\n+\t\t\tprint to_utf8($line) . \"\\n\";\n \t\t}\n \t\tprint \"---\\n\\n\";\n \t}\n-- \n1.5.4.rc5.1.g0d200\n"},{"id":"66795","messageId":"200801290511.31025.ismail@pardus.org.tr","threadId":"11777","inReplyTo":"87ve5dicih.wl@mail2.atmark-techno.com","subject":"Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain","fromName":"Ismail Dönmez","fromEmail":"ismail@pardus.org.tr","sentAt":"2008-01-29T03:11:30Z","receivedAt":"2008-01-29T03:11:30Z","isPatch":true,"sender":{"key":"ismail@pardus.org.tr","avatar":null},"body":"At Tuesday 29 January 2008 around 04:14:00 Yasushi SHOJI wrote:\n> commitdiff with raw, or plain format if you are reading the code,\n> doesn't convert any word from perl internal to utf8, which is set to\n> charset in http header.  this cause a problem when commit includes non\n> ascii code.\n>\n> here is a few example in the git tree:\n>\n> http://git.kernel.org/?p=git/git.git;a=commitdiff_plain;h=6ba78238a82428281\n>6944550edc4297dd2808a72\n> http://git.kernel.org/?p=git/git.git;a=commitdiff_plain;h=e360bebf713b6b037\n>68c62de8b94ddf9350b0953\n> http://git.kernel.org/?p=git/git.git;a=commitdiff_plain;h=9459aa77a032621a2\n>9d53605542844641cca843a\n>\n> This patch effectively revert the commitdiff plain part of the commit\n>\n> \t59b9f61a3f76762dc975e99cc05335a3b97ad1f9\n>\n> which converted from print to here-doc. but it doesn't\n> explain why in the commit log.\n> ---\n>  gitweb/gitweb.perl |   12 ++++++------\n>  1 files changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 6256641..5d9ac1d 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -5048,16 +5048,16 @@ sub git_commitdiff {\n>  \t\t\t-expires => $expires,\n>  \t\t\t-content_disposition => 'inline; filename=\"' . \"$filename\" . '\"');\n>  \t\tmy %ad = parse_date($co{'author_epoch'}, $co{'author_tz'});\n> -\t\tprint <<TEXT;\n> -From: $co{'author'}\n> -Date: $ad{'rfc2822'} ($ad{'tz_local'})\n> -Subject: $co{'title'}\n> -TEXT\n> +\t\tprint \"From: \" . to_utf8($co{'author'}) . \"\\n\";\n> +\t\tprint \"Date: \" . to_utf8($ad{'rfc2822'}) . \" \"\n> +\t\t\t       . to_utf8($ad{'tz_local'}) . \"\\n\";\n> +\t\tprint \"Subject: \" . to_utf8($co{'title'}) . \"\\n\";\n> +\n>  \t\tprint \"X-Git-Tag: $tagname\\n\" if $tagname;\n>  \t\tprint \"X-Git-Url: \" . $cgi->self_url() . \"\\n\\n\";\n>\n>  \t\tforeach my $line (@{$co{'comment'}}) {\n> -\t\t\tprint \"$line\\n\";\n> +\t\t\tprint to_utf8($line) . \"\\n\";\n>  \t\t}\n>  \t\tprint \"---\\n\\n\";\n>  \t}\n\nNice find, looks correct. You could print \"Date\" on one line instead of two, \nbut FWIW\n\nAcked-by: İsmail Dönmez <ismail@pardus.org.tr>\n\n-- \nNever learn by your mistakes, if you do you may never dare to try again.\n"},{"id":"66806","messageId":"7vir1dqjg0.fsf@gitster.siamese.dyndns.org","threadId":"11777","inReplyTo":"87ve5dicih.wl@mail2.atmark-techno.com","subject":"Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-01-29T05:39:27Z","receivedAt":"2008-01-29T05:39:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Yasushi SHOJI <yashi@atmark-techno.com> writes:\n\n> This patch effectively revert the commitdiff plain part of the commit\n>\n> \t59b9f61a3f76762dc975e99cc05335a3b97ad1f9\n>\n> which converted from print to here-doc. but it doesn't\n> explain why in the commit log.\n\nI think the patch makes sense but the above is misleading.  Read\nit again.\n\nDoesn't it sound like you are accusing that 59b9f61a introduced\na regression when it converted existsing \"print utf8()\" to\n\"print <<here-doc\" without saying that is what it is doing?\n\nI think the change in that commit was meant for writability (I\ndo not necessarily think here-doc is good for readability), and\nI personally do not care---Perl is ugly to read either way ;-)\n"},{"id":"66807","messageId":"87fxwhi3qj.wl@mail2.atmark-techno.com","threadId":"11777","inReplyTo":"7vir1dqjg0.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain","fromName":"Yasushi SHOJI","fromEmail":"yashi@atmark-techno.com","sentAt":"2008-01-29T05:45:56Z","receivedAt":"2008-01-29T05:45:56Z","isPatch":true,"sender":{"key":"yashi@atmark-techno.com","avatar":"https://gravatar.com/avatar/4817e8703ac4379935834d87453faa9d0c94b9dc19d83fcc54c67875eb133e59?d=mp&s=160"},"body":"At Mon, 28 Jan 2008 21:39:27 -0800,\nJunio C Hamano wrote:\n> \n> Yasushi SHOJI <yashi@atmark-techno.com> writes:\n> \n> > This patch effectively revert the commitdiff plain part of the commit\n> >\n> > \t59b9f61a3f76762dc975e99cc05335a3b97ad1f9\n> >\n> > which converted from print to here-doc. but it doesn't\n> > explain why in the commit log.\n> \n> I think the patch makes sense but the above is misleading.  Read\n> it again.\n> \n> Doesn't it sound like you are accusing that 59b9f61a introduced\n> a regression when it converted existsing \"print utf8()\" to\n> \"print <<here-doc\" without saying that is what it is doing?\n\nsorry about my stupid english.  What I meant was that because commit\nlog doesn't say _why_ it changed to here-doc, I couldn't be sure it\nwas ok to overwrite the change introduced by the commit 59b9f61a3.\n\nIOW, I was tring to ask, \"is it ok to revert back to print?\"\n-- \n         yashi\n"},{"id":"66808","messageId":"7vejc1qium.fsf@gitster.siamese.dyndns.org","threadId":"11777","inReplyTo":"87fxwhi3qj.wl@mail2.atmark-techno.com","subject":"Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-01-29T05:52:17Z","receivedAt":"2008-01-29T05:52:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Yasushi SHOJI <yashi@atmark-techno.com> writes:\n\n> At Mon, 28 Jan 2008 21:39:27 -0800,\n> Junio C Hamano wrote:\n>> \n>> Yasushi SHOJI <yashi@atmark-techno.com> writes:\n>> \n>> > This patch effectively revert the commitdiff plain part of the commit\n>> >\n>> > \t59b9f61a3f76762dc975e99cc05335a3b97ad1f9\n>> >\n>> > which converted from print to here-doc. but it doesn't\n>> > explain why in the commit log.\n>> \n>> I think the patch makes sense but the above is misleading.  Read\n>> it again.\n>> \n>> Doesn't it sound like you are accusing that 59b9f61a introduced\n>> a regression when it converted existsing \"print utf8()\" to\n>> \"print <<here-doc\" without saying that is what it is doing?\n>\n> sorry about my stupid english.  What I meant was that because commit\n> log doesn't say _why_ it changed to here-doc, I couldn't be sure it\n> was ok to overwrite the change introduced by the commit 59b9f61a3.\n>\n> IOW, I was tring to ask, \"is it ok to revert back to print?\"\n\nSure.  Can I forge your Sign-off?\n"},{"id":"66832","messageId":"m3prvk99c8.fsf@localhost.localdomain","threadId":"11777","inReplyTo":"87ve5dicih.wl@mail2.atmark-techno.com","subject":"Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-01-29T11:09:50Z","receivedAt":"2008-01-29T11:09:50Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Yasushi SHOJI <yashi@atmark-techno.com> writes:\n\n> commitdiff with raw, or plain format if you are reading the code,\n> doesn't convert any word from perl internal to utf8, which is set to\n> charset in http header.  this cause a problem when commit includes non\n> ascii code.\n\nNice catch. Thanks.\n \n> here is a few example in the git tree:\n> \n> http://git.kernel.org/?p=git/git.git;a=commitdiff_plain;h=6ba78238a824282816944550edc4297dd2808a72\n> http://git.kernel.org/?p=git/git.git;a=commitdiff_plain;h=e360bebf713b6b03768c62de8b94ddf9350b0953\n> http://git.kernel.org/?p=git/git.git;a=commitdiff_plain;h=9459aa77a032621a29d53605542844641cca843a\n\n...but commit message could be improved :-)\n\nFor example:\n\n-- >8 --\ngitweb: Convert generated contents to utf8 in commitdiff_plain\n\nIf the commit message, or commit author contains non-ascii, it must be\nconverted from Perl internal representation to utf-8, to follow what\ngot declared in HTTP header.  Use to_utf8() to do the conversion.\n\nThis necessarily replaces here-doc with \"print\" statements.\n\nSigned-off-by: Yasushi SHOJI <yashi@atmark-techno.com>\nAcked-by: İsmail Dönmez <ismail@pardus.org.tr>\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n-- >8 --\n\n> This patch effectively revert the commitdiff plain part of the commit\n> \n> \t59b9f61a3f76762dc975e99cc05335a3b97ad1f9\n> \n> which converted from print to here-doc. but it doesn't\n> explain why in the commit log.\n\nSorry about that.\n\nIMVHO using here-doc for longer sequence of output lines is more\nreadable than long \"print\" command, or sequence of print's. But of\ncourse if you have to parse / transform some parts of output it is\nsimply not possible.\n\n> ---\n>  gitweb/gitweb.perl |   12 ++++++------\n>  1 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 6256641..5d9ac1d 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -5048,16 +5048,16 @@ sub git_commitdiff {\n>  \t\t\t-expires => $expires,\n>  \t\t\t-content_disposition => 'inline; filename=\"' . \"$filename\" . '\"');\n>  \t\tmy %ad = parse_date($co{'author_epoch'}, $co{'author_tz'});\n> -\t\tprint <<TEXT;\n> -From: $co{'author'}\n> -Date: $ad{'rfc2822'} ($ad{'tz_local'})\n> -Subject: $co{'title'}\n> -TEXT\n> +\t\tprint \"From: \" . to_utf8($co{'author'}) . \"\\n\";\n> +\t\tprint \"Date: \" . to_utf8($ad{'rfc2822'}) . \" \"\n> +\t\t\t       . to_utf8($ad{'tz_local'}) . \"\\n\";\n\nI think that date, or at least timezone would never have characters\noutside US-ASCII, so to_uft8 is not really necessary, but I guess that\nit is better to be safe than sorry.\n\n> +\t\tprint \"Subject: \" . to_utf8($co{'title'}) . \"\\n\";\n> +\n>  \t\tprint \"X-Git-Tag: $tagname\\n\" if $tagname;\n>  \t\tprint \"X-Git-Url: \" . $cgi->self_url() . \"\\n\\n\";\n>  \n>  \t\tforeach my $line (@{$co{'comment'}}) {\n> -\t\t\tprint \"$line\\n\";\n> +\t\t\tprint to_utf8($line) . \"\\n\";\n>  \t\t}\n>  \t\tprint \"---\\n\\n\";\n>  \t}\n\nBy the way, I guess that with new git we could just use --pretty=email\noption to git-log / git-rev-list, and add X-Git-Tag and X-Git-Url at\nthe beginning (or insert it after headers).  Perhaps also generate\ndiff with the same diff command... but I think this improvement is to\nbe done _after_ release.\n\nFor what is worth:\n\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"66835","messageId":"87ejc0j08t.wl@mail2.atmark-techno.com","threadId":"11777","inReplyTo":"7vejc1qium.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain","fromName":"Yasushi SHOJI","fromEmail":"yashi@atmark-techno.com","sentAt":"2008-01-29T12:16:02Z","receivedAt":"2008-01-29T12:16:02Z","isPatch":true,"sender":{"key":"yashi@atmark-techno.com","avatar":"https://gravatar.com/avatar/4817e8703ac4379935834d87453faa9d0c94b9dc19d83fcc54c67875eb133e59?d=mp&s=160"},"body":"At Mon, 28 Jan 2008 21:52:17 -0800,\nJunio C Hamano wrote:\n> \n> Yasushi SHOJI <yashi@atmark-techno.com> writes:\n> \n> > At Mon, 28 Jan 2008 21:39:27 -0800,\n> > Junio C Hamano wrote:\n> >> \n> >> Yasushi SHOJI <yashi@atmark-techno.com> writes:\n> >> \n> >> > This patch effectively revert the commitdiff plain part of the commit\n> >> >\n> >> > \t59b9f61a3f76762dc975e99cc05335a3b97ad1f9\n> >> >\n> >> > which converted from print to here-doc. but it doesn't\n> >> > explain why in the commit log.\n> >> \n> >> I think the patch makes sense but the above is misleading.  Read\n> >> it again.\n> >> \n> >> Doesn't it sound like you are accusing that 59b9f61a introduced\n> >> a regression when it converted existsing \"print utf8()\" to\n> >> \"print <<here-doc\" without saying that is what it is doing?\n> >\n> > sorry about my stupid english.  What I meant was that because commit\n> > log doesn't say _why_ it changed to here-doc, I couldn't be sure it\n> > was ok to overwrite the change introduced by the commit 59b9f61a3.\n> >\n> > IOW, I was tring to ask, \"is it ok to revert back to print?\"\n> \n> Sure.  Can I forge your Sign-off?\n\nFrom 127a6abaf23991394b3b2c5455c2522f9da1e8ac Mon Sep 17 00:00:00 2001\nFrom: Yasushi SHOJI <yashi@wat.atmark-techno.com>\nDate: Tue, 29 Jan 2008 20:48:33 +0900\nSubject: [PATCH] gitweb: Convert generated contents to utf8 in commitdiff_plain\nMIME-Version: 1.0\nContent-Type: text/plain; charset=utf-8\nContent-Transfer-Encoding: 8bit\n\nIf the commit message, or commit author contains non-ascii, it must be\nconverted from Perl internal representation to utf-8, to follow what\ngot declared in HTTP header.  Use to_utf8() to do the conversion.\n\nThis necessarily replaces here-doc with \"print\" statements.\n\nSigned-off-by: Yasushi SHOJI <yashi@atmark-techno.com>\nAcked-by: İsmail Dönmez <ismail@pardus.org.tr>\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n---\n\nJakub, thanks for much better commit log.  I just copy & pasted to new\ncommit.\n\nOne thing I've changed from the last patch was, as Jakub and Ismail\npointed out, the Date line.  I've:\n\n - removed to_utf8(), and\n - made it one line\n\nI also noticed that I've removed parentheses from the line by\naccident, so I put them back.\n\nJunio, please use this if you are ok.\n\nThanks,\n\n\n\n gitweb/gitweb.perl |   11 +++++------\n 1 files changed, 5 insertions(+), 6 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 6256641..80e3d0a 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -5048,16 +5048,15 @@ sub git_commitdiff {\n \t\t\t-expires => $expires,\n \t\t\t-content_disposition => 'inline; filename=\"' . \"$filename\" . '\"');\n \t\tmy %ad = parse_date($co{'author_epoch'}, $co{'author_tz'});\n-\t\tprint <<TEXT;\n-From: $co{'author'}\n-Date: $ad{'rfc2822'} ($ad{'tz_local'})\n-Subject: $co{'title'}\n-TEXT\n+\t\tprint \"From: \" . to_utf8($co{'author'}) . \"\\n\";\n+\t\tprint \"Date: $ad{'rfc2822'} ($ad{'tz_local'})\\n\";\n+\t\tprint \"Subject: \" . to_utf8($co{'title'}) . \"\\n\";\n+\n \t\tprint \"X-Git-Tag: $tagname\\n\" if $tagname;\n \t\tprint \"X-Git-Url: \" . $cgi->self_url() . \"\\n\\n\";\n \n \t\tforeach my $line (@{$co{'comment'}}) {\n-\t\t\tprint \"$line\\n\";\n+\t\t\tprint to_utf8($line) . \"\\n\";\n \t\t}\n \t\tprint \"---\\n\\n\";\n \t}\n-- \n1.5.4.rc5.1.g0d200\n"},{"id":"66834","messageId":"200801291340.22421.jnareb@gmail.com","threadId":"11777","inReplyTo":"87ejc0j08t.wl@mail2.atmark-techno.com","subject":"Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-01-29T12:40:21Z","receivedAt":"2008-01-29T12:40:21Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Yasushi SHOJI wrote:\n\n> Junio, please use this if you are ok.\n\nWhile we are now in feature freeze, I think this can be considered\na bugfix.\n\n-- \nJakub Narebski\nPoland\n"},{"id":"66880","messageId":"7vejbzkifq.fsf@gitster.siamese.dyndns.org","threadId":"11777","inReplyTo":"87ejc0j08t.wl@mail2.atmark-techno.com","subject":"Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-01-30T05:10:01Z","receivedAt":"2008-01-30T05:10:01Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Yasushi SHOJI <yashi@atmark-techno.com> writes:\n\n>> > sorry about my stupid english.  What I meant was that because commi=\n> t\n>> > log doesn't say _why_ it changed to here-doc, I couldn't be sure it\n>> > was ok to overwrite the change introduced by the commit 59b9f61a3.\n>> >\n>> > IOW, I was tring to ask, \"is it ok to revert back to print?\"\n>>=20\n>> Sure.  Can I forge your Sign-off?\n>\n> =46rom 127a6abaf23991394b3b2c5455c2522f9da1e8ac Mon Sep 17 00:00:00 200=\n> 1\n> =46rom: Yasushi SHOJI <yashi@wat.atmark-techno.com>\n> Date: Tue, 29 Jan 2008 20:48:33 +0900\n> Subject: [PATCH] gitweb: Convert generated contents to utf8 in commitdi=\n> ff_plain\n> MIME-Version: 1.0\n> Content-Type: text/plain; charset=3Dutf-8\n> Content-Transfer-Encoding: 8bit\n\nPlease don't do this.  MIME headers do not belong to the body of\nthe message.\n\n>\n> If the commit message, or commit author contains non-ascii, it must be\n> converted from Perl internal representation to utf-8, to follow what\n> got declared in HTTP header.  Use to_utf8() to do the conversion.\n>\n> This necessarily replaces here-doc with \"print\" statements.\n>\n> Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com>\n> Acked-by: =C4=B0smail D=C3=B6nmez <ismail@pardus.org.tr>\n> Acked-by: Jakub Narebski <jnareb@gmail.com>\n\nWill try to apply by hand; if you do not hear from me about this\npatch again, no need for resend.\n\nThanks.\n"}]}