{"thread":{"id":"11732","subject":"stgit: per branch cover letters","startedAt":"2008-01-25T14:57:50Z","lastAt":"2008-01-25T17:03:10Z","messageCount":3,"participants":["Jon Smirl","Karl Hasselström"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"66569","messageId":"9e4733910801250657p2d7fdc66o8a631d7587125949@mail.gmail.com","threadId":"11732","inReplyTo":null,"subject":"stgit: per branch cover letters","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2008-01-25T14:57:50Z","receivedAt":"2008-01-25T14:57:50Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"It would be convenient to have per branch cover letters that are\nstored by stg and get automatically applied when a patch set is\nmailed. Use 'stg edit' to alter them. The first time you email a\nseries you would get an editor to write the cover letter if you hadn't\nalready done it. You could track the \"to=\" this way also.\n\nAnother useful feature would be a config option that says something\nlike \"prompt for new version\" when mailed. Now each time you mail the\nseries it throws you into the cover page editor with an incremented\npatch version. You can just quit out of the editor if you don't want\nto increment the version.\n\nI didn't know I wanted features like this until I made a patch that\nhas gone through 25 versions.\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"66576","messageId":"20080125164633.GA12321@diana.vm.bytemark.co.uk","threadId":"11732","inReplyTo":"9e4733910801250657p2d7fdc66o8a631d7587125949@mail.gmail.com","subject":"Re: stgit: per branch cover letters","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2008-01-25T16:46:33Z","receivedAt":"2008-01-25T16:46:33Z","isPatch":false,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2008-01-25 09:57:50 -0500, Jon Smirl wrote:\n\n> It would be convenient to have per branch cover letters that are\n> stored by stg and get automatically applied when a patch set is\n> mailed. Use 'stg edit' to alter them. The first time you email a\n> series you would get an editor to write the cover letter if you\n> hadn't already done it. You could track the \"to=\" this way also.\n\nI don't think we need to get quite that fancy. Wouldn't it suffice to\nhave a --cover-file= option to stg mail, and if both\n--cover-file and --edit-cover were given, update that file with new\ndiffstat etc?\n\nAnd per-branch config options if you want to set these permanently, of\ncourse.\n\n> Another useful feature would be a config option that says something\n> like \"prompt for new version\" when mailed. Now each time you mail\n> the series it throws you into the cover page editor with an\n> incremented patch version. You can just quit out of the editor if\n> you don't want to increment the version.\n\nPatches without cover letters can also have versions, so I don't think\nassociating versions with cover letters is a splendid idea, but I get\nyour point.\n\nI guess a solution much like the one for cover letters would work\nhere. A separate file, and command-line and config options to point to\nit.\n\n> I didn't know I wanted features like this until I made a patch that\n> has gone through 25 versions.\n\nYour feedback is much appreciated. Keep at it!\n\n-- \nKarl Hasselström, kha@treskal.com\n www.treskal.com/kalle\n"},{"id":"66577","messageId":"9e4733910801250903qcb53430p522b36197443a030@mail.gmail.com","threadId":"11732","inReplyTo":"20080125164633.GA12321@diana.vm.bytemark.co.uk","subject":"Re: stgit: per branch cover letters","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2008-01-25T17:03:10Z","receivedAt":"2008-01-25T17:03:10Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"On 1/25/08, Karl Hasselström wrote:\n> On 2008-01-25 09:57:50 -0500, Jon Smirl wrote:\n>\n> > It would be convenient to have per branch cover letters that are\n> > stored by stg and get automatically applied when a patch set is\n> > mailed. Use 'stg edit' to alter them. The first time you email a\n> > series you would get an editor to write the cover letter if you\n> > hadn't already done it. You could track the \"to=\" this way also.\n>\n> I don't think we need to get quite that fancy. Wouldn't it suffice to\n> have a --cover-file= option to stg mail, and if both\n> --cover-file and --edit-cover were given, update that file with new\n> diffstat etc?\n\nI have five patch sets I'm currently juggling. It would be a lot more\nconvenient if stg remembered which cover letter went with the patch\nset, the recipients for the mail and the current patch version/prefix.\nIn my tree each patch set is in it's own branch.\n\nI can edit the config file to change these if need, I don't need a\nfancy editor interface.\n\n\n>\n> And per-branch config options if you want to set these permanently, of\n> course.\n>\n> > Another useful feature would be a config option that says something\n> > like \"prompt for new version\" when mailed. Now each time you mail\n> > the series it throws you into the cover page editor with an\n> > incremented patch version. You can just quit out of the editor if\n> > you don't want to increment the version.\n>\n> Patches without cover letters can also have versions, so I don't think\n> associating versions with cover letters is a splendid idea, but I get\n> your point.\n>\n> I guess a solution much like the one for cover letters would work\n> here. A separate file, and command-line and config options to point to\n> it.\n>\n> > I didn't know I wanted features like this until I made a patch that\n> > has gone through 25 versions.\n>\n> Your feedback is much appreciated. Keep at it!\n>\n> --\n> Karl Hasselström, kha@treskal.com\n> www.treskal.com/kalle\n>\n\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"}]}