{"thread":{"id":"11721","subject":"[PATCH] HP-UX traditionally has no sys/select.h","startedAt":"2008-01-24T17:53:00Z","lastAt":"2008-01-24T19:39:42Z","messageCount":5,"participants":["Robert Schiele","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"66494","messageId":"20080124175300.GI30676@schiele.dyndns.org","threadId":"11721","inReplyTo":null,"subject":"[PATCH] HP-UX traditionally has no sys/select.h","fromName":"Robert Schiele","fromEmail":"rschiele@gmail.com","sentAt":"2008-01-24T17:53:00Z","receivedAt":"2008-01-24T17:53:00Z","isPatch":true,"sender":{"key":"rschiele@gmail.com","avatar":"https://gravatar.com/avatar/409473567eb2287d5f0157b51f5b703994b347f24f92172e3a0588741c27a492?d=mp&s=160"},"body":"The select stuff is already in sys/time.h on traditional HP-UX\nsystems thus we should not include sys/select.h there because older\nreleases don't have it.\n---\n git-compat-util.h |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex b6ef544..77de915 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -68,7 +68,9 @@\n #include <sys/poll.h>\n #include <sys/socket.h>\n #include <sys/ioctl.h>\n+#ifndef __hpux\n #include <sys/select.h>\n+#endif\n #include <assert.h>\n #include <regex.h>\n #include <netinet/in.h>\n-- \n1.5.2.4\n"},{"id":"66495","messageId":"alpine.LSU.1.00.0801241758130.5731@racer.site","threadId":"11721","inReplyTo":"20080124175300.GI30676@schiele.dyndns.org","subject":"Re: [PATCH] HP-UX traditionally has no sys/select.h","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-01-24T18:03:14Z","receivedAt":"2008-01-24T18:03:14Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 24 Jan 2008, Robert Schiele wrote:\n\n> The select stuff is already in sys/time.h on traditional HP-UX\n> systems thus we should not include sys/select.h there because older\n> releases don't have it.\n\nThank you for your patch.\n\n> diff --git a/git-compat-util.h b/git-compat-util.h\n> index b6ef544..77de915 100644\n> --- a/git-compat-util.h\n> +++ b/git-compat-util.h\n> @@ -68,7 +68,9 @@\n>  #include <sys/poll.h>\n>  #include <sys/socket.h>\n>  #include <sys/ioctl.h>\n> +#ifndef __hpux\n>  #include <sys/select.h>\n> +#endif\n>  #include <assert.h>\n>  #include <regex.h>\n>  #include <netinet/in.h>\n\nWe try to avoid using constructs like this.  Rather, we have a section in \nthe Makefile which sets things like NO_IPV6=YesPlease, \nOLD_ICONV=UnfortunatelyYes, etc.\n\nLater in the Makefile, dependent on this Makefile variable, symbols \nare defined. In the source code, we check for these symbols.\n\nIt is not only a matter of being able to reuse the same symbol for another \nplatform/setup, it is also a nice way of documentation.\n\nIn your case, I suggest NO_SYS_SELECT_H=UnfortunatelyYes.\n\nThanks,\nDscho\n"},{"id":"66504","messageId":"20080124183645.GL30676@schiele.dyndns.org","threadId":"11721","inReplyTo":"alpine.LSU.1.00.0801241758130.5731@racer.site","subject":"Re: [PATCH] HP-UX traditionally has no sys/select.h","fromName":"Robert Schiele","fromEmail":"rschiele@gmail.com","sentAt":"2008-01-24T18:36:45Z","receivedAt":"2008-01-24T18:36:45Z","isPatch":true,"sender":{"key":"rschiele@gmail.com","avatar":"https://gravatar.com/avatar/409473567eb2287d5f0157b51f5b703994b347f24f92172e3a0588741c27a492?d=mp&s=160"},"body":"On Thu, Jan 24, 2008 at 06:03:14PM +0000, Johannes Schindelin wrote:\n> We try to avoid using constructs like this.  Rather, we have a section in \n> the Makefile which sets things like NO_IPV6=YesPlease, \n> OLD_ICONV=UnfortunatelyYes, etc.\n> \n> Later in the Makefile, dependent on this Makefile variable, symbols \n> are defined. In the source code, we check for these symbols.\n> \n> It is not only a matter of being able to reuse the same symbol for another \n> platform/setup, it is also a nice way of documentation.\n> \n> In your case, I suggest NO_SYS_SELECT_H=UnfortunatelyYes.\n\nOk, implemented it that way now and also made HP-UX support in Makefile in a\nseparate patch.\n\nRobert\n\n-- \nRobert Schiele\nDipl.-Wirtsch.informatiker\tmailto:rschiele@gmail.com\n\n\"Quidquid latine dictum sit, altum sonatur.\"\n"},{"id":"66510","messageId":"7vd4rravin.fsf@gitster.siamese.dyndns.org","threadId":"11721","inReplyTo":"20080124175300.GI30676@schiele.dyndns.org","subject":"Re: [PATCH] HP-UX traditionally has no sys/select.h","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-01-24T19:11:44Z","receivedAt":"2008-01-24T19:11:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Robert Schiele <rschiele@gmail.com> writes:\n\n> The select stuff is already in sys/time.h on traditional HP-UX\n> systems thus we should not include sys/select.h there because older\n> releases don't have it.\n> ---\n>  git-compat-util.h |    2 ++\n>  1 files changed, 2 insertions(+), 0 deletions(-)\n>\n> diff --git a/git-compat-util.h b/git-compat-util.h\n> index b6ef544..77de915 100644\n> --- a/git-compat-util.h\n> +++ b/git-compat-util.h\n> @@ -68,7 +68,9 @@\n>  #include <sys/poll.h>\n>  #include <sys/socket.h>\n>  #include <sys/ioctl.h>\n> +#ifndef __hpux\n>  #include <sys/select.h>\n> +#endif\n>  #include <assert.h>\n>  #include <regex.h>\n>  #include <netinet/in.h>\n> -- \n> 1.5.2.4\n\nWe had a thread on this issue mid December.\nDoes this help?\n\n>From 72a41cae180ad57c6f2daa0af9b96e284386dc1b Mon Sep 17 00:00:00 2001\nFrom: Junio C Hamano <gitster@pobox.com>\nDate: Tue, 18 Dec 2007 01:52:07 -0800\nSubject: [PATCH] Do not include <sys/select.h> on pre- POSIX.1-2001 systems\n\nFor previous version of SUS, select(2) would have been declared in\n<sys/time.h>, which is already included.  POSIX.1-2001 moved the\ndeclaration to <sys/select.h>, so check _POSIX_VERSION with 200112L\nand skip inclusion of <sys/select.h> if it is not the case.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n git-compat-util.h |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex b6ef544..fb3b969 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -68,7 +68,9 @@\n #include <sys/poll.h>\n #include <sys/socket.h>\n #include <sys/ioctl.h>\n+#if _POSIX_VERSION >= 200112L\n #include <sys/select.h>\n+#endif\n #include <assert.h>\n #include <regex.h>\n #include <netinet/in.h>\n-- \n1.5.4.rc4.23.gcab31\n"},{"id":"66513","messageId":"20080124193942.GM30676@schiele.dyndns.org","threadId":"11721","inReplyTo":"7vd4rravin.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] HP-UX traditionally has no sys/select.h","fromName":"Robert Schiele","fromEmail":"rschiele@gmail.com","sentAt":"2008-01-24T19:39:42Z","receivedAt":"2008-01-24T19:39:42Z","isPatch":true,"sender":{"key":"rschiele@gmail.com","avatar":"https://gravatar.com/avatar/409473567eb2287d5f0157b51f5b703994b347f24f92172e3a0588741c27a492?d=mp&s=160"},"body":"On Thu, Jan 24, 2008 at 11:11:44AM -0800, Junio C Hamano wrote:\n> We had a thread on this issue mid December.\n> Does this help?\n\nYes, checking for the _POSIX_VERSION is also a working approach.\n\nRobert\n\n-- \nRobert Schiele\nDipl.-Wirtsch.informatiker\tmailto:rschiele@gmail.com\n\n\"Quidquid latine dictum sit, altum sonatur.\"\n"}]}