{"thread":{"id":"11685","subject":"[EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do.","startedAt":"2008-01-20T20:29:01Z","lastAt":"2008-01-21T01:27:36Z","messageCount":3,"participants":["Roger C. Soares","Robin Rosenberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"66046","messageId":"1200860941-6922-1-git-send-email-rogersoares@intelinet.com.br","threadId":"11685","inReplyTo":null,"subject":"[EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-01-20T20:29:01Z","receivedAt":"2008-01-20T20:29:01Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"Signed-off-by: Roger C. Soares <rogersoares@intelinet.com.br>\n---\n .../src/org/spearce/egit/core/GitBlobStorage.java  |    3 ---\n .../src/org/spearce/egit/core/GitStorage.java      |    4 ----\n .../internal/mapping/GitCommitFileRevision.java    |    1 -\n .../src/org/spearce/egit/ui/GitHistoryPage.java    |    9 ---------\n .../internal/decorators/GitResourceDecorator.java  |    7 -------\n .../ui/internal/factories/GitAdapterFactory.java   |    1 -\n .../org/spearce/jgit/lib/TopologicalWalker.java    |    1 -\n .../src/org/spearce/jgit/lib/Walker.java           |    1 -\n 8 files changed, 0 insertions(+), 27 deletions(-)\n\ndiff --git a/org.spearce.egit.core/src/org/spearce/egit/core/GitBlobStorage.java b/org.spearce.egit.core/src/org/spearce/egit/core/GitBlobStorage.java\nindex f7a062c..65bbb5d 100644\n--- a/org.spearce.egit.core/src/org/spearce/egit/core/GitBlobStorage.java\n+++ b/org.spearce.egit.core/src/org/spearce/egit/core/GitBlobStorage.java\n@@ -52,7 +52,6 @@ public class GitBlobStorage implements IStorage {\n \t\t\tString name = repositoryMapping.getRepoRelativePath(resource);\n \t\t\tentry = tree.findBlobMember(name);\n \t\t} catch (IOException e) {\n-\t\t\t// TODO Auto-generated catch block\n \t\t\te.printStackTrace();\n \t\t}\n \t}\n@@ -71,7 +70,6 @@ public class GitBlobStorage implements IStorage {\n \t\t\tthrow new ResourceException(IResourceStatus.FAILED_READ_LOCAL,\n \t\t\t\t\tresource.getFullPath(), \"Could not read file\", e);\n \t\t} catch (IOException e) {\n-\t\t\t// TODO Auto-generated catch block\n \t\t\te.printStackTrace();\n \t\t\tthrow new ResourceException(33, resource.getFullPath(), e\n \t\t\t\t\t.getMessage(), e);\n@@ -87,7 +85,6 @@ public class GitBlobStorage implements IStorage {\n \t}\n \n \tpublic boolean isReadOnly() {\n-\t\t// TODO Auto-generated method stub\n \t\treturn false;\n \t}\n \ndiff --git a/org.spearce.egit.core/src/org/spearce/egit/core/GitStorage.java b/org.spearce.egit.core/src/org/spearce/egit/core/GitStorage.java\nindex f791e31..70b9f1a 100644\n--- a/org.spearce.egit.core/src/org/spearce/egit/core/GitStorage.java\n+++ b/org.spearce.egit.core/src/org/spearce/egit/core/GitStorage.java\n@@ -69,7 +69,6 @@ public class GitStorage implements IStorage {\n \t\t\t\t\tentry = treeEntry.getId();\n \t\t\t}\n \t\t} catch (IOException e) {\n-\t\t\t// TODO Auto-generated catch block\n \t\t\te.printStackTrace();\n \t\t}\n \t}\n@@ -93,7 +92,6 @@ public class GitStorage implements IStorage {\n \t\t\tthrow new ResourceException(IResourceStatus.FAILED_READ_LOCAL,\n \t\t\t\t\tresource.getFullPath(), \"Could not read file\", e);\n \t\t} catch (IOException e) {\n-\t\t\t// TODO Auto-generated catch block\n \t\t\te.printStackTrace();\n \t\t\tthrow new ResourceException(33, resource.getFullPath(), e\n \t\t\t\t\t.getMessage(), e);\n@@ -109,12 +107,10 @@ public class GitStorage implements IStorage {\n \t}\n \n \tpublic boolean isReadOnly() {\n-\t\t// TODO Auto-generated method stub\n \t\treturn false;\n \t}\n \n \tpublic Object getAdapter(Class adapter) {\n-\t\t// TODO Auto-generated method stub\n \t\treturn null;\n \t}\n \ndiff --git a/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitCommitFileRevision.java b/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitCommitFileRevision.java\nindex 6d6f7ea..da0444f 100644\n--- a/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitCommitFileRevision.java\n+++ b/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitCommitFileRevision.java\n@@ -134,7 +134,6 @@ public class GitCommitFileRevision extends GitFileRevision {\n \t\t\telse\n \t\t\t\treturn tree.findTreeMember(path);\n \t\t} catch (IOException e) {\n-\t\t\t// TODO Auto-generated catch block\n \t\t\te.printStackTrace();\n \t\t}\n \t\treturn null;\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java\nindex 649df3f..1707859 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java\n@@ -155,7 +155,6 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,\n \tpublic boolean inputSet() {\n \t\tif (viewer != null)\n \t\t\tviewer.setInput(getInput());\n-\t\t// TODO Auto-generated method stub\n \t\treturn true;\n \t}\n \n@@ -875,7 +874,6 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,\n \t\t\t\ttry {\n \t\t\t\t\tnewappliedPatches = repositoryMapping.getRepository().getAppliedPatches();\n \t\t\t\t} catch (IOException e) {\n-\t\t\t\t\t// TODO Auto-generated catch block\n \t\t\t\t\te.printStackTrace();\n \t\t\t\t}\n \t\t\t\tMap<ObjectId,Tag[]> newtags = new HashMap<ObjectId,Tag[]>();\n@@ -895,13 +893,11 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,\n \t\t\t\t\t\tnewtags.put(t.getObjId(), samecommit);\n \t\t\t\t\t}\n \t\t\t\t} catch (IOException e) {\n-\t\t\t\t\t// TODO Auto-generated catch block\n \t\t\t\t\te.printStackTrace();\n \t\t\t\t}\n \t\t\t\ttry {\n \t\t\t\t\tcurrentHead = repositoryMapping.getRepository().resolve(\"HEAD\");\n \t\t\t\t} catch (IOException e) {\n-\t\t\t\t\t// TODO Auto-generated catch block\n \t\t\t\t\te.printStackTrace();\n \t\t\t\t}\n \t\t\t\tMap<ObjectId, String[]> newBranches = new HashMap<ObjectId, String[]>();\n@@ -933,7 +929,6 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,\n \t\t\t\t\tnewBranches.put(currentHead, samecommit);\n \t\t\t\t\tbranches = newBranches;\n \t\t\t\t} catch (IOException e) {\n-\t\t\t\t\t// TODO Auto-generated catch block\n \t\t\t\t\te.printStackTrace();\n \t\t\t\t}\n \t\t\t\tGitFileHistoryProvider fileHistoryProvider = (GitFileHistoryProvider) provider\n@@ -1092,12 +1087,10 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,\n \t}\n \n \tpublic boolean isValidInput(Object object) {\n-\t\t// TODO Auto-generated method stub\n \t\treturn true;\n \t}\n \n \tpublic void refresh() {\n-\t\t// TODO Auto-generated method stub\n \n \t}\n \n@@ -1109,14 +1102,12 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,\n \t}\n \n \tpublic ICompareInput getCompareInput(Object object) {\n-\t\t// TODO Auto-generated method stub\n \t\treturn null;\n \t}\n \n \tpublic void prepareInput(ICompareInput input,\n \t\t\tCompareConfiguration configuration, IProgressMonitor monitor) {\n \t\tSystem.out.println(\"prepareInput()\");\n-\t\t// TODO Auto-generated method stub\n \t}\n \n \t/**\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java\nindex c13c38a..9ab762a 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java\n@@ -89,7 +89,6 @@ public class GitResourceDecorator extends LabelProvider implements\n \t\t\t\t\t}\n \t\t\t\t});\n \t\t\t} catch (CoreException e) {\n-\t\t\t\t// TODO Auto-generated catch block\n \t\t\t\te.printStackTrace();\n \t\t\t}\n \t\t\tstart();\n@@ -129,7 +128,6 @@ public class GitResourceDecorator extends LabelProvider implements\n \t\t\t\t\t\t\t\t// Activator.trace(\"VCLEARING:\"+r.getFullPath().toOSString());\n \t\t\t\t\t\t\t\tclearDecorationState(r);\n \t\t\t\t\t\t\t} catch (CoreException e) {\n-\t\t\t\t\t\t\t\t// TODO Auto-generated catch block\n \t\t\t\t\t\t\t\te.printStackTrace();\n \t\t\t\t\t\t\t}\n \t\t\t\t\t\t}\n@@ -138,7 +136,6 @@ public class GitResourceDecorator extends LabelProvider implements\n \n \t\t\t\t});\n \t\t\t} catch (CoreException e2) {\n-\t\t\t\t// TODO Auto-generated catch block\n \t\t\t\te2.printStackTrace();\n \t\t\t\treturn;\n \t\t\t}\n@@ -211,10 +208,8 @@ public class GitResourceDecorator extends LabelProvider implements\n \t\t\t}\n \t\t\treturn null; // not mapped\n \t\t} catch (CoreException e) {\n-\t\t\t// TODO Auto-generated catch block\n \t\t\te.printStackTrace();\n \t\t} catch (IOException e) {\n-\t\t\t// TODO Auto-generated catch block\n \t\t\te.printStackTrace();\n \t\t}\n \t\treturn null;\n@@ -342,7 +337,6 @@ public class GitResourceDecorator extends LabelProvider implements\n \t\t\t//\n \t\t\tthrow new RuntimeException(UIText.Decorator_failedLazyLoading, e);\n \t\t} catch (CoreException e) {\n-\t\t\t// TODO Auto-generated catch block\n \t\t\te.printStackTrace();\n \t\t\tthrow new RuntimeException(UIText.Decorator_failedLazyLoading, e);\n \t\t}\n@@ -394,7 +388,6 @@ public class GitResourceDecorator extends LabelProvider implements\n \t\t\t\t}\n \t\t\t}\n \t\t} catch (CoreException e) {\n-\t\t\t// TODO Auto-generated catch block\n \t\t\te.printStackTrace();\n \t\t}\n \t}\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/factories/GitAdapterFactory.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/factories/GitAdapterFactory.java\nindex 53d222a..74b8efa 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/factories/GitAdapterFactory.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/factories/GitAdapterFactory.java\n@@ -43,7 +43,6 @@ public class GitAdapterFactory implements IAdapterFactory {\n \t}\n \n \tpublic Class[] getAdapterList() {\n-\t\t// TODO Auto-generated method stub\n \t\treturn null;\n \t}\n \ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalWalker.java b/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalWalker.java\nindex 16af0c6..3da6b03 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalWalker.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalWalker.java\n@@ -105,7 +105,6 @@ public class TopologicalWalker extends Walker {\n \t\t\t\ttry {\n \t\t\t\t\tcollectSortOrder(succ, repository.mapCommit(succ));\n \t\t\t\t} catch (IOException e) {\n-\t\t\t\t\t// TODO Auto-generated catch block\n \t\t\t\t\te.printStackTrace();\n \t\t\t\t}\n \t\t\t}\ndiff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java b/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java\nindex 1f6c531..ca67969 100644\n--- a/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java\n+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java\n@@ -104,7 +104,6 @@ public abstract class Walker {\n \t\t\ttry {\n \t\t\t\tnext.run();\n \t\t\t} catch (IOException e) {\n-\t\t\t\t// TODO Auto-generated catch block\n \t\t\t\te.printStackTrace();\n \t\t\t}\n \t\t\ttodo.remove(next);\n-- \n1.5.3.7\n"},{"id":"66049","messageId":"200801202207.28128.robin.rosenberg.lists@dewire.com","threadId":"11685","inReplyTo":"1200860941-6922-1-git-send-email-rogersoares@intelinet.com.br","subject":"Re: [EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2008-01-20T21:07:27Z","receivedAt":"2008-01-20T21:07:27Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"söndagen den 20 januari 2008 skrev Roger C. Soares:\n>                 } catch (IOException e) {\n> -                       // TODO Auto-generated catch block\n>                         e.printStackTrace();\n\n\nUnfortunately it is not that easy. Most of the TODO's are left there \nintentionally. They signal work to do, i.e. proper error handling. At minimum \nwe should use Eclipse's error logging. For JGit we could encapsulate it a \nlittle as we don't have direct access to the Eclipse runtime there.\n\nBTW JGit is currently mostly GPL'ed. I want to have your permission to \nrelicense anything you contribute there under the EPL (Eclipse Public \nLicense), just in case we go down that road and make it an Eclipse project.\n\nYou put a finger on a sore point. We'll see if I can find a way to replace\nthose TODO's with something sensible.\n\nAlso, please Cc: directly for egit patches. Shawn, want Cc: to?\n\n-- robin\n"},{"id":"66066","messageId":"4793F508.1000503@intelinet.com.br","threadId":"11685","inReplyTo":"200801202207.28128.robin.rosenberg.lists@dewire.com","subject":"Re: [EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-01-21T01:27:36Z","receivedAt":"2008-01-21T01:27:36Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"Robin Rosenberg escreveu:\n> Unfortunately it is not that easy. Most of the TODO's are left there \n> intentionally. They signal work to do, i.e. proper error handling. At minimum \n> we should use Eclipse's error logging. For JGit we could encapsulate it a \n> little as we don't have direct access to the Eclipse runtime there.\n>   \nOk.\n\n> BTW JGit is currently mostly GPL'ed. I want to have your permission to \n> relicense anything you contribute there under the EPL (Eclipse Public \n> License), just in case we go down that road and make it an Eclipse project.\n>   \nSure, permission granted.\n\n> You put a finger on a sore point. We'll see if I can find a way to replace\n> those TODO's with something sensible.\n>\n> Also, please Cc: directly for egit patches. Shawn, want Cc: to?\n>\n> -- robin\n>   \nOk.\n\n[]s,\nRoger.\n"}]}