{"thread":{"id":"11565","subject":"[PATCH] gitweb: Change feeds from commit to commitdiff output.","startedAt":"2008-01-10T13:09:00Z","lastAt":"2008-01-11T11:12:03Z","messageCount":4,"participants":["Florian La Roche","Junio C Hamano","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"64927","messageId":"20080110130900.GA9395@dudweiler.stuttgart.redhat.com","threadId":"11565","inReplyTo":null,"subject":"[PATCH] gitweb: Change feeds from commit to commitdiff output.","fromName":"Florian La Roche","fromEmail":"laroche@redhat.com","sentAt":"2008-01-10T13:09:00Z","receivedAt":"2008-01-10T13:09:00Z","isPatch":true,"sender":{"key":"laroche@redhat.com","avatar":null},"body":"[PATCH] gitweb: Change feeds from commit to commitdiff output.\n\nChange feeds from displaying the commit to displaying the commitdiff\noutput. This way the patches are shown directly and code review is\ndone more easily via watching feeds.\n\nSigned-off-by: Florian La Roche \n---\n gitweb/gitweb.perl | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 6256641..0db83c0 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -5566,7 +5566,7 @@ XML\n \t\t\tor next;\n \n \t\t# print element (entry, item)\n-\t\tmy $co_url = href(-full=>1, action=>\"commit\", hash=>$commit);\n+\t\tmy $co_url = href(-full=>1, action=>\"commitdiff\", hash=>$commit);\n \t\tif ($format eq 'rss') {\n \t\t\tprint \"\\n\" .\n \t\t\t \"\" . esc_html($co{'title'}) . \"\\n\" .\n-- \n1.5.3.8\n"},{"id":"64942","messageId":"7vtzll5t4u.fsf@gitster.siamese.dyndns.org","threadId":"11565","inReplyTo":"20080110130900.GA9395@dudweiler.stuttgart.redhat.com","subject":"Re: [PATCH] gitweb: Change feeds from commit to commitdiff output.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-01-10T20:21:21Z","receivedAt":"2008-01-10T20:21:21Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Florian La Roche writes:\n\n> [PATCH] gitweb: Change feeds from commit to commitdiff output.\n>\n> Change feeds from displaying the commit to displaying the commitdiff\n> output. This way the patches are shown directly and code review is\n> done more easily via watching feeds.\n>\n> Signed-off-by: Florian La Roche \n\nI can see that easier access to commitdiff output is sometimes\ndesirable.\n\nIf you are making this change unconditional, however, I think\nthere needs a list discussion between you and the silent\nmajority of people that have been perfectly happy with the\ncurrent \"log only\" behaviour.\n\nAnd to have that discussion, you first have to wake them up,\nwhich this patch would serve well as a wake-up call. But if\nthat was the purpose of the posting, please (1) mark the patch\nas such (commonly done by saying [RFC/PATCH] instead), and (2)\nkeep me out of the \"To:\" list, if the patch is not for inclusion\nbut for discussion (\"cc:\" is fine but it's redundant as long as\nyou are sending to the list).\n\nAfter such a discussion, we may end up finding out that\neverybody have been silently unhappy and wanted to have\ncommitdiff there, and agree on doing this unconditionally.\n\nBut we do not know that yet.\n\nThanks.\n"},{"id":"64984","messageId":"20080111065348.GA3967@dudweiler.stuttgart.redhat.com","threadId":"11565","inReplyTo":"7vtzll5t4u.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] gitweb: Change feeds from commit to commitdiff output.","fromName":"Florian La Roche","fromEmail":"laroche@redhat.com","sentAt":"2008-01-11T06:53:48Z","receivedAt":"2008-01-11T06:53:48Z","isPatch":true,"sender":{"key":"laroche@redhat.com","avatar":null},"body":"On Thu, Jan 10, 2008 at 12:21:21PM -0800, Junio C Hamano wrote:\n> Florian La Roche writes:\n> \n> > [PATCH] gitweb: Change feeds from commit to commitdiff output.\n> >\n> > Change feeds from displaying the commit to displaying the commitdiff\n> > output. This way the patches are shown directly and code review is\n> > done more easily via watching feeds.\n> >\n> > Signed-off-by: Florian La Roche \n> \n> I can see that easier access to commitdiff output is sometimes\n> desirable.\n> \n> If you are making this change unconditional, however, I think\n> there needs a list discussion between you and the silent\n> majority of people that have been perfectly happy with the\n> current \"log only\" behaviour.\n\n\nHello Junio,\n\nRight, this is a change in behaviour. Maybe a config option\nfor this would be good, so that users can configure their\nwanted output style.\n\n\n> And to have that discussion, you first have to wake them up,\n> which this patch would serve well as a wake-up call. But if\n> that was the purpose of the posting, please (1) mark the patch\n> as such (commonly done by saying [RFC/PATCH] instead), and (2)\n> keep me out of the \"To:\" list, if the patch is not for inclusion\n> but for discussion (\"cc:\" is fine but it's redundant as long as\n> you are sending to the list).\n\n\nOk.\n\n\n> After such a discussion, we may end up finding out that\n> everybody have been silently unhappy and wanted to have\n> commitdiff there, and agree on doing this unconditionally.\n> \n> But we do not know that yet.\n\n\n>From asking people, most don't use feeds to follow development\ncheckins, but prefer to keep with mailinglists and looking only\nat the repos for their own interesting parts.\n\nHope more people will speak up here on the git@ list.\n\nThanks a lot,\n\nFlorian La Roche\n"},{"id":"65005","messageId":"m3sl14mxat.fsf@roke.D-201","threadId":"11565","inReplyTo":"20080110130900.GA9395@dudweiler.stuttgart.redhat.com","subject":"Re: [PATCH] gitweb: Change feeds from commit to commitdiff output.","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-01-11T11:12:03Z","receivedAt":"2008-01-11T11:12:03Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Florian La Roche writes:\n\n> [PATCH] gitweb: Change feeds from commit to commitdiff output.\n> \n> Change feeds from displaying the commit to displaying the commitdiff\n> output. This way the patches are shown directly and code review is\n> done more easily via watching feeds.\n\nFirst, this changes _link_, and not display (change summary), so the\ncommit message IMHO should read rather:\n\n\tgitweb: Change feeds link from commit view to commitdiff view.\n\t\n\tChange feed link from link to commit view to link to commitdiff\n\tview. This way the patches are shown directly and code review is\n\tdone more easily via watching feeds.\n\nI personally do not use gitweb feeds not feed readers, so I cannot say\nif this change truly helps. I just don't know what the \"feed watcher\"\nworkflow looks like.\n\n\nSecond, at least for Atom format it is possible to give both 'commit'\nand 'commitdiff' view links as alternate links for a feed. That is\nsomething to consider.\n\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -5566,7 +5566,7 @@ XML\n> \t\t\tor next;\n> \n> \t\t# print element (entry, item)\n> -\t\tmy $co_url = href(-full=>1, action=>\"commit\", hash=>$commit);\n> +\t\tmy $co_url = href(-full=>1, action=>\"commitdiff\", hash=>$commit);\n> \t\tif ($format eq 'rss') {\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"}]}