{"thread":{"id":"11516","subject":"[EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.","startedAt":"2008-01-08T01:15:29Z","lastAt":"2008-01-13T23:54:08Z","messageCount":9,"participants":["Roger C. Soares","Robin Rosenberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"64691","messageId":"200801072315.30122.rogersoares@intelinet.com.br","threadId":"11516","inReplyTo":null,"subject":"[EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-01-08T01:15:29Z","receivedAt":"2008-01-08T01:15:29Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"\nSigned-off-by: Roger C. Soares <rogersoares@intelinet.com.br>\n---\nSome more patches, please evaluate.\nDon't know what others are working on,\nbut right now I'm missing a search functionality so\nthis will probably be my next egit little feature.\n\ncheers\n\n .../GitCompareFileRevisionEditorInput.java         |   12 ++++++++++++\n .../spearce/egit/ui/internal/GitResourceNode.java  |    5 +++++\n 2 files changed, 17 insertions(+), 0 deletions(-)\n\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java\nindex eaba1fa..403fdc1 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java\n@@ -152,6 +152,18 @@ public class GitCompareFileRevisionEditorInput extends CompareEditorInput {\n \n \tprivate void initLabels(ICompareInput input) {\n \t\tCompareConfiguration cc = getCompareConfiguration();\n+\t\tif(left != null && left instanceof GitResourceNode) {\n+\t\t\tString ci = ((GitResourceNode)left).getContentIdentifier();\n+\t\t\tif(ci != null) {\n+\t\t\t\tcc.setLeftLabel(ci.substring(0, 7) + \"..\");\n+\t\t\t}\n+\t\t}\n+\t\tif(right != null && right instanceof GitResourceNode) {\n+\t\t\tString ci = ((GitResourceNode)right).getContentIdentifier();\n+\t\t\tif(ci != null) {\n+\t\t\t\tcc.setRightLabel(ci.substring(0, 7) + \"..\");\n+\t\t\t}\n+\t\t}\n \t\tif (getLeftRevision() != null) {\n \t\t\tString leftLabel = getFileRevisionLabel(getLeftRevision());\n \t\t\tcc.setLeftLabel(leftLabel);\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitResourceNode.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitResourceNode.java\nindex e19cef5..f25855a 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitResourceNode.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitResourceNode.java\n@@ -21,6 +21,7 @@ import org.spearce.jgit.lib.TreeEntry;\n public class GitResourceNode extends BufferedContent implements IStructureComparator, ITypedElement {\n \tTreeEntry entry;\n \tGitResourceNode[] children;\n+\tString contentIdentifier;\n \n \tpublic GitResourceNode(TreeEntry e) {\n \t\tentry = e;\n@@ -28,6 +29,7 @@ public class GitResourceNode extends BufferedContent implements IStructureCompar\n \n \tpublic GitResourceNode(IFileRevision file) {\n \t\tthis(file instanceof GitCommitFileRevision ? ((GitCommitFileRevision)file).getTreeEntry() : null);\n+\t\tcontentIdentifier = ((GitCommitFileRevision)file).getContentIdentifier();\n \t}\n \n \tpublic Object[] getChildren() {\n@@ -100,5 +102,8 @@ public class GitResourceNode extends BufferedContent implements IStructureCompar\n \t\t}\n \t}\n \n+\tpublic String getContentIdentifier() {\n+\t\treturn contentIdentifier;\n+\t}\n }\n \n-- \n1.5.3.7\n"},{"id":"64789","messageId":"200801082312.00329.robin.rosenberg.lists@dewire.com","threadId":"11516","inReplyTo":"200801072315.30122.rogersoares@intelinet.com.br","subject":"Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2008-01-08T22:12:00Z","receivedAt":"2008-01-08T22:12:00Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"Thanks.\n\ntisdagen den 8 januari 2008 skrev Roger C. Soares:\n> \n> Signed-off-by: Roger C. Soares <rogersoares@intelinet.com.br>\n> ---\n> Some more patches, please evaluate.\n> Don't know what others are working on,\nI'm implementing fetch (with some help from Shawn). Progress in\nplace. I still need to update refs and get in consistent with native\ngit behaviour.\n\nI'm also updating the javadocs.\n\n> but right now I'm missing a search functionality so\n> this will probably be my next egit little feature.\nSounds good.\n\n-- robin\n"},{"id":"64801","messageId":"4784247B.10604@intelinet.com.br","threadId":"11516","inReplyTo":"200801082312.00329.robin.rosenberg.lists@dewire.com","subject":"Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-01-09T01:33:47Z","receivedAt":"2008-01-09T01:33:47Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"Robin Rosenberg escreveu:\n> I'm implementing fetch (with some help from Shawn). Progress in\n> place. I still need to update refs and get in consistent with native\n> git behaviour.\n>\n> I'm also updating the javadocs.\nCool.\n\nI use a lot the eclipse feature that highlights all occurences of a \nvariable or method but with all the warnings in the project it is \ndifficult to visually find these occurences. So I'm anxious to remove a \nlot of warnings. Public methods without documentation are one of them. \nIs it ok if I send you a patch removing all the warnings I know how but \nthe ones about public methods needing documentation as you're already \ndocumenting them? I also want to remove the auto generated TODOs, as \nthey don't actually say what to do, like this one:\n// TODO Auto-generated catch block\n\n[]s,\nRoger.\n"},{"id":"64969","messageId":"200801110046.41786.robin.rosenberg.lists@dewire.com","threadId":"11516","inReplyTo":"4784247B.10604@intelinet.com.br","subject":"Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2008-01-10T23:46:40Z","receivedAt":"2008-01-10T23:46:40Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"onsdagen den 9 januari 2008 skrev Roger C. Soares:\n> Robin Rosenberg escreveu:\n> > I'm implementing fetch (with some help from Shawn). Progress in\n> > place. I still need to update refs and get in consistent with native\n> > git behaviour.\n> >\n> > I'm also updating the javadocs.\n> Cool.\n> \n> I use a lot the eclipse feature that highlights all occurences of a \n> variable or method but with all the warnings in the project it is \n> difficult to visually find these occurences. So I'm anxious to remove a \n> lot of warnings. Public methods without documentation are one of them. \n> Is it ok if I send you a patch removing all the warnings I know how but \n> the ones about public methods needing documentation as you're already \n> documenting them? I also want to remove the auto generated TODOs, as \n> they don't actually say what to do, like this one:\n> // TODO Auto-generated catch block\n\nI pushed my doc-branch as pu, you can look at it. My intention is take a look again\nand then push it as master if there are no objections. Is it ok and good to flags \npublic stuff without javadoc as an error (tip pu commit)?\n\nThe abbr commit patch is already pushed to master.\n\n-- robin\n"},{"id":"65115","messageId":"47882DBB.2000308@intelinet.com.br","threadId":"11516","inReplyTo":"200801110046.41786.robin.rosenberg.lists@dewire.com","subject":"Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-01-12T03:02:19Z","receivedAt":"2008-01-12T03:02:19Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"\nRobin Rosenberg escreveu:\n> I pushed my doc-branch as pu, you can look at it. My intention is take a look again\n> and then push it as master if there are no objections. Is it ok and good to flags \n> public stuff without javadoc as an error (tip pu commit)?\n>\n> The abbr commit patch is already pushed to master.\n>   \nLooks good to me. You actually took some time to explain things, it will \nbe usefull, thanks!\nIf we really want to document all the public methods then I think it's \nnice to flag it's absence as an error. It would have made me document \nGitResourceNode.getContentIdentifier(), it's now one more comment for \nyou to add before pushing to master ;)\n\n[]s,\nRoger.\n"},{"id":"65117","messageId":"47883600.20307@intelinet.com.br","threadId":"11516","inReplyTo":"200801110046.41786.robin.rosenberg.lists@dewire.com","subject":"Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-01-12T03:37:36Z","receivedAt":"2008-01-12T03:37:36Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"\n\nRobin Rosenberg escreveu:\n> I pushed my doc-branch as pu, you can look at it. My intention is take a look again\n> and then push it as master if there are no objections. Is it ok and good to flags \n> public stuff without javadoc as an error (tip pu commit)?\n>   \nGot some errors, when trying to export to a deployable plugin:\n\"/home/roger/eclipse/workspace/egit/org.spearce.jgit/tst\" does not exist!\n\nAnd on \"team -> share project... -> Git\", it goes to the CVS wizard.\n\n[]s,\nRoger.\n"},{"id":"65185","messageId":"200801121644.21173.robin.rosenberg.lists@dewire.com","threadId":"11516","inReplyTo":"47883600.20307@intelinet.com.br","subject":"Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2008-01-12T15:44:19Z","receivedAt":"2008-01-12T15:44:19Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"lördagen den 12 januari 2008 skrev Roger C. Soares:\n> \n> Robin Rosenberg escreveu:\n> > I pushed my doc-branch as pu, you can look at it. My intention is take a look again\n> > and then push it as master if there are no objections. Is it ok and good to flags \n> > public stuff without javadoc as an error (tip pu commit)?\n> >   \n> Got some errors, when trying to export to a deployable plugin:\n> \"/home/roger/eclipse/workspace/egit/org.spearce.jgit/tst\" does not exist!\n> \n> And on \"team -> share project... -> Git\", it goes to the CVS wizard.\n\nDue to my lack of testing @_@. I pushed a new pu branch with these two errors fixed.\n\nThanks\n-- robin\n"},{"id":"65270","messageId":"478A7C48.6040501@intelinet.com.br","threadId":"11516","inReplyTo":"200801121644.21173.robin.rosenberg.lists@dewire.com","subject":"Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.","fromName":"Roger C. Soares","fromEmail":"rogersoares@intelinet.com.br","sentAt":"2008-01-13T21:02:00Z","receivedAt":"2008-01-13T21:02:00Z","isPatch":true,"sender":{"key":"rogersoares@intelinet.com.br","avatar":null},"body":"Hi Robin,\n\nFor what I've been using it's all working now.\nI saw some typos if you want to update them while you're at it:\n\nActivator.java\n     * Instatiate an error exception.\n     * Log a dbeug message\nGitHistoryPage.java\n     * @return reformated comment\n     * This class extendes the build in history page with Git features, such\n\n[]s,\nRoger.\n\n--\nRobin Rosenberg escreveu:\n> lördagen den 12 januari 2008 skrev Roger C. Soares:\n>   \n>> Robin Rosenberg escreveu:\n>>     \n>>> I pushed my doc-branch as pu, you can look at it. My intention is take a look again\n>>> and then push it as master if there are no objections. Is it ok and good to flags \n>>> public stuff without javadoc as an error (tip pu commit)?\n>>>   \n>>>       \n>> Got some errors, when trying to export to a deployable plugin:\n>> \"/home/roger/eclipse/workspace/egit/org.spearce.jgit/tst\" does not exist!\n>>\n>> And on \"team -> share project... -> Git\", it goes to the CVS wizard.\n>>     \n>\n> Due to my lack of testing @_@. I pushed a new pu branch with these two errors fixed.\n>\n> Thanks\n> -- robin\n>\n>\n>\n>   \n"},{"id":"65285","messageId":"200801140054.09956.robin.rosenberg.lists@dewire.com","threadId":"11516","inReplyTo":"478A7C48.6040501@intelinet.com.br","subject":"Re: javadoc (was [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.)","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2008-01-13T23:54:08Z","receivedAt":"2008-01-13T23:54:08Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"söndagen den 13 januari 2008 skrev Roger C. Soares:\n> Hi Robin,\n> \n> For what I've been using it's all working now.\n> I saw some typos if you want to update them while you're at it:\n\nFixed, on pu now. Will push to master tomorrow.\n\n-- robiin\n"}]}