{"thread":{"id":"1151","subject":"[PATCH] Remove use of SHOWN flag","startedAt":"2005-07-07T02:00:24Z","lastAt":"2005-07-07T02:00:24Z","messageCount":1,"participants":["Jon Seymour"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"5746","messageId":"20050707020024.7874.qmail@blackcubes.dyndns.org","threadId":"1151","inReplyTo":null,"subject":"[PATCH] Remove use of SHOWN flag","fromName":"Jon Seymour","fromEmail":"jon.seymour@gmail.com","sentAt":"2005-07-07T02:00:24Z","receivedAt":"2005-07-07T02:00:24Z","isPatch":true,"sender":{"key":"jon.seymour@gmail.com","avatar":"https://avatars.githubusercontent.com/u/207131?v=4"},"body":"\nNow that duplicates are elided early, there is no need for the\nSHOWN flag.\n\nThis patch removes the SHOWN flag and its uses from rev-list.c\n\nSigned-off-by: Jon Seymour <jon.seymour@gmail>\n---\n\n rev-list.c |    4 +---\n 1 files changed, 1 insertions(+), 3 deletions(-)\n\n28294b1e139ea3f7c08814e022246e42f9ab9fa3\ndiff --git a/rev-list.c b/rev-list.c\n--- a/rev-list.c\n+++ b/rev-list.c\n@@ -8,7 +8,6 @@\n #define SEEN\t\t(1u << 0)\n #define INTERESTING\t(1u << 1)\n #define COUNTED\t\t(1u << 2)\n-#define SHOWN\t\t(1u << 3)\n \n static const char rev_list_usage[] =\n \t\"usage: git-rev-list [OPTION] commit-id <commit-id>\\n\"\n@@ -42,7 +41,6 @@ static int topo_order = 0;\n \n static void show_commit(struct commit *commit)\n {\n-\tcommit->object.flags |= SHOWN;\n \tif (show_breaks) {\n \t\tprefix = \"| \";\n \t\tif (commit->object.flags & DISCONTINUITY) {\n@@ -72,7 +70,7 @@ static int filter_commit(struct commit *\n {\n \tif (stop_traversal && (commit->object.flags & BOUNDARY))\n \t\treturn STOP;\n-\tif (commit->object.flags & (UNINTERESTING|SHOWN))\n+\tif (commit->object.flags & UNINTERESTING)\n \t\treturn CONTINUE;\n \tif (min_age != -1 && (commit->date > min_age))\n \t\treturn CONTINUE;\n------------\n"}]}