{"thread":{"id":"11478","subject":"[PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault","startedAt":"2008-01-05T01:11:37Z","lastAt":"2008-01-05T01:35:55Z","messageCount":3,"participants":["Brandon Casey","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"64484","messageId":"477ED949.1030909@nrlssc.navy.mil","threadId":"11478","inReplyTo":null,"subject":"[PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2008-01-05T01:11:37Z","receivedAt":"2008-01-05T01:11:37Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n---\n builtin-reflog.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-reflog.c b/builtin-reflog.c\nindex f422693..5e54989 100644\n--- a/builtin-reflog.c\n+++ b/builtin-reflog.c\n@@ -394,7 +394,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix)\n \t\tint recno;\n \n \t\tif (!spec) {\n-\t\t\tstatus |= error(\"Not a reflog: %s\", ref);\n+\t\t\tstatus |= error(\"Not a reflog: %s\", argv[i]);\n \t\t\tcontinue;\n \t\t}\n \n-- \n1.5.4.rc2.1119.g6fdf-dirty\n"},{"id":"64486","messageId":"7vzlvlf4n9.fsf@gitster.siamese.dyndns.org","threadId":"11478","inReplyTo":"477ED949.1030909@nrlssc.navy.mil","subject":"Re: [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-01-05T01:22:02Z","receivedAt":"2008-01-05T01:22:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brandon Casey <casey@nrlssc.navy.mil> writes:\n\n> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n> ---\n>  builtin-reflog.c |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/builtin-reflog.c b/builtin-reflog.c\n> index f422693..5e54989 100644\n> --- a/builtin-reflog.c\n> +++ b/builtin-reflog.c\n> @@ -394,7 +394,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix)\n>  \t\tint recno;\n>  \n>  \t\tif (!spec) {\n> -\t\t\tstatus |= error(\"Not a reflog: %s\", ref);\n> +\t\t\tstatus |= error(\"Not a reflog: %s\", argv[i]);\n>  \t\t\tcontinue;\n>  \t\t}\n\nBad Brandon!  Looking at 'next' while everybody is asked to work\non finding and fixing bugs on 'master' while -rc freeze.\n\nJust kidding.  Thanks, the code is obviously correct, and will\nqueue.\n\nI am not so surprised to see bugs in relatively new code that is\nonly in 'next', especially this one that no Porcelains already\nuse.\n"},{"id":"64488","messageId":"477EDEFB.7020909@nrlssc.navy.mil","threadId":"11478","inReplyTo":"7vzlvlf4n9.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2008-01-05T01:35:55Z","receivedAt":"2008-01-05T01:35:55Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Junio C Hamano wrote:\n> Bad Brandon!  Looking at 'next' while everybody is asked to work\n> on finding and fixing bugs on 'master' while -rc freeze.\n\nNo more, I promise. :)\n\n-brandon\n"}]}