{"thread":{"id":"11437","subject":"Fwd: qgit 2.1 questions about range selection","startedAt":"2007-12-31T11:53:16Z","lastAt":"2008-01-01T20:03:18Z","messageCount":3,"participants":["Marco Costalba","Steffen Prohaska"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"64261","messageId":"e5bfff550712310353k64ae0991vcd293dae565a0ce@mail.gmail.com","threadId":"11437","inReplyTo":"e5bfff550712310352j3245511chbbd301d35e09204b@mail.gmail.com","subject":"Fwd: qgit 2.1 questions about range selection","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2007-12-31T11:53:16Z","receivedAt":"2007-12-31T11:53:16Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"---------- Forwarded message ----------\nFrom: Marco Costalba \nDate: Dec 31, 2007 12:52 PM\nSubject: Re: qgit 2.1 questions about range selection\nTo: Steffen Prohaska \n\n\nOn Dec 31, 2007 11:42 AM, Steffen Prohaska wrote:\n> Hello Marco,\n\nHi Steffen,\n\n I hope you don't mind if I forward this also to the git list.\n\nYour questions are interesting, and I think could be useful also for\nother people.\n\n>\n> Here is a first impressions and some questions about the range\n> selection, which I find pretty hard to understand.\n>\n> - The \"Range select\" dialog.\n> * It is displayed upon startup or when I open a new\n> repository. But I haven't found a way to access \"Range\n> select\" from the menus. I'd expected to find it as\n> \"View > Range select\".\n\nCurrently the only way is to open (with File->open or \"open folder\"\nthe tool button or with File->last opened repos list ) again the\n_same_ repository. I understand is not the best way. Your suggestion\n\"View->range select\" it seems a better idea.\n\n> * The dialog's \"Top:\" and \"Bottom:\" drop downs apparently contain\n> tags or \"HEAD\". Why can't I select a specific branch? I'd\n> expected this here, too.\n\nYou can write anything you want in top and bottom fields, they are not\nread-only, so you can write a branch name or anything understandable\nby 'git log'. You can also clear one filed, as example the bottom\nfield to have all the revisions until the initial one.\n\n> * The dialog's \"Top:\" and \"Bottom:\" fields are reset to a\n> default each time the dialog opens. Why aren't the last settings\n> preserved?\n\nMmmmm, why not? this goes in the same playfield of \"View->Range select\", thanks.\n\n> * I find the toggles \"Working dir\" hard to understand. Why\n> not always showing the working dir? Why not displaying\n> differences to the index (as gitk does with the \"green\"\n> commit)?\n\nWell differences in the index _are_ displayed with an \"orange\" commit\n(from a long time ago also, much more then gitk BTW). The reason is\nnot selected by default is that on big repos, as Linux, checking for\nworking dir changed files takes very long and is not useful for people\nthat just wants to pull Linux and take a look atthe updates. Anyhow\nyou can always toggle this directly right clicking anywhere in the\nmain revision list. A pop up menu appears and \"Check for modified\nfiles\" is the first entry.\n\n\n> * Similar for the toggles \"All branches\", \"Whole history\".\n> Maybe \"All branches\" could be included in the \"Top:\" drop down\n> and \"Whole history\" could be included in the \"Bottom:\" drop down.\n>\n\nThere should be some tooltips that help here. But again Top and Bottom\nare only range delimiters, what happens is that if you write A in the\ntop field and B in the bottom field git log is called with : git log\nA..B\n\n> - The parameters of the current range selection are not obvious.\n> After closing the \"Range select\" dialog the history is\n> displayed. But where can I see the parameters of the\n> selection? I'd have expected to see an indication which\n> branches, tags, whole history, ... I selected. Indications\n> of this are scattered over the GUI. For example, a filter can\n> be toggled on in the tool menu bar and is greyed out if\n> activated. Or \"FILTER ON\" may be displayed in the window\n> title.\n>\n\nWell there is already a \"Filter ON\" but is for a more advanced feature\nthen range select. Simply, from main list, press key 't' to show tree\nview, then select some files/directories (multi selection is allowed),\nthen press the magic wand toolbar button: that's the FILTER ON (and\nyou see on the window caption BTW)\n\n> - \"Toggle filter by tree\" seems to switch to \"--all\". I see\n> more commits than I expect. I'd have expected that this\n> toggle adds a boolean \"and\" to the selection; that is the\n> current view would be restricted to commits touching the\n> selected path.\n>\n\nMmmmm, if this is the case it's a bug. Thanks I will investigate.\n\n> Maybe the range selection could be unified in the following way.\n> The selection is represented as multiple lines; each line\n> representing part of the selection parameters. All lines together\n> act as a boolean expression selecting the commits. Each line\n> contains drop down boxes and text fields (or other GUI elements).\n> The selection filter is displayed below the tool bar and the\n> tab containing the \"Rev list\"; or it should be included in the\n> \"Rev list\". For example, the following lines would select the\n> commits on branch pu, not on master, touching file help.c\n>\n> - Selection: [label]\n> - Branch [drop down], origin/pu [drop down],\n> - Not on branch [drop down], origin/master [drop down],\n> - File [drop down], help.c [text field],\n>\n> Each line contains \"-\", \"+\" buttons to remove this line or add a\n> line below. The very first line has a button \"+\" to add a line\n> at the very bottom. I attached a snapshot of the Mac OS X\n> Smartfolder GUI to illustrate this.\n>\n>\n\nThat's nice!\n\nCurrently you can use the \"Additional options\" field at the bottom of\nrange select to write a free text that will be pasted directly to the\ngit log command line arguments.\n\n\n>\n>\n> Btw, is the git mailing list the right forum to discuss such\n> suggestions?\n>\n> If so, feel free to reply with CC to git@vger.kernel.org.\n>\n\nAlready done ;-)\n\nThanks\nMarco\n"},{"id":"64299","messageId":"e5bfff550801010733k63ed0c3du273f28b684efe904@mail.gmail.com","threadId":"11437","inReplyTo":"771EDDAF-F479-45F7-AB85-F7B6603FB061@zib.de","subject":"Re: qgit 2.1 questions about range selection","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-01-01T15:33:59Z","receivedAt":"2008-01-01T15:33:59Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Dec 31, 2007 11:42 AM, Steffen Prohaska wrote:\n>\n> Here is a first impressions and some questions about the range\n> selection, which I find pretty hard to understand.\n>\n\nHi Steffen,\n\n I have just pushed to\n\ngit://git.kernel.org/pub/scm/qgit/qgit4.git\n\na patch series that should address some of your concerns.\n\n\nMore questions are welcomed ;-)\n\nMarco\n"},{"id":"64304","messageId":"87845E66-B8BD-4CE4-BBA8-91A90524B62D@zib.de","threadId":"11437","inReplyTo":"e5bfff550801010733k63ed0c3du273f28b684efe904@mail.gmail.com","subject":"Re: qgit 2.1 questions about range selection","fromName":"Steffen Prohaska","fromEmail":"prohaska@zib.de","sentAt":"2008-01-01T20:03:18Z","receivedAt":"2008-01-01T20:03:18Z","isPatch":false,"sender":{"key":"prohaska@zib.de","avatar":"https://avatars.githubusercontent.com/u/217580?v=4"},"body":"Hello Marco,\n\nOn Jan 1, 2008, at 4:33 PM, Marco Costalba wrote:\n\n> On Dec 31, 2007 11:42 AM, Steffen Prohaska wrote:\n>>\n>> Here is a first impressions and some questions about the range\n>> selection, which I find pretty hard to understand.\n>>\n>\n> I have just pushed to\n>\n> git://git.kernel.org/pub/scm/qgit/qgit4.git\n>\n> a patch series that should address some of your concerns.\n\nThanks. The changes work for me.\n\nTwo minor remarks:\n\n - I'd call the menu entry \"View > Select range...\" instead of\n \"View > Open range dialog...\". This is shorter and the\n dots already indicate that a dialog will open.\n\n - I find the wizard icon in the menu entry confusing. The\n wizard icon is already associated with \"Toggle filter by\n tree\". It should be reserved for this.\n\n\tSteffen\n"}]}