{"thread":{"id":"11415","subject":"[PATCH] git-sh-setup: document git_editor() and get_author_ident_from_commit()","startedAt":"2007-12-28T22:25:39Z","lastAt":"2007-12-29T00:55:39Z","messageCount":3,"participants":["Miklos Vajna","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"64160","messageId":"1198880739-8480-1-git-send-email-vmiklos@frugalware.org","threadId":"11415","inReplyTo":null,"subject":"[PATCH] git-sh-setup: document git_editor() and get_author_ident_from_commit()","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2007-12-28T22:25:39Z","receivedAt":"2007-12-28T22:25:39Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"These 2 functions were missing from the manpage.\n\nSigned-off-by: Miklos Vajna <vmiklos@frugalware.org>\n---\n Documentation/git-sh-setup.txt |    8 ++++++++\n 1 files changed, 8 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/git-sh-setup.txt b/Documentation/git-sh-setup.txt\nindex 1ea1faa..fd024d7 100644\n--- a/Documentation/git-sh-setup.txt\n+++ b/Documentation/git-sh-setup.txt\n@@ -44,6 +44,10 @@ set_reflog_action::\n \tend-user action in the reflog, when the script updates a\n \tref.\n \n+git_editor::\n+\truns the proper editor based on GIT_EDITOR, core.editor, VISUAL or\n+\tEDITOR.\n+\n is_bare_repository::\n \toutputs `true` or `false` to the standard output stream\n \tto indicate if the repository is a bare repository\n@@ -57,6 +61,10 @@ require_work_tree::\n \tif so.  Used by scripts that require working tree\n \t(e.g. `checkout`).\n \n+get_author_ident_from_commit::\n+\toutputs code for use with eval to set the GIT_AUTHOR_NAME,\n+\tGIT_AUTHOR_EMAIL and GIT_AUTHOR_DATE variables for a given commit.\n+\n \n Author\n ------\n-- \n1.5.4.rc2-dirty\n"},{"id":"64164","messageId":"7vlk7ecp58.fsf@gitster.siamese.dyndns.org","threadId":"11415","inReplyTo":"1198880739-8480-1-git-send-email-vmiklos@frugalware.org","subject":"Re: [PATCH] git-sh-setup: document git_editor() and get_author_ident_from_commit()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-29T00:37:07Z","receivedAt":"2007-12-29T00:37:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n\n\"proper editor\" felt a bit funny, and also it needs to be\ndocumented that it refuses to proceed when the default editor is\nunusable, so I'd reword it like this:\n\ndiff --git a/Documentation/git-sh-setup.txt b/Documentation/git-sh-setup.txt\nindex 1ea1faa..505b4c9 100644\n--- a/Documentation/git-sh-setup.txt\n+++ b/Documentation/git-sh-setup.txt\n@@ -44,6 +44,11 @@ set_reflog_action::\n \tend-user action in the reflog, when the script updates a\n \tref.\n \n+git_editor::\n+\truns an editor of user's choice (GIT_EDITOR, core.editor, VISUAL or\n+\tEDITOR) on a given file, but error out if no editor is specified\n+\tand the terminal is dumb.\n+\n is_bare_repository::\n \toutputs `true` or `false` to the standard output stream\n \tto indicate if the repository is a bare repository\n"},{"id":"64165","messageId":"1198889739-10742-1-git-send-email-vmiklos@frugalware.org","threadId":"11415","inReplyTo":"7vlk7ecp58.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] git-sh-setup: document git_editor() and get_author_ident_from_commit()","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2007-12-29T00:55:39Z","receivedAt":"2007-12-29T00:55:39Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"These 2 functions were missing from the manpage.\n\nSigned-off-by: Miklos Vajna <vmiklos@frugalware.org>\n---\n\nOn Fri, Dec 28, 2007 at 04:37:07PM -0800, Junio C Hamano <gitster@pobox.com> wrote:\n> unusable, so I'd reword it like this:\n\nhere it is.\n\nVMiklos\n\n Documentation/git-sh-setup.txt |    9 +++++++++\n 1 files changed, 9 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/git-sh-setup.txt b/Documentation/git-sh-setup.txt\nindex 1ea1faa..505b4c9 100644\n--- a/Documentation/git-sh-setup.txt\n+++ b/Documentation/git-sh-setup.txt\n@@ -44,6 +44,11 @@ set_reflog_action::\n \tend-user action in the reflog, when the script updates a\n \tref.\n \n+git_editor::\n+\truns an editor of user's choice (GIT_EDITOR, core.editor, VISUAL or\n+\tEDITOR) on a given file, but error out if no editor is specified\n+\tand the terminal is dumb.\n+\n is_bare_repository::\n \toutputs `true` or `false` to the standard output stream\n \tto indicate if the repository is a bare repository\n@@ -57,6 +62,10 @@ require_work_tree::\n \tif so.  Used by scripts that require working tree\n \t(e.g. `checkout`).\n \n+get_author_ident_from_commit::\n+\toutputs code for use with eval to set the GIT_AUTHOR_NAME,\n+\tGIT_AUTHOR_EMAIL and GIT_AUTHOR_DATE variables for a given commit.\n+\n \n Author\n ------\n-- \n1.5.4.rc2-dirty\n"}]}