{"thread":{"id":"11413","subject":"[PATCH] gitk: use user-configured background in view definition dialog","startedAt":"2007-12-28T14:51:56Z","lastAt":"2008-01-08T09:55:34Z","messageCount":2,"participants":["Gerrit Pape"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"64144","messageId":"20071228145156.8106.qmail@6afea2d2003e0e.315fe32.mid.smarden.org","threadId":"11413","inReplyTo":null,"subject":"[PATCH] gitk: use user-configured background in view definition dialog","fromName":"Gerrit Pape","fromEmail":"pape@smarden.org","sentAt":"2007-12-28T14:51:56Z","receivedAt":"2007-12-28T14:51:56Z","isPatch":true,"sender":{"key":"pape@smarden.org","avatar":"https://avatars.githubusercontent.com/u/143170252?v=4"},"body":"Have the text fields in the view definition dialog (View->New view...)\nuse the background color as configured through the preferences, instead\nof hard-coded 'white'.\n\nThis was suggested by Paul Wise through\n http://bugs.debian.org/457124\n\nSigned-off-by: Gerrit Pape <pape@smarden.org>\n---\n gitk |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 684e614..7d70c64 100755\n--- a/gitk\n+++ b/gitk\n@@ -1881,7 +1881,7 @@ proc editview {} {\n \n proc vieweditor {top n title} {\n     global newviewname newviewperm viewfiles\n-    global uifont\n+    global uifont bgcolor\n \n     toplevel $top\n     wm title $top $title\n@@ -1895,12 +1895,12 @@ proc vieweditor {top n title} {\n \t-text [mc \"Commits to include (arguments to git rev-list):\"]\n     grid $top.al - -sticky w -pady 5\n     entry $top.args -width 50 -textvariable newviewargs($n) \\\n-\t-background white -font uifont\n+\t-background $bgcolor -font uifont\n     grid $top.args - -sticky ew -padx 5\n     message $top.l -aspect 1000 -font uifont \\\n \t-text [mc \"Enter files and directories to include, one per line:\"]\n     grid $top.l - -sticky w\n-    text $top.t -width 40 -height 10 -background white -font uifont\n+    text $top.t -width 40 -height 10 -background $bgcolor -font uifont\n     if {[info exists viewfiles($n)]} {\n \tforeach f $viewfiles($n) {\n \t    $top.t insert end $f\n-- \n1.5.3.7\n"},{"id":"64716","messageId":"20080108095534.18927.qmail@ea6d20fb1070bc.315fe32.mid.smarden.org","threadId":"11413","inReplyTo":"20071228145156.8106.qmail@6afea2d2003e0e.315fe32.mid.smarden.org","subject":"Re: [PATCH] gitk: use user-configured background in view definition dialog","fromName":"Gerrit Pape","fromEmail":"pape@smarden.org","sentAt":"2008-01-08T09:55:34Z","receivedAt":"2008-01-08T09:55:34Z","isPatch":true,"sender":{"key":"pape@smarden.org","avatar":"https://avatars.githubusercontent.com/u/143170252?v=4"},"body":"Hi, I suggest to apply this change to gitk.  Thanks, Gerrit.\n\n\nOn Fri, Dec 28, 2007 at 02:51:56PM +0000, Gerrit Pape wrote:\n> Have the text fields in the view definition dialog (View->New view...)\n> use the background color as configured through the preferences, instead\n> of hard-coded 'white'.\n> \n> This was suggested by Paul Wise through\n>  http://bugs.debian.org/457124\n> \n> Signed-off-by: Gerrit Pape <pape@smarden.org>\n> ---\n>  gitk |    6 +++---\n>  1 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/gitk b/gitk\n> index 684e614..7d70c64 100755\n> --- a/gitk\n> +++ b/gitk\n> @@ -1881,7 +1881,7 @@ proc editview {} {\n>  \n>  proc vieweditor {top n title} {\n>      global newviewname newviewperm viewfiles\n> -    global uifont\n> +    global uifont bgcolor\n>  \n>      toplevel $top\n>      wm title $top $title\n> @@ -1895,12 +1895,12 @@ proc vieweditor {top n title} {\n>  \t-text [mc \"Commits to include (arguments to git rev-list):\"]\n>      grid $top.al - -sticky w -pady 5\n>      entry $top.args -width 50 -textvariable newviewargs($n) \\\n> -\t-background white -font uifont\n> +\t-background $bgcolor -font uifont\n>      grid $top.args - -sticky ew -padx 5\n>      message $top.l -aspect 1000 -font uifont \\\n>  \t-text [mc \"Enter files and directories to include, one per line:\"]\n>      grid $top.l - -sticky w\n> -    text $top.t -width 40 -height 10 -background white -font uifont\n> +    text $top.t -width 40 -height 10 -background $bgcolor -font uifont\n>      if {[info exists viewfiles($n)]} {\n>  \tforeach f $viewfiles($n) {\n>  \t    $top.t insert end $f\n> -- \n> 1.5.3.7\n> \n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n"}]}