{"thread":{"id":"11407","subject":"[PATCH] Point out merged submodule maintainers as better addresses for patches","startedAt":"2007-12-27T04:12:20Z","lastAt":"2007-12-27T04:37:18Z","messageCount":2,"participants":["Shawn O. Pearce","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"64116","messageId":"20071227041220.GA22256@spearce.org","threadId":"11407","inReplyTo":null,"subject":"[PATCH] Point out merged submodule maintainers as better addresses for patches","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-12-27T04:12:20Z","receivedAt":"2007-12-27T04:12:20Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio doesn't directly manage the git-gui or gitk-git subdirectories\nwithin git.git; these are currently managed by other individuals\nand then periodically merged to git.git.  Users often send patches\nto Junio for these directories when they should be directed at the\ncurrent maintainer instead, so we should point out these special\ncases in the SubmittingPatches documentation.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n\n Just a suggestion.  Might help people who are new to the Git\n community to get involved.\n\n Documentation/SubmittingPatches |    8 +++++++-\n 1 files changed, 7 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex de08d09..b7c886c 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -34,10 +34,16 @@ Checklist (and a short version for the impatient):\n \t- if your name is not writable in ASCII, make sure that\n \t  you send off a message in the correct encoding.\n \t- send the patch to the list (git@vger.kernel.org) and the\n-\t  maintainer (gitster@pobox.com). If you use\n+\t  active maintainer (see below). If you use\n \t  git-send-email(1), please test it first by sending\n \t  email to yourself.\n \n+\tActive maintainers:\n+\n+\t- git-gui/ submodule:     spearce@spearce.org\n+\t- gitk-git/ submodule:    paulus@samba.org\n+\t- Everything else:        gitster@pobox.com\n+\n Long version:\n \n I started reading over the SubmittingPatches document for Linux\n-- \n1.5.4.rc2.1097.gb6e0d\n"},{"id":"64118","messageId":"7v1w98kb29.fsf@gitster.siamese.dyndns.org","threadId":"11407","inReplyTo":"20071227041220.GA22256@spearce.org","subject":"Re: [PATCH] Point out merged submodule maintainers as better addresses for patches","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-27T04:37:18Z","receivedAt":"2007-12-27T04:37:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Shawn O. Pearce\" <spearce@spearce.org> writes:\n\n> Junio doesn't directly manage the git-gui or gitk-git subdirectories\n> within git.git; these are currently managed by other individuals\n> and then periodically merged to git.git.  Users often send patches\n> to Junio for these directories when they should be directed at the\n> current maintainer instead, so we should point out these special\n> cases in the SubmittingPatches documentation.\n\nThis is a good start, but I think it would be good to mention\nthat contributors should at least Cc: the people who have been\nheavily involved in the past in the surrounding area of the code\nor documentation (not necessarily the last person who touched\nthe area) the patch attempts to improve and/or enhance.\n\nParts of the system are \"actively managed\" by people other than\nme even though they aren't merged with the subtree strategy.\nThe areas I mentioned in MaintNotes (in 'todo') are:\n\n - git-svn is generally deferred to Eric, unless the patch is\n   truly trivial.\n\n - Documentation/user-manual.txt is primarily JBF's bailiwick.\n\n - Nico is the guy around pack generation.\n\n - Jakub, Luben and Pasky are more familiar than I am with\n   gitweb.\n\nIn fact, I would rather see any nontrivial patch to be first\nsent \"To: \" such people with \"Cc: \" the list.  After it has been\nimproved into a good enough shape in the discussion that follows\n(i.e. success stories to back it up, and without regression\nreports and objections), I can pick up the last round directly\nfrom the list, or the active maintainer in the area (if exists;\nit might be a better wording to call them \"subsystem\nmaintainers\") can forward it to me to apply after a final\nsubmission is made.  Sending the final submission to the\nsubsystem maintainer who forwards it to the higher level is what\nthe kernel folks regularly do, but I do not think we are large\nenough to require such a formality.\n"}]}