{"thread":{"id":"11388","subject":"Re: [PATCH v2] Make git send-email accept $EDITOR with arguments","startedAt":"2007-12-21T21:37:12Z","lastAt":"2007-12-21T21:37:12Z","messageCount":1,"participants":["Gustaf Hendeby"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"63956","messageId":"476C3208.3030700@isy.liu.se","threadId":"11388","inReplyTo":null,"subject":"Re: [PATCH v2] Make git send-email accept $EDITOR with arguments","fromName":"Gustaf Hendeby","fromEmail":"hendeby@isy.liu.se","sentAt":"2007-12-21T21:37:12Z","receivedAt":"2007-12-21T21:37:12Z","isPatch":true,"sender":{"key":"hendeby@isy.liu.se","avatar":"https://avatars.githubusercontent.com/u/730316?v=4"},"body":"Sorry Junio for the double, but I didn't mean to cut the CCs on this one.\n\nOn 2007-12-21 18:02, Junio C Hamano wrote:\n> Gustaf Hendeby <hendeby@isy.liu.se> writes:\n> \n>> Junio, even if this is technically not a bug fix, it would be nice to\n>> get this fix into the 1.5.4 so that the usage of $EDITOR becomes more\n>> consistent throughout git.\n> \n> I can buy that, but at least a single line comment in front of that\n> system() explaining why this is safe to do so would be beneficial.  I\n> suspect that somebody would propose moving $compse_filename inside\n> $GIT_DIR, now people realized $compose_filename is currently \"./.msg.$$\",\n> and $GIT_DIR could be anything.  Quotemeta would probably be better as the\n> code you are touching won't be affected by a future change to the value of\n> that constant defined far away in the source.\n\nMoving that file makes sense, I'll have a look at that, and do that as\nwell when I fix this patch.  After a first look at it though, I was\nsurprised to learn that git send-email actually wont work outside a\nrepository.  Ok, I can't really see any workflow where git send-email is\ncalled from outside a git repository, but at the same time I don't see\nwhy is should not be possible.  Are there any special reason for this?\n\nThanks,\n\tGustaf\n"}]}