{"thread":{"id":"11354","subject":"[PATCH] clone: fix options '-o' and '--origin' to be recognised again","startedAt":"2007-12-19T09:15:15Z","lastAt":"2007-12-19T15:43:50Z","messageCount":3,"participants":["Marco Roeland","Junio C Hamano","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"63732","messageId":"20071219091515.GA20707@fiberbit.xs4all.nl","threadId":"11354","inReplyTo":null,"subject":"[PATCH] clone: fix options '-o' and '--origin' to be recognised again","fromName":"Marco Roeland","fromEmail":"marco.roeland@xs4all.nl","sentAt":"2007-12-19T09:15:15Z","receivedAt":"2007-12-19T09:15:15Z","isPatch":true,"sender":{"key":"marco.roeland@xs4all.nl","avatar":null},"body":"Due to a subtle typo in a shell case pattern neither alternative worked.\n\nSigned-off-by: Marco Roeland <marco.roeland@xs4all.nl>\n---\n\n This is a regression in 'next', introduced on Nov 4th by commit 94362599\n \"Migrate git-clone to use git-rev-parse --parseopt\". Added Kristian as\n he works on the builtin version; perhaps nice for a test case (!).\n\n git-clone.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-clone.sh b/git-clone.sh\nindex 9a160ee..b4e858c 100755\n--- a/git-clone.sh\n+++ b/git-clone.sh\n@@ -152,7 +152,7 @@ do\n \t\tdie \"clones are always made with separate-remote layout\" ;;\n \t--reference)\n \t\tshift; reference=\"$1\" ;;\n-\t-o,--origin)\n+\t-o|--origin)\n \t\tshift;\n \t\tcase \"$1\" in\n \t\t'')\n-- \n1.5.4.rc0.1162.g3bfea\n"},{"id":"63737","messageId":"7vbq8nvwzg.fsf@gitster.siamese.dyndns.org","threadId":"11354","inReplyTo":"20071219091515.GA20707@fiberbit.xs4all.nl","subject":"Re: [PATCH] clone: fix options '-o' and '--origin' to be recognised again","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-19T09:45:39Z","receivedAt":"2007-12-19T09:45:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.  That indeed was embarrassing.\n"},{"id":"63777","messageId":"20071219154350.GC13942@coredump.intra.peff.net","threadId":"11354","inReplyTo":"20071219091515.GA20707@fiberbit.xs4all.nl","subject":"Re: [PATCH] clone: fix options '-o' and '--origin' to be recognised again","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2007-12-19T15:43:50Z","receivedAt":"2007-12-19T15:43:50Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Dec 19, 2007 at 10:15:15AM +0100, Marco Roeland wrote:\n\n>  This is a regression in 'next', introduced on Nov 4th by commit 94362599\n>  \"Migrate git-clone to use git-rev-parse --parseopt\". Added Kristian as\n>  he works on the builtin version; perhaps nice for a test case (!).\n\nHere is a test case that catches this regression. It can perhaps be\nexpanded by Kristian to test other options, but is probably worth adding\nnow as a basic sanity check.\n\nI put the test in 5702. There seems to be a '5600' clone test, as well,\nwhich perhaps should be in the 57?? series.\n\n-- >8 --\ntest \"git clone -o\"\n\nThis tests a recently fixed regression in which \"git clone\n-o\" didn't work at all.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\n t/t5702-clone-options.sh |   22 ++++++++++++++++++++++\n 1 files changed, 22 insertions(+), 0 deletions(-)\n create mode 100755 t/t5702-clone-options.sh\n\ndiff --git a/t/t5702-clone-options.sh b/t/t5702-clone-options.sh\nnew file mode 100755\nindex 0000000..328e4d9\n--- /dev/null\n+++ b/t/t5702-clone-options.sh\n@@ -0,0 +1,22 @@\n+#!/bin/sh\n+\n+test_description='basic clone options'\n+. ./test-lib.sh\n+\n+test_expect_success 'setup' '\n+\n+\tmkdir parent &&\n+\t(cd parent && git init &&\n+\t echo one >file && git add file &&\n+\t git commit -m one)\n+\n+'\n+\n+test_expect_success 'clone -o' '\n+\n+\tgit clone -o foo parent clone-o &&\n+\t(cd clone-o && git rev-parse --verify refs/remotes/foo/master)\n+\n+'\n+\n+test_done\n-- \n1.5.4.rc0.1162.gaa83ae\n"}]}