{"thread":{"id":"11274","subject":"[PATCH] git-gui - Unconditionally use absolute paths with Cygwin","startedAt":"2007-12-13T14:02:26Z","lastAt":"2007-12-13T14:02:26Z","messageCount":1,"participants":["Mark Levedahl"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"63016","messageId":"1197554546-2260-1-git-send-email-mdl123@verizon.net","threadId":"11274","inReplyTo":null,"subject":"[PATCH] git-gui - Unconditionally use absolute paths with Cygwin","fromName":"Mark Levedahl","fromEmail":"mdl123@verizon.net","sentAt":"2007-12-13T14:02:26Z","receivedAt":"2007-12-13T14:02:26Z","isPatch":true,"sender":{"key":"mdl123@verizon.net","avatar":"https://avatars.githubusercontent.com/u/5302462?v=4"},"body":"The mapping of Windows vs Cygwin/Posix paths is arbitrary and not knowable\nfrom the Posix side, so logic to determine whether to use relative paths\nto locate the git-gui library just does not work on Cygwin. Fix this to\nunconditionally use absolute path on Cygwin. (This fixes a regression\nfrom 1.5.4).\n\nSigned-off-by: Mark Levedahl <mdl123@verizon.net>\n---\n git-gui/Makefile |   10 ++++------\n 1 files changed, 4 insertions(+), 6 deletions(-)\n\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex 26ac4b6..c109eab 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -117,14 +117,12 @@ GITGUI_SCRIPT   := $$0\n GITGUI_RELATIVE :=\n GITGUI_MACOSXAPP :=\n \n-ifeq ($(exedir),$(gg_libdir))\n-\tGITGUI_RELATIVE := 1\n-endif\n-\n ifeq ($(uname_O),Cygwin)\n \tGITGUI_SCRIPT := `cygpath --windows --absolute \"$(GITGUI_SCRIPT)\"`\n-\tifeq ($(GITGUI_RELATIVE),)\n-\t\tgg_libdir := $(shell cygpath --windows --absolute \"$(gg_libdir)\")\n+\tgg_libdir := $(shell cygpath --windows --absolute \"$(gg_libdir)\")\n+else\n+\tifeq ($(exedir),$(gg_libdir))\n+\t\tGITGUI_RELATIVE := 1\n \tendif\n endif\n ifeq ($(uname_S),Darwin)\n-- \n1.5.3.7.1167.g12f9a\n"}]}