{"thread":{"id":"11235","subject":"[PATCH] Brown paper bag fix to previous send-email change","startedAt":"2007-12-11T06:55:16Z","lastAt":"2007-12-11T08:06:06Z","messageCount":5,"participants":["Mike Hommey","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"62670","messageId":"1197356116-12176-1-git-send-email-mh@glandium.org","threadId":"11235","inReplyTo":null,"subject":"[PATCH] Brown paper bag fix to previous send-email change","fromName":"Mike Hommey","fromEmail":"mh@glandium.org","sentAt":"2007-12-11T06:55:16Z","receivedAt":"2007-12-11T06:55:16Z","isPatch":true,"sender":{"key":"mh@glandium.org","avatar":"https://avatars.githubusercontent.com/u/1038527?v=4"},"body":"My previous change led to the In-Reply-To header being <> when the given\nvalue was empty. This fixes it.\n\nSigned-off-by: Mike Hommey <mh@glandium.org>\n---\n\n I think I have an antispam problem somewhere with this patch, because even\n keeping sending it, it never reached the list. And Junio didn't answer to my\n private message about it, so I guess that was some server being smart with\n the subject line. *sigh*\n\n PS: sorry Junio if you get this patch multiple time.\n\n git-send-email.perl |    6 ++++--\n 1 files changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex c0e1dd3..0e8c457 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -369,8 +369,10 @@ if ($thread && !defined $initial_reply_to && $prompting) {\n \t$initial_reply_to = $_;\n }\n \n-$initial_reply_to =~ s/^\\s*<?/</;\n-$initial_reply_to =~ s/>?\\s*$/>/;\n+if ($initial_reply_to) {\n+\t$initial_reply_to =~ s/^\\s*<?/</;\n+\t$initial_reply_to =~ s/>?\\s*$/>/;\n+}\n \n if (!defined $smtp_server) {\n \tforeach (qw( /usr/sbin/sendmail /usr/lib/sendmail )) {\n-- \n1.5.3.7.1161.g14b8\n"},{"id":"62675","messageId":"7v3au9hfuj.fsf@gitster.siamese.dyndns.org","threadId":"11235","inReplyTo":"1197356116-12176-1-git-send-email-mh@glandium.org","subject":"Re: [PATCH] Brown paper bag fix to previous send-email change","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-11T07:04:36Z","receivedAt":"2007-12-11T07:04:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mike Hommey <mh@glandium.org> writes:\n\n> My previous change led to the In-Reply-To header being <> when the given\n> value was empty. This fixes it.\n>\n> Signed-off-by: Mike Hommey <mh@glandium.org>\n> ---\n>\n>  I think I have an antispam problem somewhere with this patch, because even\n>  keeping sending it, it never reached the list. And Junio didn't answer to my\n>  private message about it, so I guess that was some server being smart with\n>  the subject line. *sigh*\n>\n>  PS: sorry Junio if you get this patch multiple time.\n\nNo, I happened to have noticed the same and have an almost identical fix\n(I said \"defined $initial_reply_to\") already queued in my tree.\n"},{"id":"62680","messageId":"20071211074427.GA12959@glandium.org","threadId":"11235","inReplyTo":"7v3au9hfuj.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Brown paper bag fix to previous send-email change","fromName":"Mike Hommey","fromEmail":"mh@glandium.org","sentAt":"2007-12-11T07:44:28Z","receivedAt":"2007-12-11T07:44:28Z","isPatch":true,"sender":{"key":"mh@glandium.org","avatar":"https://avatars.githubusercontent.com/u/1038527?v=4"},"body":"On Mon, Dec 10, 2007 at 11:04:36PM -0800, Junio C Hamano wrote:\n> Mike Hommey <mh@glandium.org> writes:\n> \n> > My previous change led to the In-Reply-To header being <> when the given\n> > value was empty. This fixes it.\n> >\n> > Signed-off-by: Mike Hommey <mh@glandium.org>\n> > ---\n> >\n> >  I think I have an antispam problem somewhere with this patch, because even\n> >  keeping sending it, it never reached the list. And Junio didn't answer to my\n> >  private message about it, so I guess that was some server being smart with\n> >  the subject line. *sigh*\n> >\n> >  PS: sorry Junio if you get this patch multiple time.\n> \n> No, I happened to have noticed the same and have an almost identical fix\n> (I said \"defined $initial_reply_to\") already queued in my tree.\n\nTesting \"defined $initial_reply_to\" might not be enough, because $initial_reply_to\ncan be defined and empty.\n\nMike\n"},{"id":"62682","messageId":"7vsl29fym6.fsf@gitster.siamese.dyndns.org","threadId":"11235","inReplyTo":"20071211074427.GA12959@glandium.org","subject":"Re: [PATCH] Brown paper bag fix to previous send-email change","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-11T08:02:09Z","receivedAt":"2007-12-11T08:02:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mike Hommey <mh@glandium.org> writes:\n\n> On Mon, Dec 10, 2007 at 11:04:36PM -0800, Junio C Hamano wrote:\n>> Mike Hommey <mh@glandium.org> writes:\n>> \n>> > My previous change led to the In-Reply-To header being <> when the given\n>> > value was empty. This fixes it.\n>> >\n>> > Signed-off-by: Mike Hommey <mh@glandium.org>\n>> > ---\n>> >\n>> >  I think I have an antispam problem somewhere with this patch, because even\n>> >  keeping sending it, it never reached the list. And Junio didn't answer to my\n>> >  private message about it, so I guess that was some server being smart with\n>> >  the subject line. *sigh*\n>> >\n>> >  PS: sorry Junio if you get this patch multiple time.\n>> \n>> No, I happened to have noticed the same and have an almost identical fix\n>> (I said \"defined $initial_reply_to\") already queued in my tree.\n>\n> Testing \"defined $initial_reply_to\" might not be enough, because $initial_reply_to\n> can be defined and empty.\n\nAnd if empty what does your regexp do?  Produce \"<>\"?  How's that\nuseful?\n"},{"id":"62683","messageId":"7vlk81fyfl.fsf@gitster.siamese.dyndns.org","threadId":"11235","inReplyTo":"20071211074427.GA12959@glandium.org","subject":"Re: [PATCH] Brown paper bag fix to previous send-email change","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-11T08:06:06Z","receivedAt":"2007-12-11T08:06:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mike Hommey <mh@glandium.org> writes:\n\n>> No, I happened to have noticed the same and have an almost identical fix\n>> (I said \"defined $initial_reply_to\") already queued in my tree.\n>\n> Testing \"defined $initial_reply_to\" might not be enough, because $initial_reply_to\n> can be defined and empty.\n\nAh, I see what you mean.  Thanks.\n"}]}