{"thread":{"id":"11213","subject":"[PATCH] autoconf: Check autoconf version (ASCIIDOC8)","startedAt":"2007-12-09T12:57:39Z","lastAt":"2007-12-11T08:34:28Z","messageCount":3,"participants":["Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"62483","messageId":"1197205059-16742-1-git-send-email-jnareb@gmail.com","threadId":"11213","inReplyTo":null,"subject":"[PATCH] autoconf: Check autoconf version (ASCIIDOC8)","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-12-09T12:57:39Z","receivedAt":"2007-12-09T12:57:39Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Check for asciidoc, and if it exists check asciidoc version, setting\nASCIIDOC8 when needed.  Currently it just runs asciidoc in asciidoc7\ncompatibility mode (see: Documentation/Makefile).\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nHmmm... perhaps ASCIIDOC8 should be called ASCIIDOC7COMPATIBILITY?\nWe should revisit Makefiles and configure.ac when asciidoc 9 gets\nreleased.\n\nThis should be \"git portability\" portable, even if it is not portable\naccording to \"instanely autoconf-like portable\" rules  ;-)\n\n config.mak.in |    2 ++\n configure.ac  |   21 +++++++++++++++++++++\n 2 files changed, 23 insertions(+), 0 deletions(-)\n\ndiff --git a/config.mak.in b/config.mak.in\nindex 7d5df9b..759470a 100644\n--- a/config.mak.in\n+++ b/config.mak.in\n@@ -7,6 +7,7 @@ AR = @AR@\n TAR = @TAR@\n #INSTALL = @INSTALL@\t\t# needs install-sh or install.sh in sources\n TCLTK_PATH = @TCLTK_PATH@\n+ASCIIDOC=@ASCIIDOC@\n \n prefix = @prefix@\n exec_prefix = @exec_prefix@\n@@ -23,6 +24,7 @@ VPATH = @srcdir@\n export exec_prefix mandir\n export srcdir VPATH\n \n+ASCIIDOC8=@ASCIIDOC8@\n NEEDS_SSL_WITH_CRYPTO=@NEEDS_SSL_WITH_CRYPTO@\n NO_OPENSSL=@NO_OPENSSL@\n NO_CURL=@NO_CURL@\ndiff --git a/configure.ac b/configure.ac\nindex dd4b4eb..6f641e3 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -122,6 +122,27 @@ if test -z \"$NO_TCLTK\"; then\n     AC_SUBST(TCLTK_PATH)\n   fi\n fi\n+AC_CHECK_PROGS(ASCIIDOC, [asciidoc])\n+if test -n \"$ASCIIDOC\"; then\n+\tAC_MSG_CHECKING([for asciidoc version])\n+\tasciidoc_version=`$ASCIIDOC --version 2>&1`\n+\tcase \"${asciidoc_version}\" in\n+\tasciidoc' '8*)\n+\t\tASCIIDOC8=YesPlease\n+\t\tAC_MSG_RESULT([${asciidoc_version} > 7])\n+\t\t;;\n+\tasciidoc' '7*)\n+\t\tASCIIDOC8=\n+\t\tAC_MSG_RESULT([${asciidoc_version}])\n+\t\t;;\n+\t*)\n+\t\tASCIIDOC8=\n+\t\tAC_MSG_RESULT([${asciidoc_version} (unknown)])\n+\t\t;;\n+\tesac\n+fi\n+AC_SUBST(ASCIIDOC8)\n+\n \n ## Checks for libraries.\n AC_MSG_NOTICE([CHECKS for libraries])\n-- \n1.5.3.7\n"},{"id":"62641","messageId":"7vhciqhqnd.fsf@gitster.siamese.dyndns.org","threadId":"11213","inReplyTo":"1197205059-16742-1-git-send-email-jnareb@gmail.com","subject":"Re: [PATCH] autoconf: Check autoconf version (ASCIIDOC8)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-11T03:11:18Z","receivedAt":"2007-12-11T03:11:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> Subject: Re: [PATCH] autoconf: Check autoconf version (ASCIIDOC8)\n\nThat's \"Check asciidoc version\".\n\n> Check for asciidoc, and if it exists check asciidoc version, setting\n> ASCIIDOC8 when needed.  Currently it just runs asciidoc in asciidoc7\n> compatibility mode (see: Documentation/Makefile).\n>\n> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n> ---\n> diff --git a/config.mak.in b/config.mak.in\n> index 7d5df9b..759470a 100644\n> --- a/config.mak.in\n> +++ b/config.mak.in\n> @@ -7,6 +7,7 @@ AR = @AR@\n>  TAR = @TAR@\n>  #INSTALL = @INSTALL@\t\t# needs install-sh or install.sh in sources\n>  TCLTK_PATH = @TCLTK_PATH@\n> +ASCIIDOC=@ASCIIDOC@\n\nAnd this is \"ASCIIDOC8=@ASCIIDOC8@\", I think.\n\nWill apply with the said fixups.\n\nThanks.\n"},{"id":"62686","messageId":"200712110934.29746.jnareb@gmail.com","threadId":"11213","inReplyTo":"7vhciqhqnd.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] autoconf: Check autoconf version (ASCIIDOC8)","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-12-11T08:34:28Z","receivedAt":"2007-12-11T08:34:28Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n> Jakub Narebski <jnareb@gmail.com> writes:\n> \n> > Subject: Re: [PATCH] autoconf: Check autoconf version (ASCIIDOC8)\n> \n> That's \"Check asciidoc version\".\n\nYep. Sorry for mistake (autoconf <-> asciidoc).\n\n> > Check for asciidoc, and if it exists check asciidoc version, setting\n> > ASCIIDOC8 when needed.  Currently it just runs asciidoc in asciidoc7\n> > compatibility mode (see: Documentation/Makefile).\n> >\n> > Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n> > ---\n> > diff --git a/config.mak.in b/config.mak.in\n> > index 7d5df9b..759470a 100644\n> > --- a/config.mak.in\n> > +++ b/config.mak.in\n> > @@ -7,6 +7,7 @@ AR = @AR@\n> >  TAR = @TAR@\n> >  #INSTALL = @INSTALL@\t\t# needs install-sh or install.sh in sources\n> >  TCLTK_PATH = @TCLTK_PATH@\n> > +ASCIIDOC=@ASCIIDOC@\n> \n> And this is \"ASCIIDOC8=@ASCIIDOC8@\", I think.\n\nNope. ASCIIDOC8=@ASCIIDOC8@ is in chunk below, this is for [future]\ndetecting asciidoc binary (so you can drop this chunk).\n\n-- \nJakub Narebski\nPoland\n"}]}