{"thread":{"id":"11196","subject":"[PATCH] gitweb: Make config_to_multi return [] instead of [undef]","startedAt":"2007-12-08T12:30:59Z","lastAt":"2007-12-09T08:29:21Z","messageCount":3,"participants":["Petr Baudis","Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"62415","messageId":"20071208123058.7364.25491.stgit@rover","threadId":"11196","inReplyTo":null,"subject":"[PATCH] gitweb: Make config_to_multi return [] instead of [undef]","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-12-08T12:30:59Z","receivedAt":"2007-12-08T12:30:59Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"This is important for the list of clone urls, where if there are\nno per-repository clone URL configured, the default base URLs\nare never used for URL construction with this patch.\n\nSigned-off-by: Petr Baudis <pasky@suse.cz>\n---\n\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 491a3f4..d5505a4 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1512,7 +1512,7 @@ sub config_to_int {\n sub config_to_multi {\n \tmy $val = shift;\n \n-\treturn ref($val) ? $val : [ $val ];\n+\treturn ref($val) ? $val : $val ? [ $val ] : [];\n }\n \n sub git_get_project_config {\n"},{"id":"62419","messageId":"m38x45tb9y.fsf@roke.D-201","threadId":"11196","inReplyTo":"20071208123058.7364.25491.stgit@rover","subject":"Re: [PATCH] gitweb: Make config_to_multi return [] instead of [undef]","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-12-08T16:13:45Z","receivedAt":"2007-12-08T16:13:45Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Petr Baudis <pasky@suse.cz> writes:\n\n> This is important for the list of clone urls, where if there are\n> no per-repository clone URL configured, the default base URLs\n> are never used for URL construction with this patch.\n\nThanks.\n \n> @@ -1512,7 +1512,7 @@ sub config_to_int {\n>  sub config_to_multi {\n>  \tmy $val = shift;\n>  \n> -\treturn ref($val) ? $val : [ $val ];\n> +\treturn ref($val) ? $val : $val ? [ $val ] : [];\n>  }\n\nShouldn't it be\n\n  +\treturn ref($val) ? $val : defined($val) ? [ $val ] : [];\n\n-- \nJakub Narebski\n"},{"id":"62467","messageId":"7vlk84s23i.fsf@gitster.siamese.dyndns.org","threadId":"11196","inReplyTo":"m38x45tb9y.fsf@roke.D-201","subject":"Re: [PATCH] gitweb: Make config_to_multi return [] instead of [undef]","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-09T08:29:21Z","receivedAt":"2007-12-09T08:29:21Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> Petr Baudis <pasky@suse.cz> writes:\n>\n>> This is important for the list of clone urls, where if there are\n>> no per-repository clone URL configured, the default base URLs\n>> are never used for URL construction with this patch.\n>\n> Thanks.\n>  \n>> @@ -1512,7 +1512,7 @@ sub config_to_int {\n>>  sub config_to_multi {\n>>  \tmy $val = shift;\n>>  \n>> -\treturn ref($val) ? $val : [ $val ];\n>> +\treturn ref($val) ? $val : $val ? [ $val ] : [];\n>>  }\n>\n> Shouldn't it be\n>\n>   +\treturn ref($val) ? $val : defined($val) ? [ $val ] : [];\n\nI think so.  Pasky?\n"}]}